From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF2B2C433DF for ; Mon, 19 Oct 2020 15:26:41 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68CA12231B for ; Mon, 19 Oct 2020 15:26:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gk7Ft9DB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68CA12231B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.8748.23483 (Exim 4.92) (envelope-from ) id 1kUX3Q-00087G-Dw; Mon, 19 Oct 2020 15:26:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 8748.23483; Mon, 19 Oct 2020 15:26:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUX3Q-000879-Az; Mon, 19 Oct 2020 15:26:32 +0000 Received: by outflank-mailman (input) for mailman id 8748; Mon, 19 Oct 2020 15:26:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUX3O-00086w-GZ for xen-devel@lists.xenproject.org; Mon, 19 Oct 2020 15:26:30 +0000 Received: from mail-lf1-x142.google.com (unknown [2a00:1450:4864:20::142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ad5d1bca-7b4c-4780-9406-2c7a76caf4f5; Mon, 19 Oct 2020 15:26:29 +0000 (UTC) Received: by mail-lf1-x142.google.com with SMTP id j30so14680432lfp.4 for ; Mon, 19 Oct 2020 08:26:29 -0700 (PDT) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kUX3O-00086w-GZ for xen-devel@lists.xenproject.org; Mon, 19 Oct 2020 15:26:30 +0000 X-Inumbo-ID: ad5d1bca-7b4c-4780-9406-2c7a76caf4f5 Received: from mail-lf1-x142.google.com (unknown [2a00:1450:4864:20::142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ad5d1bca-7b4c-4780-9406-2c7a76caf4f5; Mon, 19 Oct 2020 15:26:29 +0000 (UTC) Received: by mail-lf1-x142.google.com with SMTP id j30so14680432lfp.4 for ; Mon, 19 Oct 2020 08:26:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QIs+2ZoR3i3pz+qqVrJep3R4w4Yivn+en8MAoLnkTA0=; b=gk7Ft9DBlookh7ly0b+NVSlnGjwjtOCnh4QX5qp7SRNMTgWA0DEx08n3OTaPzoPw+g HO2TS3iMeO6k+yx5cFX1SpvtlbI8QFgz1TmkVGsd1Q/eN1XsFAM7nj3I+jj2IGbuPEHl Q90SiRzFK8dMY1xCTc7FHDjXij+zLgKc1rsXBgTEkb9VtOxHBxHhDZK2LBQ9Ex6cH2by EmaUGcqTA1qKF36KpKMGq5yAKbmzm8jnbB7QQU6snjCjE3tXGJWSFX4jpBMvwjmqAiYa oy5avgoqbt5CqZ1dNpTBKMyEzS3sijy++DH/9yNcN/3jyIDfcWEU6A8RxIAfBSEKm8o1 uPCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QIs+2ZoR3i3pz+qqVrJep3R4w4Yivn+en8MAoLnkTA0=; b=j+303N7Lixa6KuxgSOvJVJQacTf54rMIw5puW3sQX/8hFopMxsv8/JpE4mhwYjv2T5 EgtwObZGSWPtMKbb7n7c0IkXU+eFwr+Oz4IgSZ/HeL7gnsX4+LetuaO979I2rSfZuci3 5gZvUDxGNfq5hETX+YCGV7gLxv5bCBC+NZN8vDJnfDWTVf0/bpkNfokO8ooW4tc+6Sl+ 5GsBPsVZClb6INThwvNAXKnTgj/5fyRIQDC+d10lcuAMqbHNN6pJeFkUm4zh7xHF0XZ5 05udjyYVzZd26SZlyT9F9kVgDEvB7nPDF0elkO7jVWykbaj29ftSIf7m3Kzl0peh3cAY +dsw== X-Gm-Message-State: AOAM533D2HWcuxmmc3isBQdmuJ+mGlbaeUhWASyq2vP7aVg21e3CGYDt 33C5nOmAO8zrMY48K26QuLDibw8VS+0hMlIvA2A= X-Google-Smtp-Source: ABdhPJx4eyRaCUZG26uK8S97QMfZRuh+9xPt2obMCSmXVopsTcfufsRxM6589WGoDdlq0bwkiXbMZerHBanKIBTlaXc= X-Received: by 2002:ac2:52b7:: with SMTP id r23mr78904lfm.30.1603121188232; Mon, 19 Oct 2020 08:26:28 -0700 (PDT) MIME-Version: 1.0 References: <20201014153150.83875-1-jandryuk@gmail.com> <6d373cae-c7dc-e109-1df3-ccbbe4bdd9c8@suse.com> <4229544b-e98d-6f3c-14aa-a884c403ba74@suse.com> In-Reply-To: From: Jason Andryuk Date: Mon, 19 Oct 2020 11:26:16 -0400 Message-ID: Subject: Re: [PATCH] libelf: Handle PVH kernels lacking ENTRY elfnote To: Jan Beulich Cc: xen-devel , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu Content-Type: text/plain; charset="UTF-8" On Mon, Oct 19, 2020 at 3:38 AM Jan Beulich wrote: > > On 16.10.2020 18:28, Jason Andryuk wrote: > > Looks like we can pass XC_DOM_PV_CONTAINER/XC_DOM_HVM_CONTAINER down > > into elf_xen_parse(). Then we would just validate phys_entry for HVM > > and virt_entry for PV. Does that sound reasonable? > > I think so, yes. Assuming of course that you'll convert the XC_DOM_* > into a boolean, so that the hypervisor's use of libelf/ can also be > suitably adjusted. Are you okay with: -int elf_xen_parse(struct elf_binary *elf, - struct elf_dom_parms *parms); +int elf_xen_parse_pvh(struct elf_binary *elf, + struct elf_dom_parms *parms); +int elf_xen_parse_pv(struct elf_binary *elf, + struct elf_dom_parms *parms); ? I prefer avoiding boolean arguments since I find it helps readability. The xen dom0 builders can just call their variant, but the xenguest elfloader and hvmloader call the appropriate one based on the container_type. Regards, Jason