From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97905C433F5 for ; Mon, 25 Oct 2021 12:32:05 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6428F6023F for ; Mon, 25 Oct 2021 12:32:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6428F6023F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.215802.375173 (Exim 4.92) (envelope-from ) id 1mez8u-0006q5-7q; Mon, 25 Oct 2021 12:31:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 215802.375173; Mon, 25 Oct 2021 12:31:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mez8u-0006py-3e; Mon, 25 Oct 2021 12:31:56 +0000 Received: by outflank-mailman (input) for mailman id 215802; Mon, 25 Oct 2021 12:31:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mez8t-0006ps-2V for xen-devel@lists.xenproject.org; Mon, 25 Oct 2021 12:31:55 +0000 Received: from mail-lf1-x136.google.com (unknown [2a00:1450:4864:20::136]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fce91ae7-2e36-44a4-8970-bd11ddf32f18; Mon, 25 Oct 2021 12:31:54 +0000 (UTC) Received: by mail-lf1-x136.google.com with SMTP id y26so9106494lfa.11 for ; Mon, 25 Oct 2021 05:31:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fce91ae7-2e36-44a4-8970-bd11ddf32f18 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rsXzxcxV0y5xMwXg4e7QntuXuk695o/R/LGfdUxufpA=; b=UclQCWoAv/aInb3BX+pcCYm0XwoRRLg80Fem/NVkw+y0qjEEcpB76FpBdjTp8vuK1l z50Yeu6KoK2B/7LVypXChh0LkNiwjKjm3orMDx5yOABtMiwwjkYs3NEIx7h3KxkjdDdP Ek7NLHytlcCgWuz6xBQYu3Q403aKF7vQuGLXhTVh6z0Pzvn+JGXltleEp250t38JzH5j s4EPzZTZxzd/l83xcwuR+WVOPek9mSUTXQbRelreN6AZqWyrHC3KmxczQUZfWae9+KEL vTq70uNd/ShSO42sqqkPdHucUQN/mJWzpyYYCytxFaJSHRB87w0ZDUWAzYEf5GEHdsqO ar2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rsXzxcxV0y5xMwXg4e7QntuXuk695o/R/LGfdUxufpA=; b=ZZJhaM+r4o8y49fuVVtxG8A9zE5OYpjca+VQOj/FzVn1IW+1XytBon2qhuaNpP0U6Y KPz6cwJKt22FCKiDY/6g3RwiMrcQjHYAdZ7Yg1ST4gVW37KwxlUW0VERU4ikCoAZwbTA U0vSURk/TZaP1OkDYsSNAZmB47iPmndLcvyKmqSSpbn+qt1o3excs7lRgPzCDoJ2NYQI qFQhD18jirSsqC0rMMUEG/q6aRWjd/v/0+0jSCYhlIj5oOB5VVYpg4JNYL4xvvJU8OvU csw/cTCOfFQNOkuLkP2OuuW/9WeymhA/Vfg5osLxdhxPySxR/0tEaZa8qL3g7JjIqxrY 7w4g== X-Gm-Message-State: AOAM533fSct46dHLpySFaK31v28Ehbjhnn7Ia0EE6Fk/UbJJ5mjhCxF4 zqGoZCZCzoqy4458hxWBlrT6AkFnwXJzTajSrTA= X-Google-Smtp-Source: ABdhPJzmw7j45jN5rCnXFGhqUnslOEjOY9G+jsrw/HmHox7WH0FH5oHXmcXWmHzJplbhYRjkRg+VGMR9MuRvpdL6/j4= X-Received: by 2002:a19:7903:: with SMTP id u3mr15963739lfc.406.1635165113269; Mon, 25 Oct 2021 05:31:53 -0700 (PDT) MIME-Version: 1.0 References: <90277228-cf14-0cfa-c95e-d42e7d533353@oderland.se> <20211025012503.33172-1-jandryuk@gmail.com> In-Reply-To: From: Jason Andryuk Date: Mon, 25 Oct 2021 08:31:41 -0400 Message-ID: Subject: Re: [PATCH] PCI/MSI: Fix masking MSI/MSI-X on Xen PV To: David Woodhouse Cc: Josef Johansson , Boris Ostrovsky , Bjorn Helgaas , Juergen Gross , linux-pci@vger.kernel.org, Marc Zyngier , Thomas Gleixner , xen-devel Content-Type: text/plain; charset="UTF-8" On Mon, Oct 25, 2021 at 3:44 AM David Woodhouse wrote: > > On Sun, 2021-10-24 at 21:25 -0400, Jason Andryuk wrote: > > commit fcacdfbef5a1 ("PCI/MSI: Provide a new set of mask and unmask > > functions") introduce functions pci_msi_update_mask() and > > pci_msix_write_vector_ctrl() that is missing checks for > > pci_msi_ignore_mask that exists in commit 446a98b19fd6 ("PCI/MSI: Use > > new mask/unmask functions"). The checks are in place at the high level > > __pci_msi_mask_desc()/__pci_msi_unmask_desc(), but some functions call > > directly to the helpers. > > > > Push the pci_msi_ignore_mask check down to the functions that make > > the actual writes. This keeps the logic local to the writes that need > > to be bypassed. > > > > With Xen PV, the hypervisor is responsible for masking and unmasking the > > interrupts, which pci_msi_ignore_mask is used to indicate. > > This isn't just for Xen PV; Xen HVM guests let Xen unmask the MSI for > them too. Ah, that makes sense that Xen handles both. I was repeating another commit message's statement. Oh, it looks like pci_msi_ignore_mask is PV-specific. Regards, Jason