From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Lutomirski Subject: Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops Date: Mon, 14 Mar 2016 10:05:25 -0700 Message-ID: References: <20160314120202.GD15800@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160314120202.GD15800@pd.tnic> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Borislav Petkov Cc: KVM list , Peter Zijlstra , Linus Torvalds , X86 ML , "linux-kernel@vger.kernel.org" , xen-devel , Andy Lutomirski , Paolo Bonzini , Andrew Morton , Arjan van de Ven List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBNYXIgMTQsIDIwMTYgYXQgNTowMiBBTSwgQm9yaXNsYXYgUGV0a292IDxicEBhbGll bjguZGU+IHdyb3RlOgo+IE9uIFNhdCwgTWFyIDEyLCAyMDE2IGF0IDEwOjA4OjQ5QU0gLTA4MDAs IEFuZHkgTHV0b21pcnNraSB3cm90ZToKPj4gVGhpcyBkZW1vdGVzIGFuIE9PUFMgYW5kIGxpa2Vs eSBwYW5pYyBkdWUgdG8gYSBmYWlsZWQgbm9uLSJzYWZlIiBNU1IKPj4gYWNjZXNzIHRvIGEgV0FS Tl9PTkNFIGFuZCwgZm9yIFJETVNSLCBhIHJldHVybiB2YWx1ZSBvZiB6ZXJvLiAgSWYKPj4gcGFu aWNfb25fb29wcyBpcyBzZXQsIHRoZW4gZmFpbGVkIHVuc2FmZSBNU1IgYWNjZXNzZXMgd2lsbCBz dGlsbAo+PiBvb3BzIGFuZCBwYW5pYy4KPj4KPj4gVG8gYmUgY2xlYXIsIHRoaXMgdHlwZSBvZiBm YWlsdXJlIHNob3VsZCAqbm90KiBoYXBwZW4uICBUaGlzIHBhdGNoCj4+IGV4aXN0cyB0byBtaW5p bWl6ZSB0aGUgY2hhbmNlIG9mIG5hc3R5IHVuZGVidWdnYWJsZSBmYWlsdXJlcyBkdWUgb24KPj4g c3lzdGVtcyB0aGF0IHVzZWQgdG8gd29yayBkdWUgdG8gYSBub3ctZml4ZWQgQ09ORklHX1BBUkFW SVJUPXkgYnVnLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBBbmR5IEx1dG9taXJza2kgPGx1dG9Aa2Vy bmVsLm9yZz4KPj4gLS0tCj4+ICBhcmNoL3g4Ni9pbmNsdWRlL2FzbS9tc3IuaCB8IDEwICsrKysr KysrLS0KPj4gIGFyY2gveDg2L21tL2V4dGFibGUuYyAgICAgIHwgMzMgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrCj4+ICAyIGZpbGVzIGNoYW5nZWQsIDQxIGluc2VydGlvbnMoKyks IDIgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9t c3IuaCBiL2FyY2gveDg2L2luY2x1ZGUvYXNtL21zci5oCj4+IGluZGV4IDkzZmI3YzFjZmZkYS4u MTQ4NzA1NGExYTcwIDEwMDY0NAo+PiAtLS0gYS9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9tc3IuaAo+ PiArKysgYi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9tc3IuaAo+PiBAQCAtOTIsNyArOTIsMTAgQEAg c3RhdGljIGlubGluZSB1bnNpZ25lZCBsb25nIGxvbmcgbmF0aXZlX3JlYWRfbXNyKHVuc2lnbmVk IGludCBtc3IpCj4+ICB7Cj4+ICAgICAgIERFQ0xBUkVfQVJHUyh2YWwsIGxvdywgaGlnaCk7Cj4+ Cj4+IC0gICAgIGFzbSB2b2xhdGlsZSgicmRtc3IiIDogRUFYX0VEWF9SRVQodmFsLCBsb3csIGhp Z2gpIDogImMiIChtc3IpKTsKPj4gKyAgICAgYXNtIHZvbGF0aWxlKCIxOiByZG1zclxuIgo+PiAr ICAgICAgICAgICAgICAgICAgIjI6XG4iCj4+ICsgICAgICAgICAgICAgICAgICBfQVNNX0VYVEFC TEVfSEFORExFKDFiLCAyYiwgZXhfaGFuZGxlcl9yZG1zcl91bnNhZmUpCj4+ICsgICAgICAgICAg ICAgICAgICA6IEVBWF9FRFhfUkVUKHZhbCwgbG93LCBoaWdoKSA6ICJjIiAobXNyKSk7Cj4+ICAg ICAgIGlmIChtc3JfdHJhY2Vwb2ludF9hY3RpdmUoX190cmFjZXBvaW50X3JlYWRfbXNyKSkKPj4g ICAgICAgICAgICAgICBkb190cmFjZV9yZWFkX21zcihtc3IsIEVBWF9FRFhfVkFMKHZhbCwgbG93 LCBoaWdoKSwgMCk7Cj4+ICAgICAgIHJldHVybiBFQVhfRURYX1ZBTCh2YWwsIGxvdywgaGlnaCk7 Cj4+IEBAIC0xMTksNyArMTIyLDEwIEBAIHN0YXRpYyBpbmxpbmUgdW5zaWduZWQgbG9uZyBsb25n IG5hdGl2ZV9yZWFkX21zcl9zYWZlKHVuc2lnbmVkIGludCBtc3IsCj4+ICBzdGF0aWMgaW5saW5l IHZvaWQgbmF0aXZlX3dyaXRlX21zcih1bnNpZ25lZCBpbnQgbXNyLAo+PiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG93LCB1bnNpZ25lZCBoaWdoKQo+PiAgewo+ PiAtICAgICBhc20gdm9sYXRpbGUoIndybXNyIiA6IDogImMiIChtc3IpLCAiYSIobG93KSwgImQi IChoaWdoKSA6ICJtZW1vcnkiKTsKPj4gKyAgICAgYXNtIHZvbGF0aWxlKCIxOiB3cm1zclxuIgo+ PiArICAgICAgICAgICAgICAgICAgIjI6XG4iCj4+ICsgICAgICAgICAgICAgICAgICBfQVNNX0VY VEFCTEVfSEFORExFKDFiLCAyYiwgZXhfaGFuZGxlcl93cm1zcl91bnNhZmUpCj4KPiBUaGlzIG1p Z2h0IGJlIGEgZ29vZCBpZGVhOgo+Cj4gWyAgICAwLjIyMDA2Nl0gY3B1aWRsZTogdXNpbmcgZ292 ZXJub3IgbWVudQo+IFsgICAgMC4yMjQwMDBdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0t LS0tLS0tLQo+IFsgICAgMC4yMjQwMDBdIFdBUk5JTkc6IENQVTogMCBQSUQ6IDEgYXQgYXJjaC94 ODYvbW0vZXh0YWJsZS5jOjc0IGV4X2hhbmRsZXJfd3Jtc3JfdW5zYWZlKzB4NzMvMHg4MCgpCj4g WyAgICAwLjIyNDAwMF0gdW5jaGVja2VkIE1TUiBhY2Nlc3MgZXJyb3I6IFdSTVNSIHRvIDB4ZGVh ZGJlZWYgKHRyaWVkIHRvIHdyaXRlIDB4MDAwMDAwMDAwMDAwY2FjYSkKPiBbICAgIDAuMjI0MDAw XSBNb2R1bGVzIGxpbmtlZCBpbjoKPiBbICAgIDAuMjI0MDAwXSBDUFU6IDAgUElEOiAxIENvbW06 IHN3YXBwZXIvMCBOb3QgdGFpbnRlZCA0LjUuMC1yYzcrICM3Cj4gWyAgICAwLjIyNDAwMF0gSGFy ZHdhcmUgbmFtZTogUUVNVSBTdGFuZGFyZCBQQyAoaTQ0MEZYICsgUElJWCwgMTk5NiksIEJJT1Mg MS43LjUtMjAxNDA1MzFfMDgzMDMwLWdhbmRhbGYgMDQvMDEvMjAxNAo+IFsgICAgMC4yMjQwMDBd ICAwMDAwMDAwMDAwMDAwMDAwIGZmZmY4ODAwN2MwZDdjMDggZmZmZmZmZmY4MTJmMTNhMyBmZmZm ODgwMDdjMGQ3YzUwCj4gWyAgICAwLjIyNDAwMF0gIGZmZmZmZmZmODFhNDBmZmUgZmZmZjg4MDA3 YzBkN2M0MCBmZmZmZmZmZjgxMDVjM2IxIGZmZmZmZmZmODE3MTc3MTAKPiBbICAgIDAuMjI0MDAw XSAgZmZmZjg4MDA3YzBkN2QxOCAwMDAwMDAwMDAwMDAwMDAwIGZmZmZmZmZmODE2MjA3ZDAgMDAw MDAwMDAwMDAwMDAwMAo+IFsgICAgMC4yMjQwMDBdIENhbGwgVHJhY2U6Cj4gWyAgICAwLjIyNDAw MF0gIFs8ZmZmZmZmZmY4MTJmMTNhMz5dIGR1bXBfc3RhY2srMHg2Ny8weDk0Cj4gWyAgICAwLjIy NDAwMF0gIFs8ZmZmZmZmZmY4MTA1YzNiMT5dIHdhcm5fc2xvd3BhdGhfY29tbW9uKzB4OTEvMHhk MAo+IFsgICAgMC4yMjQwMDBdICBbPGZmZmZmZmZmODE2MjA3ZDA+XSA/IGFtZF9jcHVfbm90aWZ5 KzB4NDAvMHg0MAo+IFsgICAgMC4yMjQwMDBdICBbPGZmZmZmZmZmODEwNWM0M2M+XSB3YXJuX3Ns b3dwYXRoX2ZtdCsweDRjLzB4NTAKPiBbICAgIDAuMjI0MDAwXSAgWzxmZmZmZmZmZjgxNjIwN2Qw Pl0gPyBhbWRfY3B1X25vdGlmeSsweDQwLzB4NDAKPiBbICAgIDAuMjI0MDAwXSAgWzxmZmZmZmZm ZjgxMzFkZTUzPl0gPyBfX3RoaXNfY3B1X3ByZWVtcHRfY2hlY2srMHgxMy8weDIwCj4gWyAgICAw LjIyNDAwMF0gIFs8ZmZmZmZmZmY4MTA0ZWZlMz5dIGV4X2hhbmRsZXJfd3Jtc3JfdW5zYWZlKzB4 NzMvMHg4MAo+Cj4gYW5kIGl0IGxvb2tzIGhlbHBmdWwgYW5kIGFsbCBidXQgd2hlbiB5b3UgZG8g aXQgcHJldHR5IGVhcmx5IC0gZm9yCj4gZXhhbXBsZSBJIGFkZGVkIGEKPgo+ICAgICAgICAgIHdy bXNybCgweGRlYWRiZWVmLCAweGNhZmUpOwo+Cj4gYXQgdGhlIGVuZCBvZiBwYXRfYnNwX2luaXQo KSBhbmQgdGhlIG1hY2hpbmUgZXhwbG9kZXMgd2l0aCBhbiBlYXJseQo+IHBhbmljLiBJJ20gd29u ZGVyaW5nIHdoYXQgaXMgYmV0dGVyIC0gZWFybHkgcGFuaWMgb3IgYW4gZWFybHkgI0dQIGZyb20g YQo+IG1pc3NpbmcgTVNSLgoKWW91J3JlIGhpdHRpbmc6CgogICAgLyogc3BlY2lhbCBoYW5kbGlu ZyBub3Qgc3VwcG9ydGVkIGR1cmluZyBlYXJseSBib290ICovCiAgICBpZiAoaGFuZGxlciAhPSBl eF9oYW5kbGVyX2RlZmF1bHQpCiAgICAgICAgcmV0dXJuIDA7CgoKd2hpY2ggbWVhbnMgdGhhdCB0 aGUgYmVoYXZpb3Igd2l0aCBhbmQgd2l0aG91dCBteSBzZXJpZXMgYXBwbGllZCBpcwppZGVudGlj YWwsIGZvciBiZXR0ZXIgb3IgZm9yIHdvcnNlLgoKPgo+IEFuZCBtb3JlIHNwZWNpZmljYWxseSwg Y2FuIHdlIGRvIGJldHRlciB0byBoYW5kbGUgdGhlIGVhcmx5IGNhc2UKPiBncmFjZWZ1bGx5IHRv bz8KCldlIGNvdWxkIHByb2JhYmx5IHJlbW92ZSB0aGF0IGNoZWNrIGFuZCBsZXQgY3VzdG9tIGZp eHVwcyBydW4gZWFybHkuCkkgZG9uJ3Qgc2VlIGFueSBjb21wZWxsaW5nIHJlYXNvbiB0byBrZWVw IHRoZW0gZGlzYWJsZWQuICBUaGF0IHNob3VsZApwcm9iYWJseSBiZSBhIHNlcGFyYXRlIGNoYW5n ZSwgdGhvdWdoLgoKLS1BbmR5CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3Jn Cmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=