From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 945F4C43460 for ; Tue, 11 May 2021 16:49:42 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39BDC61432 for ; Tue, 11 May 2021 16:49:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39BDC61432 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.125838.236875 (Exim 4.92) (envelope-from ) id 1lgVZf-0003uT-0V; Tue, 11 May 2021 16:49:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 125838.236875; Tue, 11 May 2021 16:49:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lgVZe-0003uM-TR; Tue, 11 May 2021 16:49:34 +0000 Received: by outflank-mailman (input) for mailman id 125838; Tue, 11 May 2021 16:49:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lgVZc-0003uC-Pz for xen-devel@lists.xenproject.org; Tue, 11 May 2021 16:49:32 +0000 Received: from mail-pl1-x629.google.com (unknown [2607:f8b0:4864:20::629]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0ad1915d-8cff-49f4-a766-d6be041b6bad; Tue, 11 May 2021 16:49:32 +0000 (UTC) Received: by mail-pl1-x629.google.com with SMTP id t4so11116120plc.6 for ; Tue, 11 May 2021 09:49:32 -0700 (PDT) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com. [209.85.210.178]) by smtp.gmail.com with ESMTPSA id x79sm14157839pfc.57.2021.05.11.09.49.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 May 2021 09:49:30 -0700 (PDT) Received: by mail-pf1-f178.google.com with SMTP id h127so16492772pfe.9 for ; Tue, 11 May 2021 09:49:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ad1915d-8cff-49f4-a766-d6be041b6bad DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I574vs+oxpmw2RaQkdeqT3TmVa8C0vE6HCQzgLmVaEk=; b=EO4zcKQD13cnMpJi5k5sqZg36m/uhjFrv+x7tUEK/JnHkDgZTOULzljGCah93D1FN5 SwmaT+lt9As201TL9V65C0BiJShCnGyDe8UgjgY5Jm1YBpkuQxrN8+e9OJjS8RpeP4ih 4tasAkIoShr42ndvrMVih2QtviIwqYbb0WQHQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I574vs+oxpmw2RaQkdeqT3TmVa8C0vE6HCQzgLmVaEk=; b=iii7wuCT3ZKQpkHdp4/6kEwB/wtf6+jyIune2L3kUAzHi3VwGE+H/z6eIs9KG63JyI nQGKwUKfWWH0E21nOUEbYu/76X59hUhP9zTo8B/sgbN3xEjm4ZePz3EUdqaH+yGKjDc4 +hEror5q+ZC8gKI2cpMr9uv43cjJKOE8OOpYumhAoKbOn8J46QSVzlhknpiFIIviHHs0 1Qaoaz8hS7GlMgRe6HjWJmM+qLpegmgDKA7hsqxuwAfnQfZjrBQoKiSfsSBtyug+mfSQ n+VykFN+oS81iackGuQfELn4w3S41EPPDpivWoDDYM/wxiy1jUb7ex02X6GZmywQvxE9 GjIw== X-Gm-Message-State: AOAM532wXhY9uSMFSeIcFr2Zb7e+D436d4SNilKbZ6xNV8ct1uEhRKMR LKVZLCUZWjlWDHCrzWT5z3NQIvQxwiVhZg== X-Google-Smtp-Source: ABdhPJxrq5k00V/RrBKmsXNm082mXlCv+Nhe0rWGHJ6nPslNifdFpP8hZewMIx2MUkFHrWSPY5KPdQ== X-Received: by 2002:a17:902:9f88:b029:ee:b4e5:64d4 with SMTP id g8-20020a1709029f88b02900eeb4e564d4mr30389356plq.41.1620751771058; Tue, 11 May 2021 09:49:31 -0700 (PDT) X-Received: by 2002:a92:6804:: with SMTP id d4mr27241366ilc.5.1620751346868; Tue, 11 May 2021 09:42:26 -0700 (PDT) MIME-Version: 1.0 References: <20210510095026.3477496-1-tientzu@chromium.org> <20210510095026.3477496-9-tientzu@chromium.org> <20210510150516.GE28066@lst.de> In-Reply-To: <20210510150516.GE28066@lst.de> From: Claire Chang Date: Wed, 12 May 2021 00:42:15 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 08/15] swiotlb: Bounce data from/to restricted DMA pool if available To: Christoph Hellwig Cc: Rob Herring , mpe@ellerman.id.au, Joerg Roedel , Will Deacon , Frank Rowand , Konrad Rzeszutek Wilk , boris.ostrovsky@oracle.com, jgross@suse.com, Marek Szyprowski , benh@kernel.crashing.org, paulus@samba.org, "list@263.net:IOMMU DRIVERS" , sstabellini@kernel.org, Robin Murphy , grant.likely@arm.com, xypron.glpk@gmx.de, Thierry Reding , mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org, Greg KH , Saravana Kannan , "Rafael J . Wysocki" , heikki.krogerus@linux.intel.com, Andy Shevchenko , Randy Dunlap , Dan Williams , Bartosz Golaszewski , linux-devicetree , lkml , linuxppc-dev@lists.ozlabs.org, xen-devel@lists.xenproject.org, Nicolas Boichat , Jim Quinlan , Tomasz Figa , bskeggs@redhat.com, Bjorn Helgaas , chris@chris-wilson.co.uk, Daniel Vetter , airlied@linux.ie, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com, Jianxiong Gao , joonas.lahtinen@linux.intel.com, linux-pci@vger.kernel.org, maarten.lankhorst@linux.intel.com, matthew.auld@intel.com, nouveau@lists.freedesktop.org, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com Content-Type: text/plain; charset="UTF-8" On Mon, May 10, 2021 at 11:05 PM Christoph Hellwig wrote: > > > +static inline bool is_dev_swiotlb_force(struct device *dev) > > +{ > > +#ifdef CONFIG_DMA_RESTRICTED_POOL > > + if (dev->dma_io_tlb_mem) > > + return true; > > +#endif /* CONFIG_DMA_RESTRICTED_POOL */ > > + return false; > > +} > > + > > > /* If SWIOTLB is active, use its maximum mapping size */ > > if (is_swiotlb_active(dev) && > > - (dma_addressing_limited(dev) || swiotlb_force == SWIOTLB_FORCE)) > > + (dma_addressing_limited(dev) || swiotlb_force == SWIOTLB_FORCE || > > + is_dev_swiotlb_force(dev))) > > This is a mess. I think the right way is to have an always_bounce flag > in the io_tlb_mem structure instead. Then the global swiotlb_force can > go away and be replace with this and the fact that having no > io_tlb_mem structure at all means forced no buffering (after a little > refactoring). Will do in the next version.