From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vijay Kilari <vijay.kilari@gmail.com>
Subject: Re: [PATCH v5 15/22] xen/arm: ITS: implement
 hw_irq_controller for LPIs
Date: Thu, 6 Aug 2015 13:45:13 +0530
Message-ID: <CALicx6tSAgLQZ_G0mT6anKmKbmR8gqd=pQkCpeOk4HkyJNaueg@mail.gmail.com>
References: <1437995524-19772-1-git-send-email-vijay.kilari@gmail.com>
	<1437995524-19772-16-git-send-email-vijay.kilari@gmail.com>
	<55C0C1E8.10407@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55C0C1E8.10407@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Prasun Kapoor <Prasun.Kapoor@caviumnetworks.com>, manish.jaggi@caviumnetworks.com, Tim Deegan <tim@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, Aug 4, 2015 at 7:15 PM, Julien Grall <julien.grall@citrix.com> wrote:
> Hi Vijay,
>
> On 27/07/15 12:11, vijay.kilari@gmail.com wrote:
>> +
>> +static const hw_irq_controller its_host_lpi_type = {
>> +    .typename     = "gic-its",
>> +    .startup      = its_irq_startup,
>> +    .shutdown     = its_irq_shutdown,
>> +    .enable       = its_irq_enable,
>> +    .disable      = its_irq_disable,
>> +    .ack          = its_irq_ack,
>> +    .end          = gicv3_host_irq_end,
>> +    .set_affinity = its_irq_set_affinity,
>> +};
>> +
>> +static const hw_irq_controller its_guest_lpi_type = {
>> +    .typename     = "gic-its",
>> +    .startup      = its_irq_startup,
>> +    .shutdown     = its_irq_shutdown,
>> +    .enable       = its_irq_enable,
>> +    .disable      = its_irq_disable,
>> +    .ack          = its_irq_ack,
>> +    .end          = gicv3_guest_irq_end,
>> +    .set_affinity = its_irq_set_affinity,
>> +};
>> +
>> +hw_irq_controller *its_get_host_lpi_type(void)
>> +{
>> +    return &its_host_lpi_type;
>> +}
>> +
>> +hw_irq_controller *its_get_guest_lpi_type(void)
>> +{
>> +    return &its_guest_lpi_type;
>> +}
>> +
>
> Please directly export the variables.

These API's are called to assign hw_irq_handler to LPI
by generic code

>
>>  /*
>>   * How we allocate LPIs:
>>   *
> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
>> index 98d45bc..58e878e 100644
>> --- a/xen/arch/arm/gic-v3.c
>> +++ b/xen/arch/arm/gic-v3.c
>> @@ -40,6 +40,7 @@
>>  #include <asm/device.h>
>>  #include <asm/gic.h>
>>  #include <asm/gic_v3_defs.h>
>> +#include <asm/gic-its.h>
>>  #include <asm/cpufeature.h>
>>
>>  /* Global state */
>> @@ -1033,15 +1034,19 @@ static void gicv3_irq_ack(struct irq_desc *desc)
>>      /* No ACK -- reading IAR has done this for us */
>>  }
>>
>> -static void gicv3_host_irq_end(struct irq_desc *desc)
>> +void gicv3_host_irq_end(struct irq_desc *desc)
>>  {
>>      /* Lower the priority */
>>      gicv3_eoi_irq(desc);
>> -    /* Deactivate */
>> -    gicv3_dir_irq(desc);
>> +    /*
>> +     * LPIs does not have active state. Do do not deactivate,
>> +     *  when EOI mode is set to 1.
>> +     */
>> +    if ( !gic_is_lpi(desc->irq) )
>> +        gicv3_dir_irq(desc);
>
> I already told you that the goal of the hw_irq_controller is to avoid
> checking the interrupt for every callback.
>
> If the current function doesn't work for you, introduce a new one. But
> don't put an if inside.

This is what I have done in patch v4

http://lists.xen.org/archives/html/xen-devel/2015-07/msg02128.html

But Ian suggested to export gicv3_host_irq_end instead of calling
gicv3_eoi_irq()

Regards
Vijay