Re: [PATCH 00/11] Return failure on failure for more xl commands

From: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: George.Dunlap@eu.citrix.com, xen-devel@lists.xenproject.org,
	"Dario Faggioli" <dario.faggioli@citrix.com>,
	"Ian Campbell" <ian.campbell@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 00/11] Return failure on failure for more xl commands
Date: Wed, 30 Mar 2016 19:19:41 +0200	[thread overview]
Message-ID: <CAMQpU2qBAovbY6Sd-7K9gsa7eJeVGObWUEodgB6A1aQWiHzUaQ@mail.gmail.com> (raw)
In-Reply-To: <20160330151420.GI5656@citrix.com>

Yes, I was looking at wrong branch, I am sorry. The patches

* {01-04,08,11} were not attached in the previous patch [0].

* {05,06} are applied in the version made by George Dunlap.
  I added the changes to return 0/1 in internal functions
  and EXIT_{SUCCESS/FAILURE} according to [2]. It certainly should be
  resend.

* 07 was attached in the previous patch but is not applied in staging.
  It relates pci-* functions. I modified it as in the point higher.

* 09 is applied.

* 10 is not applied, I did not modified it. It brings coding style improvements.

Summing up the new changes
* 01-03 are the patches related to libxl_pci, the functions return error code
  instead of always 0
* 04 modifies freemem from xl_cmdimpl to follow the pattern to return 0/1 for
  not main functions
* 08 is a change to return error codes for main_tmem* related functions
* 11 is a change with improvement of coding style, change 'rc -> r'

Paulina

On 30 March 2016 at 17:14, Wei Liu <wei.liu2@citrix.com> wrote:
> On Wed, Mar 30, 2016 at 05:02:39PM +0200, Paulina Szubarczyk wrote:
>> This patch includes the changes from a patch prepared by George Dunlap
>> [0] and expands them to more xl commands.
>>
>
> Hello,
>
> Did you perhaps make a mistake? As far as I can tell some patches were
> already applied. Don't worry, we all make mistakes from time to time.
>
> I realise you might be looking at master branch. Please check staging
> branch to see if you should drop some of the already patches.
>
> And perhaps can you indicate which patches should we look at in case you
> don't want to resend just yet.
>
> Wei.
>
>> This is my bite-sized outreachy project [1][2].
>>
>> Return failure when the command failed for more xl commands:
>> - mem-set
>> - cd-insert
>> - pci-*
>> -- freemem
>> -- tmem-*
>>
>> This makes xl more useful for scripting.
>>
>> In the case of mem-set, it means first cleaning up
>> libxl_set_memory_target() to return useful error codes.
>>
>> For pci-* functions libxl__create_pci_backend(), libxl__device_pci_destroy_all()
>> return error codes instead of always 0.
>>
>> Changes:
>> - Remove block-attach patch
>> - Split out removal of spurious getinfolist to a separate patch
>> - Try to follow CODING_STYLE more closely:
>>  - In general, don't initialize rc / r, but use set-and-goto
>>  - Use 'r' for non-libxl error codes
>>  - Use EXIT_FAILURE and EXIT_SUCCESS rather than magic constants in main_foo()
>>  - Use 1 and 0 in internal functions of xl
>>
>> [0] http://lists.xenproject.org/archives/html/xen-devel/2015-12/msg02246.html
>> [1] http://lists.xenproject.org/archives/html/xen-devel/2016-03/msg03031.html
>> [2] https://www.mail-archive.com/xen-devel@lists.xen.org/msg62055.html
>>
>> CC:   Wei Liu <wei.liu2@citrix.com>
>> CC:   Ian Jackson <ian.jackson@eu.citrix.com>
>> CC: Dario Faggioli <dario.faggioli@citrix.com>
>> CC: Ian Campbell <ian.campbell@citrix.com>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel