Re: [Xen-devel] [BUG] After upgrade to Xen 4.12.0 iommu=no-igfx

[Roman Shaposhnik <roman@zededa.com>]

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

Hi Roger!

I applied your patch, removed no-igfx and I still see the original
problem. Please let me know what other logs/debugs would you need at
this point.

Btw, just to make it clear what patch got applied I'm attaching it to
this email.

Oh, and it seems that that https://downloads.xenproject.org/ SSL
certificate expired yesterday -- perhaps somebody can take a look at
that.

Thanks,
Roman.

On Mon, Jul 22, 2019 at 4:47 PM Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>
> On 23/07/2019 00:36, Roman Shaposhnik wrote:
> > Hi Everyone!
> >
> > Thanks a million for an extremely quick turnaround. I am in my lab
> > again next to the box in question.
> >
> > Should I go ahead and test the latest patch or wait for the official
> > one to be submitted?
> >
> > Thanks,
> > Roman.
>
> Use this patch to test with.  Roger forgot to CC you on the official
> one, but the code changes are identical.
>
> ~Andrew

[-- Attachment #2: 01-iommu-mappings.patch --]
[-- Type: application/octet-stream, Size: 1266 bytes --]

diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c
index fef97c82f6..88a2430c8c 100644
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -836,7 +836,7 @@ guest_physmap_add_page(struct domain *d, gfn_t gfn, mfn_t 
mfn,
          */
         for ( i = 0; i < (1UL << page_order); ++i, ++page )
         {
-            if ( !need_iommu_pt_sync(d) )
+            if ( !has_iommu_pt(d) )
                 /* nothing */;
             else if ( get_page_and_type(page, d, PGT_writable_page) )
                 put_page_and_type(page);
@@ -1341,7 +1341,7 @@ int set_identity_p2m_entry(struct domain *d, unsigned 
long gfn_l,
 
     if ( !paging_mode_translate(p2m->domain) )
     {
-        if ( !need_iommu_pt_sync(d) )
+        if ( !has_iommu_pt(d) )
             return 0;
         return iommu_legacy_map(d, _dfn(gfn_l), _mfn(gfn_l), PAGE_ORDER_4K,
                                 IOMMUF_readable | IOMMUF_writable);
@@ -1432,7 +1432,7 @@ int clear_identity_p2m_entry(struct domain *d, unsigned 
long gfn_l)
 
     if ( !paging_mode_translate(d) )
     {
-        if ( !need_iommu_pt_sync(d) )
+        if ( !has_iommu_pt(d) )
             return 0;
         return iommu_legacy_unmap(d, _dfn(gfn_l), PAGE_ORDER_4K);
     }
-- 
2.20.1 (Apple Git-117)

[-- Attachment #3: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel