xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] xen/arm: gic-v2: Only create GICv2m node when there are GICv2m frame available
@ 2016-06-15 13:40 Julien Grall
  2016-06-16  1:54 ` Wei Chen
  0 siblings, 1 reply; 2+ messages in thread
From: Julien Grall @ 2016-06-15 13:40 UTC (permalink / raw)
  To: xen-devel; +Cc: Julien Grall, sstabellini, steve.capper, wei.chen

Xen will crash on platform where GICv2m is not available with the
following error:

(XEN) Can't find ranges property for the gic node
(XEN) Device tree generation failed (-15).
(XEN)
(XEN) ****************************************
(XEN) Panic on CPU 0:
(XEN) Could not set up DOM0 guest OS
(XEN) ****************************************

This is because the property "ranges" may not be present in the GIC
when there are no GICv2m frames.

Skip the creation of the GICv2m node when the hardware does not
support it.

This fixes boot after commit "xen/arm: Export GICv2m register frames to
DOM0 by device tree".

Signed-off-by: Julien Grall <julien.grall@arm.com>
---
 xen/arch/arm/gic-v2.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c
index 2c1c0ba..4e2f4c7 100644
--- a/xen/arch/arm/gic-v2.c
+++ b/xen/arch/arm/gic-v2.c
@@ -669,6 +669,10 @@ static int gicv2m_make_dt_node(const struct domain *d,
     const struct dt_device_node *v2m = NULL;
     const struct v2m_data *v2m_data;
 
+    /* It is not necessary to create the node if there are not GICv2m frames */
+    if ( list_empty(&gicv2m_info) )
+        return 0;
+
     /* The sub-nodes require the ranges property */
     prop = dt_get_property(gic, "ranges", &len);
     if ( !prop )
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] xen/arm: gic-v2: Only create GICv2m node when there are GICv2m frame available
  2016-06-15 13:40 [PATCH] xen/arm: gic-v2: Only create GICv2m node when there are GICv2m frame available Julien Grall
@ 2016-06-16  1:54 ` Wei Chen
  0 siblings, 0 replies; 2+ messages in thread
From: Wei Chen @ 2016-06-16  1:54 UTC (permalink / raw)
  To: Julien Grall; +Cc: Stefano Stabellini, steve.capper, xen-devel

On 15 June 2016 at 21:40, Julien Grall <julien.grall@arm.com> wrote:
> Xen will crash on platform where GICv2m is not available with the
> following error:
>
> (XEN) Can't find ranges property for the gic node
> (XEN) Device tree generation failed (-15).
> (XEN)
> (XEN) ****************************************
> (XEN) Panic on CPU 0:
> (XEN) Could not set up DOM0 guest OS
> (XEN) ****************************************
>
> This is because the property "ranges" may not be present in the GIC
> when there are no GICv2m frames.
>
> Skip the creation of the GICv2m node when the hardware does not
> support it.
>
> This fixes boot after commit "xen/arm: Export GICv2m register frames to
> DOM0 by device tree".
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> ---
>  xen/arch/arm/gic-v2.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c
> index 2c1c0ba..4e2f4c7 100644
> --- a/xen/arch/arm/gic-v2.c
> +++ b/xen/arch/arm/gic-v2.c
> @@ -669,6 +669,10 @@ static int gicv2m_make_dt_node(const struct domain *d,
>      const struct dt_device_node *v2m = NULL;
>      const struct v2m_data *v2m_data;
>
> +    /* It is not necessary to create the node if there are not GICv2m frames */
> +    if ( list_empty(&gicv2m_info) )
> +        return 0;
> +
>      /* The sub-nodes require the ranges property */
>      prop = dt_get_property(gic, "ranges", &len);
>      if ( !prop )
> --
> 1.9.1
>

Looks fine to me.

Acked-by: Wei Chen <wei.chen@linaro.org>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-16  1:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-15 13:40 [PATCH] xen/arm: gic-v2: Only create GICv2m node when there are GICv2m frame available Julien Grall
2016-06-16  1:54 ` Wei Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).