From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MIME_QP_LONG_LINE,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, URI_NOVOWEL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75068C433ED for ; Sat, 8 May 2021 18:38:18 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 148E16113E for ; Sat, 8 May 2021 18:38:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 148E16113E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.124415.234719 (Exim 4.92) (envelope-from ) id 1lfRpv-0004Vn-KM; Sat, 08 May 2021 18:37:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 124415.234719; Sat, 08 May 2021 18:37:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lfRpv-0004Vg-HJ; Sat, 08 May 2021 18:37:59 +0000 Received: by outflank-mailman (input) for mailman id 124415; Sat, 08 May 2021 18:37:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lfRpt-0004VZ-Tu for xen-devel@lists.xenproject.org; Sat, 08 May 2021 18:37:57 +0000 Received: from mail-qk1-x72a.google.com (unknown [2607:f8b0:4864:20::72a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 79f3ee9b-e0eb-4831-a470-1a29debc4a2f; Sat, 08 May 2021 18:37:56 +0000 (UTC) Received: by mail-qk1-x72a.google.com with SMTP id k127so11803211qkc.6 for ; Sat, 08 May 2021 11:37:56 -0700 (PDT) Received: from smtpclient.apple ([199.33.71.18]) by smtp.gmail.com with ESMTPSA id 28sm2619888qkr.36.2021.05.08.11.37.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 May 2021 11:37:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79f3ee9b-e0eb-4831-a470-1a29debc4a2f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=content-transfer-encoding:from:mime-version:subject:message-id:date :cc:to; bh=GYEZwNqgXbl+DgKBwxyaj9ItIrgeS+e3z48vLMFgvdU=; b=kHjRvNPn61k8yLJgxnkBOjZenTSr7RToDiCO3CJssOxRZMXG5Eec0W0oZFCoWiZrLW Il6M3rf3JlPs7sVlPvQ3SdtMs4nCGS7sXjvvPu8B8gmi+9NjI/HMz0c/up0p7vUHxuMF iY1p08hEPHJ3z2J07WM11ayvNBB1xTKX8KrvpW5WLLh+3py6f+O9NLjKurBsvdApzlm5 m9ikqSksGRdhCnkFfH5TfWuQ5tejSQmTr4e0sOr5LxbI/a70vsGwrucL7cr0rN3YpwVQ mvn5fJ7Naa/NrGvLibvurqEIfKHNvoGfbYlDZHWksj5xvQkTaxBzJF8HyiTWRhxFrnnu ko9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:message-id:date:cc:to; bh=GYEZwNqgXbl+DgKBwxyaj9ItIrgeS+e3z48vLMFgvdU=; b=UWk0+U7sOrxEDJkUtLhrskHg+lYetH22KKVEVsx/O+nZGLNnCgVVtSKzbYcxa7cSrx +c2x2S28qT+o88AM8f0EhcptVFN4tsFW1wRaR0URk+jZLmiW28LWF11i0Yr6WnQ1vPLw Yj6l6Bw+RHOVwXOqmd5/pFxUmOQTcnxyjbspu/cK5jwRf5qZsmqPGCbJx5I3By3uDdb5 DtDrv5SplnI6UqHxLYM++5rrQndKZmmCal+zHSLITKvDsrH4rwPDkFOx7gNmDvF8dIG+ JmiECQDwyoKAtO5hrzQjS+FNSM5ju6CcT6nZDHXWDsugm2W5PeNE7srCLUI6XWPRknYg fXcg== X-Gm-Message-State: AOAM5311NflEkhC3UfP8C18UwDUDMUCWhwXa357WNSi3+FKC4CNzl25O mJx9UEaEtt7NDaklpWMSKXw= X-Google-Smtp-Source: ABdhPJz70fBlJjDntjBTpu84IHM0i0r1Y47aQcVYf+xCRIVz8sH18nVZq8KdEajkgtGAuNOjZqffFw== X-Received: by 2002:a37:5dc5:: with SMTP id r188mr16107436qkb.303.1620499076613; Sat, 08 May 2021 11:37:56 -0700 (PDT) Content-Type: multipart/alternative; boundary=Apple-Mail-5BB23005-C8D5-4CD0-A64D-8522016ADBF6 Content-Transfer-Encoding: 7bit From: Rich Persaud Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v2 01/13] docs: Warn about incomplete vtpmmgr TPM 2.0 support Message-Id: Date: Sat, 8 May 2021 14:37:55 -0400 Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu , Andrew Cooper To: Jason Andryuk X-Mailer: iPad Mail (18E212) --Apple-Mail-5BB23005-C8D5-4CD0-A64D-8522016ADBF6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On May 6, 2021, at 10:00, Jason Andryuk wrote: > =EF=BB=BFThe vtpmmgr TPM 2.0 support is incomplete. Add a warning about t= hat to > the documentation so others don't have to work through discovering it is > broken. >=20 > Signed-off-by: Jason Andryuk > Acked-by: Andrew Cooper > --- > docs/man/xen-vtpmmgr.7.pod | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/docs/man/xen-vtpmmgr.7.pod b/docs/man/xen-vtpmmgr.7.pod > index af825a7ffe..875dcce508 100644 > --- a/docs/man/xen-vtpmmgr.7.pod > +++ b/docs/man/xen-vtpmmgr.7.pod > @@ -222,6 +222,17 @@ XSM label, not the kernel. >=20 > =3Dhead1 Appendix B: vtpmmgr on TPM 2.0 >=20 > +=3Dhead2 WARNING: Incomplete - cannot persist data > + > +TPM 2.0 support for vTPM manager is incomplete. There is no support for > +persisting an encryption key, so vTPM manager regenerates primary and sec= ondary > +key handles each boot. > + > +Also, the vTPM manger group command implementation hardcodes TPM 1.2 comm= ands. > +This means running manage-vtpmmgr.pl fails when the TPM 2.0 hardware reje= cts > +the TPM 1.2 commands. vTPM manager with TPM 2.0 cannot create groups and= > +therefore cannot persist vTPM contents. > + > =3Dhead2 Manager disk image setup: >=20 > The vTPM Manager requires a disk image to store its encrypted data. The im= age > --=20 > 2.30.2 Should SUPPORT.md also be updated? https://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dblob;f=3DSUPPORT.md;hb=3Dref= s/heads/master Rich= --Apple-Mail-5BB23005-C8D5-4CD0-A64D-8522016ADBF6 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On May 6, 2021, at 10:00, J= ason Andryuk <jandryuk@gmail.com> wrote:

=EF=BB=BFThe vtpmmgr TPM 2.0 support is incomplete.  Add a war= ning about that to
the documentation so others don't have to= work through discovering it is
broken.

Signed-off-by: Jason Andryuk <jandryuk@gmail.com><= br>Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>---
docs/man/xen-vtpmmgr.7.pod | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/docs/man/xen-vtpmmgr.7.pod b/docs/man/xen-vtpmmgr.7.pod
index af825a7ffe..875dcce508 100644
--- a/docs/m= an/xen-vtpmmgr.7.pod
+++ b/docs/man/xen-vtpmmgr.7.pod=
@@ -222,6 +222,17 @@ XSM label, not the kernel.

=3Dhead1 Appendix B: vtpmmgr on TPM 2.0

+=3Dhead2 WARNING: Incomplete - cannot persist data
<= span>+
+TPM 2.0 support for vTPM manager is incomplete. &nbs= p;There is no support for
+persisting an encryption key, so v= TPM manager regenerates primary and secondary
+key handles e= ach boot.
+
+Also, the vTPM manger group com= mand implementation hardcodes TPM 1.2 commands.
+This means r= unning manage-vtpmmgr.pl fails when the TPM 2.0 hardware rejects
<= span>+the TPM 1.2 commands.  vTPM manager with TPM 2.0 cannot create gr= oups and
+therefore cannot persist vTPM contents.
= +
=3Dhead2 Manager disk image setup:
=
The vTPM Manager requires a disk image to store its encryp= ted data. The image
--
2.30.2

Should SUPPORT.md also be updated?
= --Apple-Mail-5BB23005-C8D5-4CD0-A64D-8522016ADBF6--