Re: [PATCH v4 03/15] VMX: implement suppress #VE.

From: "Sahita, Ravi" <ravi.sahita@intel.com>
To: Jan Beulich <JBeulich@suse.com>,
	"White, Edmund H" <edmund.h.white@intel.com>
Cc: Tim Deegan <tim@xen.org>, Wei Liu <wei.liu2@citrix.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	"tlengyel@novetta.com" <tlengyel@novetta.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v4 03/15] VMX: implement suppress #VE.
Date: Fri, 10 Jul 2015 19:22:27 +0000	[thread overview]
Message-ID: <DBC12B0F5509554280826E40BCDEE8BE54FD2584@ORSMSX104.amr.corp.intel.com> (raw)
In-Reply-To: <559FA7EB020000780008F4BD@mail.emea.novell.com>

>From: Jan Beulich [mailto:JBeulich@suse.com]
>Sent: Friday, July 10, 2015 2:10 AM
>
>>>> On 10.07.15 at 02:52, <edmund.h.white@intel.com> wrote:
>> @@ -1134,6 +1151,13 @@ int ept_p2m_init(struct p2m_domain *p2m)
>>          p2m->flush_hardware_cached_dirty = ept_flush_pml_buffers;
>>      }
>>
>> +    table =
>> + map_domain_page(pagetable_get_pfn(p2m_get_pagetable(p2m)));
>> +
>> +    for ( i = 0; i < EPT_PAGETABLE_ENTRIES; i++ )
>> +        table[i].suppress_ve = 1;
>> +
>> +    unmap_domain_page(table);
>
>See my comments/questions on v3. I find it irritating for new patch versions to
>be sent without addressing comments on the previous one (verbally or by
>adjusting code).
>
>Jan

Apologies - We did go through all your comments on v3 for the patches affected - I will respond to them on those threads next.
We posted v4 since we felt we had addressed the major code changes on 2 of the patches that were needed based on feedback so we wanted to post that before the deadline.

Ravi