From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sahita, Ravi" Subject: Re: [PATCH v7 05/15] x86/altp2m: basic data structures and support routines. Date: Thu, 23 Jul 2015 15:00:06 +0000 Message-ID: References: <1437606081-6964-1-git-send-email-edmund.h.white@intel.com> <1437606081-6964-6-git-send-email-edmund.h.white@intel.com> <55B0CE6702000078000946B5@prv-mh.provo.novell.com> <55B11C260200007800094B16@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55B11C260200007800094B16@prv-mh.provo.novell.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Tim Deegan , "Sahita, Ravi" , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , "White, Edmund H" , "xen-devel@lists.xen.org" , "Nakajima, Jun" , "tlengyel@novetta.com" , Daniel De Graaf List-Id: xen-devel@lists.xenproject.org >From: Jan Beulich [mailto:JBeulich@suse.com] >Sent: Thursday, July 23, 2015 7:54 AM > >>>> On 23.07.15 at 16:36, wrote: >>> From: Jan Beulich [mailto:JBeulich@suse.com] >>>Sent: Thursday, July 23, 2015 2:22 AM >>>>>> On 23.07.15 at 01:01, wrote: >>>> +out: >>> >> >> Missed sorry. >> >> >>>Just to repeat - labels should be indented by at least one space. > >But you realize this isn't the only case, and it looked like you adjusted only >exactly the one place where the comment was made? > I agree these kinds of things are hard to catch - we did go in and scan our v7 for comment styles, indentation, case indentation, spaces in if conditional expressions etc, But of course we missed some and this could be addressed - Andrew was also suggesting some sort of tool to do this would be good to use. thanks Ravi >Jan