Re: [PATCH v7 13/15] x86/altp2m: XSM hooks for altp2m HVM ops

From: "Sahita, Ravi" <ravi.sahita@intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>, "Sahita, Ravi" <ravi.sahita@intel.com>,
	Wei Liu <wei.liu2@citrix.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	"White, Edmund H" <edmund.h.white@intel.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	"Nakajima, Jun" <jun.nakajima@intel.com>,
	"tlengyel@novetta.com" <tlengyel@novetta.com>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH v7 13/15] x86/altp2m: XSM hooks for altp2m HVM ops
Date: Thu, 23 Jul 2015 16:56:19 +0000	[thread overview]
Message-ID: <DBC12B0F5509554280826E40BCDEE8BE54FE8624@ORSMSX104.amr.corp.intel.com> (raw)
In-Reply-To: <55B12DB90200007800094C70@prv-mh.provo.novell.com>

>From: Jan Beulich [mailto:JBeulich@suse.com]
>Sent: Thursday, July 23, 2015 9:09 AM
>
>>>> On 23.07.15 at 01:01, <edmund.h.white@intel.com> wrote:
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -6005,6 +6005,9 @@ static int hvmop_set_param(
>>                  nestedhvm_vcpu_destroy(v);
>>          break;
>>      case HVM_PARAM_ALTP2M:
>> +        rc = xsm_hvm_param_altp2mhvm(XSM_PRIV, d);
>> +        if ( rc )
>> +            break;
>>          if ( a.value > 1 )
>>              rc = -EINVAL;
>>          if ( a.value &&
>> @@ -6189,6 +6192,9 @@ static int do_altp2m_op(
>>          goto out;
>>      }
>>
>> +    if ( (rc = xsm_hvm_altp2mhvm_op(XSM_TARGET, d ? d : current-
>>domain)) )
>> +        goto out;
>> +
>
>Shouldn't this have got updated after the changes to patch 11?

It was updated - a number of similar calls to check xsm permissions for this op were collapsed due to the sub-op'ing.
We don't differentiate across sub-ops for altp2m w.r.t. XSM permissions.

Thanks,
Ravi

>
>Jan