From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Sahita, Ravi" <ravi.sahita@intel.com>
Subject: Re: Regression in guest destruction caused by altp2m
Date: Wed, 29 Jul 2015 16:41:29 +0000
Message-ID: <DBC12B0F5509554280826E40BCDEE8BE54FECE56@ORSMSX104.amr.corp.intel.com>
References: <20150727151815.GB5111@zion.uk.xensource.com>
	<20150727180939.GC5111@zion.uk.xensource.com>
	<55B6BD0C.7030107@citrix.com>
	<DBC12B0F5509554280826E40BCDEE8BE54FEB4C7@ORSMSX104.amr.corp.intel.com>
	<20150729100330.GV5111@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <ravi.sahita@intel.com>) id 1ZKUQ9-0005FQ-6M
	for xen-devel@lists.xenproject.org; Wed, 29 Jul 2015 16:41:33 +0000
In-Reply-To: <20150729100330.GV5111@zion.uk.xensource.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, "tim@xen.org" <tim@xen.org>, "White, Edmund H" <edmund.h.white@intel.com>, Jan Beulich <JBeulich@suse.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

>From: Wei Liu [mailto:wei.liu2@citrix.com]
>Sent: Wednesday, July 29, 2015 3:04 AM
>
>On Mon, Jul 27, 2015 at 11:26:36PM +0000, Sahita, Ravi wrote:
>[...]
>> >> This makes me think it doesn't matter if I do "xl destroy" or just
>> >> normal shutdown. And another test to normally shutdown guest
>> >> confirmed that.
>> >>
>> >> The machine I have is quite old and doesn't support EPT. The real
>> >> issues seems to be that you failed to properly disable that feature
>> >> for old machines.
>> >
>> >The altp2m feature is designed (and implemented) to be emulated on
>> >systems lacking hardware capabilities.
>> >
>> >As such, teardown is necessary even on older systems, but I would
>> >agree that there appears to be a bug.
>>
>> Yes -
>> the check for hvm_altp2m_supported() before altp2m_vcpu_destroy() was
>missing - will send a patch tonight.
>>
>
>Hi Ravi
>
>Any update on this? This is a blocker for the release. Please fix it as
>soon as possible.
>

Just posted it - Ravi

>Wei.
>
>> Ravi
>>
>>
>> >
>> >~Andrew