From: "Xuquan (Quan Xu)" <xuquan8@huawei.com>
To: Jan Beulich <JBeulich@suse.com>, Kevin Tian <kevin.tian@intel.com>
Cc: "yang.zhang.wz@gmail.com" <yang.zhang.wz@gmail.com>,
"Hanweidong (Randy)" <hanweidong@huawei.com>,
"George.Dunlap@eu.citrix.com" <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Jiangyifei <jiangyifei@huawei.com>,
Jun Nakajima <jun.nakajima@intel.com>
Subject: Re: [PATCH v2] x86/apicv: fix RTC periodic timer and apicv issue
Date: Mon, 10 Oct 2016 09:21:17 +0000 [thread overview]
Message-ID: <E0A769A898ADB6449596C41F51EF62C6ABA135@SZXEMI506-MBX.china.huawei.com> (raw)
In-Reply-To: <57E8DEB702000078001124CE@prv-mh.provo.novell.com>
On September 26, 2016 2:39 PM, Jan Beulich < JBeulich@suse.com > wrote:
>>>> On 24.09.16 at 03:06, <xuquan8@huawei.com> wrote:
>> On September 24, 2016 7:34 AM, Tian Kevin < kevin.tian@intel.com > wrote:
>>>> From: Jan Beulich [mailto:JBeulich@suse.com]
>>>> Sent: Friday, September 23, 2016 11:34 PM
>>>>
>>>> >>> On 20.09.16 at 15:30, <xuquan8@huawei.com> wrote:
>>>> > --- a/xen/arch/x86/hvm/vlapic.c
>>>> > +++ b/xen/arch/x86/hvm/vlapic.c
>>>> > @@ -433,6 +433,12 @@ void vlapic_EOI_set(struct vlapic *vlapic)
>>>> > void vlapic_handle_EOI(struct vlapic *vlapic, u8 vector) {
>>>> > struct domain *d = vlapic_domain(vlapic);
>>>> > + struct vcpu *v = vlapic_vcpu(vlapic);
>>>> > + struct hvm_intack pt_intack;
>>>> > +
>>>> > + pt_intack.vector = vector;
>>>> > + pt_intack.source = hvm_intsrc_lapic;
>>>> > + pt_intr_post(v, pt_intack);
>>>>
>>>> This also sits on the EOI LAPIC register write path, i.e. the change
>>>> then also affects non-apicv environments.
>>>
>>>The new logic should be entered only when EOI-induced exit happens.
>>>
>>
>> Yes, more that the EOI-induced exit is conditional, specifically, the
>> bitmap is set by vmx_set_eoi_exit_bitmap().
>> Jan, what do you think? While I recall from v1 discussion, you have
>> the same comment. We can dig it deep..
>
>See my reply to Kevin sent a minute ago. As I'm not sure what Kevin means to
>state with several of his responses, I can't properly respond for now. And then
>what you say doesn't really address my concern - things being conditional
>elsewhere doesn't mean we won't get here too in the non-apicv case, at least
>not in a way that I can follow right away.
>
Jan, any idea now?
Quan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-10 9:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 13:30 [PATCH v2] x86/apicv: fix RTC periodic timer and apicv issue Xuquan (Euler)
2016-09-23 15:33 ` Jan Beulich
2016-09-23 23:34 ` Tian, Kevin
2016-09-24 1:06 ` Xuquan (Euler)
2016-09-26 6:39 ` Jan Beulich
2016-10-10 9:21 ` Xuquan (Quan Xu) [this message]
2016-10-10 9:39 ` Jan Beulich
2016-10-10 10:49 ` Xuquan (Quan Xu)
2016-10-11 7:48 ` Tian, Kevin
2016-10-11 11:12 ` Xuquan (Quan Xu)
2016-10-17 9:27 ` Xuquan (Quan Xu)
2016-10-21 8:43 ` Tian, Kevin
2016-10-24 7:02 ` Tian, Kevin
2016-10-25 8:36 ` Xuquan (Quan Xu)
2016-10-25 13:01 ` Konrad Rzeszutek Wilk
2016-10-26 8:42 ` Xuquan (Quan Xu)
2016-10-26 5:19 ` Tian, Kevin
2016-10-26 8:38 ` Xuquan (Quan Xu)
2016-10-26 9:35 ` Tian, Kevin
2016-10-26 12:02 ` Xuquan (Quan Xu)
2016-10-25 9:01 ` Xuquan (Quan Xu)
2016-09-26 6:35 ` Jan Beulich
2016-09-26 19:34 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E0A769A898ADB6449596C41F51EF62C6ABA135@SZXEMI506-MBX.china.huawei.com \
--to=xuquan8@huawei.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=hanweidong@huawei.com \
--cc=jiangyifei@huawei.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).