From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wu, Feng" <feng.wu@intel.com>
Subject: Re: [v4 15/17] arm: add a dummy arch hooks for scheduler
Date: Fri, 24 Jul 2015 00:39:40 +0000
Message-ID: <E959C4978C3B6342920538CF579893F00264612D@SHSMSX104.ccr.corp.intel.com>
References: <1437651353-5275-1-git-send-email-feng.wu@intel.com>
	<1437651353-5275-16-git-send-email-feng.wu@intel.com>
	<55B0D5DF.9080400@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55B0D5DF.9080400@citrix.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: Tim Deegan <tim@xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, "Wu, Feng" <feng.wu@intel.com>
List-Id: xen-devel@lists.xenproject.org



> -----Original Message-----
> From: Julien Grall [mailto:julien.grall@citrix.com]
> Sent: Thursday, July 23, 2015 7:54 PM
> To: Wu, Feng; xen-devel@lists.xen.org
> Cc: Stefano Stabellini; Ian Campbell; Tim Deegan
> Subject: Re: [Xen-devel] [v4 15/17] arm: add a dummy arch hooks for scheduler
> 
> Hi,
> 
> On 23/07/15 12:35, Feng Wu wrote:
> > Add a dummy arch hooks for scheduler to make the build successful
> > in ARM.
> 
> I would make more sense if you introduce the dummy hooks in the patch
> where you effectively use it (i.e #16).
> 
> Actually you also introduce arch_vcpu_wake for x86 there too.

I split it just because this is the only changes to ARM. I will make them
one patch any way.

Thanks,
Feng

> 
> > CC: Ian Campbell <ian.campbell@citrix.com>
> > CC: Stefano Stabellini <stefano.stabellini@citrix.com>
> > CC: Tim Deegan <tim@xen.org>
> > Signed-off-by: Feng Wu <feng.wu@intel.com>
> > ---
> > v4:
> > - Newly added
> >
> >  xen/include/asm-arm/domain.h | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> > index f1a087e..7f25fd5 100644
> > --- a/xen/include/asm-arm/domain.h
> > +++ b/xen/include/asm-arm/domain.h
> > @@ -265,6 +265,8 @@ static inline unsigned int domain_max_vcpus(const
> struct domain *d)
> >      return MAX_VIRT_CPUS;
> >  }
> >
> > +static void arch_vcpu_wake(struct vcpu *v) {}
> > +
> 
> Please use static inline here.
> 
> >  #endif /* __ASM_DOMAIN_H__ */
> >
> >  /*
> >
> 
> Regards,
> 
> --
> Julien Grall