xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Scott <dave@recoil.org>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
	Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH 15/17] ocaml/libxs: honour XEN_RUN_STORED
Date: Tue, 14 Jun 2016 21:06:22 +0100	[thread overview]
Message-ID: <F402258D-54E4-4B2F-A5F3-F3B07490FF01@recoil.org> (raw)
In-Reply-To: <1465804155-14469-16-git-send-email-wei.liu2@citrix.com>


> On 13 Jun 2016, at 08:49, Wei Liu <wei.liu2@citrix.com> wrote:
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: David Scot <dave@recoil.org>
> ---
> tools/ocaml/libs/xs/xs.ml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/ocaml/libs/xs/xs.ml b/tools/ocaml/libs/xs/xs.ml
> index 7e14487..db9959a 100644
> --- a/tools/ocaml/libs/xs/xs.ml
> +++ b/tools/ocaml/libs/xs/xs.ml
> @@ -147,7 +147,7 @@ let monitor_paths xsh l time callback =
> 	end;
> 	unwatch ()
> 
> -let daemon_socket = "/var/run/xenstored/socket"
> +let daemon_socket = Paths.xen_run_stored ^ "/socket"
> 
> (** Throws this rather than a miscellaneous Unix.connect failed *)
> exception Failed_to_connect
> -- 
> 2.1.4
> 

This looks fine to me

Acked-by: David Scott <dave@recoil.org>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-14 20:06 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-13  7:48 [PATCH 00/17] Honour more configure variables in various places (iteration 2) Wei Liu
2016-06-13  7:48 ` [PATCH 01/17] oxenstored: honour XEN_{LOG, RUN}_DIR in oxenstored.conf Wei Liu
2016-06-13  7:49 ` [PATCH 02/17] oxenstored: generate a paths module Wei Liu
2016-06-13  7:49 ` [PATCH 03/17] oxenstored: honour XEN_LOG_DIR defined by configure Wei Liu
2016-06-13 10:07   ` Andrew Cooper
2016-06-13 10:34     ` Wei Liu
2016-06-13  7:49 ` [PATCH 04/17] build: introduce and export XEN_LIB_DIR Wei Liu
2016-06-13 15:10   ` Ian Jackson
2016-06-13  7:49 ` [PATCH 05/17] tools: install and remove XEN_LIB_DIR in Makefile Wei Liu
2016-06-13 15:11   ` Ian Jackson
2016-06-13  7:49 ` [PATCH 06/17] hotplug/Linux: honour XEN_LIB_DIR Wei Liu
2016-06-13 15:12   ` Ian Jackson
2016-06-13  7:49 ` [PATCH 07/17] libxl: " Wei Liu
2016-06-13 15:12   ` Ian Jackson
2016-06-13  7:49 ` [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile Wei Liu
2016-06-13 15:13   ` Ian Jackson
2016-06-13 15:29     ` Wei Liu
2016-06-13 16:07       ` Ian Jackson
2016-06-13 16:33         ` Wei Liu
2016-06-13 16:57           ` Ian Jackson
2016-06-13 18:16             ` Wei Liu
2016-06-14  9:56               ` Ian Jackson
2016-06-13  7:49 ` [PATCH 09/17] docs: honour XEN_DUMP_DIR Wei Liu
2016-06-13 15:15   ` Ian Jackson
2016-06-13  7:49 ` [PATCH 10/17] build: introduce XEN_RUN_STORED Wei Liu
2016-06-14 17:00   ` Ian Jackson
2016-06-13  7:49 ` [PATCH 11/17] hotplug/Linux: honour XEN_RUN_STORED Wei Liu
2016-06-13 15:19   ` Ian Jackson
2016-06-13  7:49 ` [PATCH 12/17] libxenstore: " Wei Liu
2016-06-13 15:19   ` Ian Jackson
2016-06-13  7:49 ` [PATCH 13/17] hotplug/FreeBSD: " Wei Liu
2016-06-13  9:32   ` Roger Pau Monné
2016-06-13 15:20   ` Ian Jackson
2016-06-13  7:49 ` [PATCH 14/17] ocaml/libxs: generate a paths.ml Wei Liu
2016-06-13 15:19   ` Ian Jackson
2016-06-13 15:22     ` Wei Liu
2016-06-13 19:50       ` David Scott
2016-06-14  9:36         ` Wei Liu
2016-06-14 20:08           ` David Scott
2016-06-15  9:07             ` Wei Liu
2016-06-13  7:49 ` [PATCH 15/17] ocaml/libxs: honour XEN_RUN_STORED Wei Liu
2016-06-14 20:06   ` David Scott [this message]
2016-06-13  7:49 ` [PATCH 16/17] oxenstored: honour XEN_RUN_STORED and XEN_CONFIG_DIR Wei Liu
2016-06-14 20:07   ` David Scott
2016-06-13  7:49 ` [PATCH 17/17] oxenstored: honour XEN_RUN_STORED in systemd C stub Wei Liu
2016-06-14 20:07   ` David Scott
2016-06-14 13:17 ` [PATCH 00/17] Honour more configure variables in various places (iteration 2) Wei Liu
2016-06-17 10:43   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F402258D-54E4-4B2F-A5F3-F3B07490FF01@recoil.org \
    --to=dave@recoil.org \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).