From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_ADSP_ALL,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 969C8C3A59C for ; Fri, 16 Aug 2019 12:54:37 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DD212064A for ; Fri, 16 Aug 2019 12:54:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amazon.de header.i=@amazon.de header.b="jnDnHJuK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DD212064A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hybkQ-0005G3-NF; Fri, 16 Aug 2019 12:54:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hybkO-0005Fr-Jr for xen-devel@lists.xenproject.org; Fri, 16 Aug 2019 12:54:24 +0000 X-Inumbo-ID: f6dde7d2-c024-11e9-8bb6-12813bfff9fa Received: from smtp-fw-33001.amazon.com (unknown [207.171.190.10]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f6dde7d2-c024-11e9-8bb6-12813bfff9fa; Fri, 16 Aug 2019 12:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1565960061; x=1597496061; h=from:to:cc:subject:date:message-id:references: in-reply-to; bh=VN/qpdVp31ob+sDraYj6pGpwNT9DmcLFLOB1IY4UEw4=; b=jnDnHJuKd2srbOeg68oNROJMmOYMDu/Y/JTDh5J3lp5cS+/XWZBS4rWn vsdS/3UACZNNTdsVkUz3TqF3SbNOFZBs/AAlf75P3EE24ElQnetVwy0mK nH1fAOFMnmRIogYcMtSoh4np115GJJ36MkCi31D7vSIbFFA0YOWpeo+bv k=; X-Amazon-filename: signature.asc X-IronPort-AV: E=Sophos;i="5.64,393,1559520000"; d="asc'?scan'208,217";a="820472317" Content-Type: multipart/mixed; boundary="===============2627943336264604766==" MIME-Version: 1.0 Received: from sea3-co-svc-lb6-vlan2.sea.amazon.com (HELO email-inbound-relay-1a-16acd5e0.us-east-1.amazon.com) ([10.47.22.34]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 16 Aug 2019 12:54:17 +0000 Received: from EX13MTAUEA001.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan2.iad.amazon.com [10.40.159.162]) by email-inbound-relay-1a-16acd5e0.us-east-1.amazon.com (Postfix) with ESMTPS id 2D851A2168; Fri, 16 Aug 2019 12:54:13 +0000 (UTC) Received: from EX13D05EUB004.ant.amazon.com (10.43.166.115) by EX13MTAUEA001.ant.amazon.com (10.43.61.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 16 Aug 2019 12:54:13 +0000 Received: from EX13D05EUB004.ant.amazon.com (10.43.166.115) by EX13D05EUB004.ant.amazon.com (10.43.166.115) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 16 Aug 2019 12:54:12 +0000 Received: from EX13D05EUB004.ant.amazon.com ([10.43.166.115]) by EX13D05EUB004.ant.amazon.com ([10.43.166.115]) with mapi id 15.00.1367.000; Fri, 16 Aug 2019 12:54:12 +0000 From: "Wieczorkiewicz, Pawel" To: Wei Liu Thread-Topic: [PATCH lp-metadata 3/3] livepatch: Add metadata runtime retrieval mechanism Thread-Index: AQHVU1x89n3d35oUnkWtHe3QPQw/V6b9ugqAgAACoQA= Date: Fri, 16 Aug 2019 12:54:12 +0000 Message-ID: References: <20190815112750.11581-1-wipawel@amazon.de> <20190816124445.n767e5yra4zodt3z@liuwe-gateway.j3c5onc20sse1dnehy4noqpfcg.zx.internal.cloudapp.net> In-Reply-To: <20190816124445.n767e5yra4zodt3z@liuwe-gateway.j3c5onc20sse1dnehy4noqpfcg.zx.internal.cloudapp.net> Accept-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.165.55] MIME-Version: 1.0 Precedence: Bulk Subject: Re: [Xen-devel] [PATCH lp-metadata 3/3] livepatch: Add metadata runtime retrieval mechanism X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Tim Deegan , Stefano Stabellini , Konrad Rzeszutek Wilk , George Dunlap , Andrew Cooper , Ross Lagerwall , Ian Jackson , xen-devel , "Pohlack, Martin" , "Wieczorkiewicz, Pawel" , Julien Grall , Jan Beulich , "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --===============2627943336264604766== Content-Language: en-US Content-Type: multipart/signed; boundary="Apple-Mail=_14A1327F-F221-4FC0-BD37-A3719E36888E"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Apple-Mail=_14A1327F-F221-4FC0-BD37-A3719E36888E Content-Type: multipart/alternative; boundary="Apple-Mail=_271DA19A-C45C-4D4D-BEF6-CDCA5D540787" --Apple-Mail=_271DA19A-C45C-4D4D-BEF6-CDCA5D540787 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 16. Aug 2019, at 14:44, Wei Liu wrote: >=20 > On Thu, Aug 15, 2019 at 11:27:50AM +0000, Pawel Wieczorkiewicz wrote: >> Extend the livepatch list operation to fetch also payloads' metadata. >> This is achieved by extending the sysctl list interface with 2 extra >> guest handles: >> * metadata - an array of arbitrary size strings >> * metadata_len - an array of metadata strings' lengths (uin32_t each) =E2=80=A6snip... >> Signed-off-by: Pawel Wieczorkiewicz >> Reviewed-by: Andra-Irina Paraschiv >> Reviewed-by: Martin Pohlack >> Reviewed-by: Norbert Manthey >> --- >> tools/libxc/include/xenctrl.h | 22 +++++++++++---- >> tools/libxc/xc_misc.c | 66 = +++++++++++++++++++++++++++++++++++-------- >> tools/misc/xen-livepatch.c | 43 ++++++++++++++++++++++------ >> xen/common/livepatch.c | 22 +++++++++++---- >> xen/include/public/sysctl.h | 19 +++++++++---- >=20 > Mostly look good. One comment below... >=20 >> diff --git a/xen/include/public/sysctl.h = b/xen/include/public/sysctl.h >> index b86804b7a6..e4c8f4fe63 100644 >> --- a/xen/include/public/sysctl.h >> +++ b/xen/include/public/sysctl.h >=20 > If it hasn't been done for this release already, changing sysctl = interface requires > bumping the version number in this header. >=20 ACK. Will do (also for earlier patches=E2=80=A6). > Wei. Best Regards, Pawel Wieczorkiewicz --Apple-Mail=_271DA19A-C45C-4D4D-BEF6-CDCA5D540787 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On = 16. Aug 2019, at 14:44, Wei Liu <wl@xen.org> wrote:

On Thu, Aug 15, 2019 at = 11:27:50AM +0000, Pawel Wieczorkiewicz wrote:
Extend = the livepatch list operation to fetch also payloads' metadata.
This is achieved by extending the sysctl list interface with = 2 extra
guest handles:
* metadata =     - an array of arbitrary size strings
* metadata_len - an array of metadata strings' lengths = (uin32_t each)

=E2=80=A6snip...

Signed-off-by: Pawel Wieczorkiewicz = <wipawel@amazon.de>
Reviewed-by: = Andra-Irina Paraschiv <andraprs@amazon.com>
Reviewed-by: Martin = Pohlack <mpohlack@amazon.de>
Reviewed-by: Norbert = Manthey <nmanthey@amazon.de>
---
tools/libxc/include/xenctrl.h | 22 +++++++++++----
tools/libxc/xc_misc.c =         | 66 = +++++++++++++++++++++++++++++++++++--------
tools/misc/xen-livepatch.c    | 43 = ++++++++++++++++++++++------
xen/common/livepatch.c =        | 22 +++++++++++----
xen/include/public/sysctl.h   | 19 +++++++++----

Mostly look good. One comment below...

diff = --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
index b86804b7a6..e4c8f4fe63 100644
--- = a/xen/include/public/sysctl.h
+++ = b/xen/include/public/sysctl.h

If it hasn't been done for this = release already, changing sysctl interface requires
bumping the version number in = this header.


ACK. = Will do (also for earlier patches=E2=80=A6).

Wei.

Best Regards,
Pawel = Wieczorkiewicz
= --Apple-Mail=_271DA19A-C45C-4D4D-BEF6-CDCA5D540787-- --Apple-Mail=_14A1327F-F221-4FC0-BD37-A3719E36888E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="signature.asc" Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEMfesMdpdS8dLoCFipZXgubqFgvsFAl1Wp3MACgkQpZXgubqF gvvsEw//dGLfXJOradMpGJ/mhubnu9mf3ryXxuponSZ+Y6cqSKZwQIE6Enw1jOLo 4myvIEAwajuEA8FP2vCuWb+8niOjz9cAnwpzf051MmWW8N8Pn4gjDdQnwAlX04Z4 NnAnsX8NvuaUjLOCVdNQarDU1koXi1laqP7ynnAYq0b4Aggo7syRtvmEoc/mUyzH PI7iCxnxu4FJ6N9NHdB9pQQQ9YT968IU+yUojgewoY5YHnaqvLD6K12EsoBGNbrx BfVay6hZSh0sqC4SwZyAzDsSt7TbhAbD7iPziBe/L126iIdanaM2l5KL8rP/GyHy kIvfxlNFj36AZ2P5v2MNdPNfGauwnTIjsKTX7hMNyE2ms/36eWNgELriVD09+uCU ilMQ3zq22Ixgx5eEbizB4u7Z/Nh6cs9kxHxOaWop4GdUXG0IeH5UBbe0M6HgSvbD u0VkyIhgdlOkfKqENEHlNv6AZCWVyKztAjWuNUyM0ACkuld4/72eqezyKj4lLiJB Cc8kI+sXapBhgkNwdlpxoBSfkWO9nTBfIrqPq2xswNKviczAuzKCmzuLwc5T0PjP A7bh0FsVZUgznDgSGOtmzZ6JhBkTJvoq11djtjAG9a08GUpPlQT6SSADl1R9jq4r v2lGcfMVG9a7hYAce2/KwkRppSAr0OVq4Jaz/pzl9YENKPvZUhs= =8+Un -----END PGP SIGNATURE----- --Apple-Mail=_14A1327F-F221-4FC0-BD37-A3719E36888E-- --===============2627943336264604766== Content-Type: multipart/alternative; boundary="===============6586579561050471471==" MIME-Version: 1.0 Content-Disposition: inline --===============6586579561050471471== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879 --===============6586579561050471471== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable


Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879


--===============6586579561050471471==-- --===============2627943336264604766== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============2627943336264604766==--