From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
Wei Liu <wl@xen.org>, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v3 1/8] xen: fix build when $(obj-y) consists of just blanks
Date: Wed, 9 Dec 2020 17:40:07 +0000 [thread overview]
Message-ID: <X9EL90SMyqrs9GaL@perard.uk.xensource.com> (raw)
In-Reply-To: <511be84d-9a13-17ae-f3d9-d6daf9c02711@suse.com>
On Mon, Nov 23, 2020 at 04:20:52PM +0100, Jan Beulich wrote:
> This case can occur when combining empty lists
>
> obj-y :=
> ...
> obj-y += $(empty)
>
> or
>
> obj-y := $(empty) $(empty)
>
> where (only) blanks would accumulate. This was only a latent issue until
> now, but would become an active issue for Arm once lib/ gets populated
> with all respective objects going into the to be introduced lib.a.
>
> Also address a related issue at this occasion: When an empty built_in.o
> gets created, .built_in.o.d will have its dependencies recorded. If, on
> a subsequent incremental build, an actual constituent of built_in.o
> appeared, the $(filter-out ) would leave these recorded dependencies in
> place. But of course the linker won't know what to do with C header
> files. (The apparent alternative of avoiding to pass $(c_flags) or
> $(a_flags) would not be reliable afaict, as among these flags there may
> be some affecting information conveyed via the object file to the
> linker. The linker, finding inconsistent flags across object files, may
How about using $(XEN_CFLAGS) instead of $(c_flags)? That should prevent
CC from generating the .*.o.d files while keeping the relevant flags. I
was planing to do that to avoid the issue, see:
https://lore.kernel.org/xen-devel/20200421161208.2429539-10-anthony.perard@citrix.com
> then error out.) Using just $(obj-y) won't work either: It breaks when
> the same object file is listed more than once.
Do we need to worry about having a object file been listed twice?
Wouldn't that be a mistake?
--
Anthony PERARD
next prev parent reply other threads:[~2020-12-09 17:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 15:16 [PATCH v3 0/8] xen: beginnings of moving library-like code into an archive Jan Beulich
2020-11-23 15:20 ` [PATCH v3 1/8] xen: fix build when $(obj-y) consists of just blanks Jan Beulich
2020-12-09 11:34 ` Bertrand Marquis
2020-12-09 17:40 ` Anthony PERARD [this message]
2020-12-10 10:21 ` Jan Beulich
2020-12-10 14:50 ` Anthony PERARD
2020-11-23 15:21 ` [PATCH v3 2/8] lib: collect library files in an archive Jan Beulich
2020-12-09 11:37 ` Bertrand Marquis
2020-12-09 14:42 ` Jan Beulich
2020-12-09 14:46 ` Bertrand Marquis
2020-12-10 14:47 ` Anthony PERARD
2020-12-11 10:00 ` Jan Beulich
2020-12-11 15:49 ` Anthony PERARD
2020-12-18 8:02 ` Ping: Arm: " Jan Beulich
2020-12-18 9:25 ` Julien Grall
2020-11-23 15:21 ` [PATCH v3 3/8] lib: move list sorting code Jan Beulich
2020-12-09 11:39 ` Bertrand Marquis
2020-11-23 15:22 ` [PATCH v3 4/8] lib: move parse_size_and_unit() Jan Beulich
2020-12-09 11:40 ` Bertrand Marquis
2020-11-23 15:22 ` [PATCH v3 5/8] lib: move init_constructors() Jan Beulich
2020-12-09 14:16 ` Bertrand Marquis
2020-11-23 15:23 ` [PATCH v3 6/8] lib: move rbtree code Jan Beulich
2020-12-09 14:18 ` Bertrand Marquis
2020-11-23 15:23 ` [PATCH v3 7/8] lib: move bsearch code Jan Beulich
2020-11-23 15:24 ` [PATCH v3 8/8] lib: move sort code Jan Beulich
2020-12-09 14:27 ` Bertrand Marquis
2020-12-04 11:43 ` [PATCH v3 0/8] xen: beginnings of moving library-like code into an archive Wei Liu
2020-12-09 11:33 ` Bertrand Marquis
2020-12-09 14:47 ` Jan Beulich
2020-12-09 14:51 ` Julien Grall
2020-12-09 14:56 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9EL90SMyqrs9GaL@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).