From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Ian Jackson <iwj@xenproject.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Dario Faggioli <dfaggioli@suse.com>
Subject: Revert NR_CPUS=1 fix from 4.15 (was: Re: [PATCH] fix for_each_cpu() again for NR_CPUS=1)
Date: Thu, 1 Apr 2021 11:00:53 +0200 [thread overview]
Message-ID: <YGWLxey5nZeafUbB@Air-de-Roger> (raw)
In-Reply-To: <4d993e67-2bdf-9ac3-f78e-daf279642de1@suse.com>
On Wed, Mar 31, 2021 at 04:52:47PM +0200, Jan Beulich wrote:
> Unfortunately aa50f45332f1 ("xen: fix for_each_cpu when NR_CPUS=1") has
> caused quite a bit of fallout with gcc10, e.g. (there are at least two
> more similar ones, and I didn't bother trying to find them all):
>
> In file included from .../xen/include/xen/config.h:13,
> from <command-line>:
> core_parking.c: In function ‘core_parking_power’:
> .../xen/include/asm/percpu.h:12:51: error: array subscript 1 is above array bounds of ‘long unsigned int[1]’ [-Werror=array-bounds]
> 12 | (*RELOC_HIDE(&per_cpu__##var, __per_cpu_offset[cpu]))
> .../xen/include/xen/compiler.h:141:29: note: in definition of macro ‘RELOC_HIDE’
> 141 | (typeof(ptr)) (__ptr + (off)); })
> | ^~~
> core_parking.c:133:39: note: in expansion of macro ‘per_cpu’
> 133 | core_tmp = cpumask_weight(per_cpu(cpu_core_mask, cpu));
> | ^~~~~~~
> In file included from .../xen/include/xen/percpu.h:4,
> from .../xen/include/asm/msr.h:7,
> from .../xen/include/asm/time.h:5,
> from .../xen/include/xen/time.h:76,
> from .../xen/include/xen/spinlock.h:4,
> from .../xen/include/xen/cpu.h:5,
> from core_parking.c:19:
> .../xen/include/asm/percpu.h:6:22: note: while referencing ‘__per_cpu_offset’
> 6 | extern unsigned long __per_cpu_offset[NR_CPUS];
> | ^~~~~~~~~~~~~~~~
At this point, should be consider reverting the original fix from the
4.15 branch, so that we don't release something that's build broken
with gcc 10?
Roger.
next prev parent reply other threads:[~2021-04-01 9:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 14:52 [PATCH] fix for_each_cpu() again for NR_CPUS=1 Jan Beulich
2021-03-31 16:55 ` Dario Faggioli
2021-04-01 6:13 ` Jan Beulich
2021-04-01 9:00 ` Roger Pau Monné [this message]
2021-04-01 9:26 ` Revert NR_CPUS=1 fix from 4.15 (was: Re: [PATCH] fix for_each_cpu() again for NR_CPUS=1) Jan Beulich
2021-04-01 9:50 ` Roger Pau Monné
2021-04-06 9:52 ` Ian Jackson
2021-04-06 9:50 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGWLxey5nZeafUbB@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=dfaggioli@suse.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).