From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
Paul Durrant <paul@xen.org>, Paul Durrant <pdurrant@amazon.com>,
<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks
Date: Thu, 1 Apr 2021 11:12:52 +0200 [thread overview]
Message-ID: <YGWOlHRvYTTy5wBh@Air-de-Roger> (raw)
In-Reply-To: <1bc56db3-203d-1fa8-ad5c-68d97d584600@citrix.com>
On Wed, Mar 31, 2021 at 05:24:24PM +0100, Andrew Cooper wrote:
> On 31/03/2021 17:02, Jan Beulich wrote:
> > On 31.03.2021 12:32, Roger Pau Monne wrote:
> >> EOIs are always executed in guest vCPU context, so there's no reason to
> >> pass a vCPU parameter around as can be fetched from current.
> >>
> >> While there make the vector parameter of both callbacks unsigned int.
> >>
> >> No functional change intended.
> >>
> >> Suggested-by: Paul Durrant <pdurrant@amazon.com>
> >> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >> Reviewed-by: Paul Durrant <paul@xen.org>
> >> ---
> >> Changes since v1:
> >> - New in this version.
> > I'm afraid the situation with viridian_synic_wrmsr() hasn't changed
> > since v2, and hence my previous comment still applies.
>
> Only just spotted that line of reasoning.
>
> Longterm, I do want to remove all the Viridian special cases, and handle
> all of the state via architectural mechanisms (cpu policy for static
> settings, and the existing MSR records for dynamic content).
>
> A consequence of this cleanup is that guest_{rd,wr}msr() will be
> eventually be used to save/restore dynamic state in the migrate stream,
> which is why I've been engineering guest_{rd,wr}msr() to work for MSRs
> in "current || !scheduled" context.
>
> As such, it is important to retain a vcpu pointer because it will not be
> current on the save/restore hypercalls, which execute in control domain
> context.
But you are never going to restore an HV_X64_MSR_EOI MSR, as such
should never be part of the migrate stream in the first place. It
doesn't have a value itself - it's only used as an alternative way to
EOI an interrupt.
I still think the EOIs will always be performed on the affected vCPU
context, but I don't want this discussion the block the current
series, so I'm just going to drop this patch.
Roger.
next prev parent reply other threads:[~2021-04-01 9:13 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 10:32 [PATCH v3 00/11] x86/intr: introduce EOI callbacks and fix vPT Roger Pau Monne
2021-03-31 10:32 ` [PATCH v3 01/11] x86/hvm: drop vcpu parameter from vlapic EOI callbacks Roger Pau Monne
2021-03-31 16:02 ` Jan Beulich
2021-03-31 16:24 ` Andrew Cooper
2021-04-01 9:12 ` Roger Pau Monné [this message]
2021-04-01 11:06 ` Jan Beulich
2021-04-07 7:41 ` Roger Pau Monné
2021-04-07 8:19 ` Jan Beulich
2021-03-31 10:32 ` [PATCH v3 02/11] x86/hvm: drop domain parameter from vioapic/vpic " Roger Pau Monne
2021-03-31 16:04 ` Jan Beulich
2021-04-01 9:15 ` Roger Pau Monné
2021-04-01 9:28 ` Jan Beulich
2021-03-31 10:32 ` [PATCH v3 03/11] x86/vlapic: introduce an EOI callback mechanism Roger Pau Monne
2021-03-31 11:47 ` Andrew Cooper
2021-03-31 12:50 ` Roger Pau Monné
2021-04-07 14:55 ` Jan Beulich
2021-04-07 16:27 ` Roger Pau Monné
2021-04-08 6:20 ` Jan Beulich
2021-04-08 9:12 ` Roger Pau Monné
2021-04-08 10:49 ` Jan Beulich
2021-04-08 10:56 ` Roger Pau Monné
2021-03-31 10:32 ` [PATCH v3 04/11] x86/vmsi: use the newly introduced EOI callbacks Roger Pau Monne
2021-04-07 14:59 ` Jan Beulich
2021-03-31 10:32 ` [PATCH v3 05/11] x86/vioapic: switch to use the EOI callback mechanism Roger Pau Monne
2021-04-07 15:19 ` Jan Beulich
2021-04-07 16:46 ` Roger Pau Monné
2021-04-08 6:27 ` Jan Beulich
2021-04-08 8:59 ` Roger Pau Monné
2021-04-08 10:52 ` Jan Beulich
2021-03-31 10:32 ` [PATCH v3 06/11] x86/hvm: allowing registering EOI callbacks for GSIs Roger Pau Monne
2021-04-07 15:51 ` Jan Beulich
2021-04-07 17:08 ` Roger Pau Monné
2021-04-08 6:34 ` Jan Beulich
2021-04-15 16:04 ` Roger Pau Monné
2021-04-16 7:29 ` Jan Beulich
2021-04-19 8:31 ` Roger Pau Monné
2021-04-08 12:52 ` Roger Pau Monné
2021-04-08 14:31 ` Jan Beulich
2021-04-08 15:06 ` Roger Pau Monné
2021-03-31 10:32 ` [PATCH v3 07/11] x86/dpci: move code Roger Pau Monne
2021-03-31 10:33 ` [PATCH v3 08/11] x86/dpci: switch to use a GSI EOI callback Roger Pau Monne
2021-04-08 14:49 ` Jan Beulich
2021-04-08 15:23 ` Roger Pau Monné
2021-03-31 10:33 ` [PATCH v3 09/11] x86/vpt: switch interrupt injection model Roger Pau Monne
2021-04-14 10:28 ` Jan Beulich
2021-04-14 13:37 ` Roger Pau Monné
2021-04-14 14:05 ` Jan Beulich
2021-04-14 14:20 ` Roger Pau Monné
2021-03-31 10:33 ` [PATCH v3 10/11] x86/vpt: remove vPT timers per-vCPU lists Roger Pau Monne
2021-04-14 10:38 ` Jan Beulich
2021-03-31 10:33 ` [PATCH v3 11/11] x86/vpt: introduce a per-vPT lock Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGWOlHRvYTTy5wBh@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=paul@xen.org \
--cc=pdurrant@amazon.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).