* [PATCH 00/11] Rid W=1 warnings from Block
@ 2021-03-12 10:55 Lee Jones
2021-03-12 10:55 ` [PATCH 10/11] block: xen-blkfront: Demote kernel-doc abuses Lee Jones
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Lee Jones @ 2021-03-12 10:55 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Boris Ostrovsky, drbd-dev, Jens Axboe,
Joshua Morris, Juergen Gross, Konrad Rzeszutek Wilk,
Lars Ellenberg, linux-block, Philip Kelleher, Philipp Reisner,
Roger Pau Monné,
Stefano Stabellini, xen-devel
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee Jones (11):
block: rsxx: core: Remove superfluous const qualifier
block: drbd: drbd_interval: Demote some kernel-doc abuses and fix
another header
block: mtip32xx: mtip32xx: Mark debugging variable 'start' as
__maybe_unused
block: drbd: drbd_state: Fix some function documentation issues
block: drbd: drbd_receiver: Demote non-conformant kernel-doc headers
block: drbd: drbd_main: Remove duplicate field initialisation
block: drbd: drbd_nl: Make conversion to 'enum drbd_ret_code' explicit
block: drbd: drbd_main: Fix a bunch of function documentation
discrepancies
block: drbd: drbd_receiver: Demote less than half complete kernel-doc
header
block: xen-blkfront: Demote kernel-doc abuses
block: drbd: drbd_nl: Demote half-complete kernel-doc headers
drivers/block/drbd/drbd_interval.c | 8 +++++---
drivers/block/drbd/drbd_main.c | 30 +++++++++++++++---------------
drivers/block/drbd/drbd_nl.c | 17 ++++++++++-------
drivers/block/drbd/drbd_receiver.c | 26 ++++++++++++--------------
drivers/block/drbd/drbd_state.c | 7 ++++---
drivers/block/mtip32xx/mtip32xx.c | 2 +-
drivers/block/rsxx/core.c | 2 +-
drivers/block/xen-blkfront.c | 6 +++---
8 files changed, 51 insertions(+), 47 deletions(-)
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: drbd-dev@lists.linbit.com
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Joshua Morris <josh.h.morris@us.ibm.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Lars Ellenberg <lars.ellenberg@linbit.com>
Cc: linux-block@vger.kernel.org
Cc: Philip Kelleher <pjk1939@linux.ibm.com>
Cc: Philipp Reisner <philipp.reisner@linbit.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org
--
2.27.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 10/11] block: xen-blkfront: Demote kernel-doc abuses
2021-03-12 10:55 [PATCH 00/11] Rid W=1 warnings from Block Lee Jones
@ 2021-03-12 10:55 ` Lee Jones
2021-04-06 9:09 ` Roger Pau Monné
2021-03-30 13:21 ` [PATCH 00/11] Rid W=1 warnings from Block Lee Jones
2021-04-06 15:22 ` Jens Axboe
2 siblings, 1 reply; 7+ messages in thread
From: Lee Jones @ 2021-03-12 10:55 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Konrad Rzeszutek Wilk, Roger Pau Monné,
Boris Ostrovsky, Juergen Gross, Stefano Stabellini, Jens Axboe,
xen-devel, linux-block
Fixes the following W=1 kernel build warning(s):
drivers/block/xen-blkfront.c:1960: warning: Function parameter or member 'dev' not described in 'blkfront_probe'
drivers/block/xen-blkfront.c:1960: warning: Function parameter or member 'id' not described in 'blkfront_probe'
drivers/block/xen-blkfront.c:1960: warning: expecting prototype for Allocate the basic(). Prototype was for blkfront_probe() instead
drivers/block/xen-blkfront.c:2085: warning: Function parameter or member 'dev' not described in 'blkfront_resume'
drivers/block/xen-blkfront.c:2085: warning: expecting prototype for or a backend(). Prototype was for blkfront_resume() instead
drivers/block/xen-blkfront.c:2444: warning: wrong kernel-doc identifier on line:
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: xen-devel@lists.xenproject.org
Cc: linux-block@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/block/xen-blkfront.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index e1c6798889f48..e57e3cd354fb8 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -1949,7 +1949,7 @@ module_param(feature_persistent, bool, 0644);
MODULE_PARM_DESC(feature_persistent,
"Enables the persistent grants feature");
-/**
+/*
* Entry point to this code when a new device is created. Allocate the basic
* structures and the ring buffer for communication with the backend, and
* inform the backend of the appropriate details for those. Switch to
@@ -2075,7 +2075,7 @@ static int blkif_recover(struct blkfront_info *info)
return 0;
}
-/**
+/*
* We are reconnecting to the backend, due to a suspend/resume, or a backend
* driver restart. We tear down our blkif structure and recreate it, but
* leave the device-layer structures intact so that this is transparent to the
@@ -2440,7 +2440,7 @@ static void blkfront_connect(struct blkfront_info *info)
return;
}
-/**
+/*
* Callback received when the backend's state changes.
*/
static void blkback_changed(struct xenbus_device *dev,
--
2.27.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 00/11] Rid W=1 warnings from Block
2021-03-12 10:55 [PATCH 00/11] Rid W=1 warnings from Block Lee Jones
2021-03-12 10:55 ` [PATCH 10/11] block: xen-blkfront: Demote kernel-doc abuses Lee Jones
@ 2021-03-30 13:21 ` Lee Jones
2021-04-06 8:52 ` Lee Jones
2021-04-06 15:22 ` Jens Axboe
2 siblings, 1 reply; 7+ messages in thread
From: Lee Jones @ 2021-03-30 13:21 UTC (permalink / raw)
To: linux-kernel, Boris Ostrovsky, drbd-dev, Jens Axboe,
Joshua Morris, Juergen Gross, Konrad Rzeszutek Wilk,
Lars Ellenberg, linux-block, Philip Kelleher, Philipp Reisner,
Roger Pau Monné,
Stefano Stabellini, xen-devel
On Fri, 12 Mar 2021, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Lee Jones (11):
> block: rsxx: core: Remove superfluous const qualifier
> block: drbd: drbd_interval: Demote some kernel-doc abuses and fix
> another header
> block: mtip32xx: mtip32xx: Mark debugging variable 'start' as
> __maybe_unused
> block: drbd: drbd_state: Fix some function documentation issues
> block: drbd: drbd_receiver: Demote non-conformant kernel-doc headers
> block: drbd: drbd_main: Remove duplicate field initialisation
> block: drbd: drbd_nl: Make conversion to 'enum drbd_ret_code' explicit
> block: drbd: drbd_main: Fix a bunch of function documentation
> discrepancies
> block: drbd: drbd_receiver: Demote less than half complete kernel-doc
> header
> block: xen-blkfront: Demote kernel-doc abuses
> block: drbd: drbd_nl: Demote half-complete kernel-doc headers
Would you like me to resubmit these?
> drivers/block/drbd/drbd_interval.c | 8 +++++---
> drivers/block/drbd/drbd_main.c | 30 +++++++++++++++---------------
> drivers/block/drbd/drbd_nl.c | 17 ++++++++++-------
> drivers/block/drbd/drbd_receiver.c | 26 ++++++++++++--------------
> drivers/block/drbd/drbd_state.c | 7 ++++---
> drivers/block/mtip32xx/mtip32xx.c | 2 +-
> drivers/block/rsxx/core.c | 2 +-
> drivers/block/xen-blkfront.c | 6 +++---
> 8 files changed, 51 insertions(+), 47 deletions(-)
>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: drbd-dev@lists.linbit.com
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Joshua Morris <josh.h.morris@us.ibm.com>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Lars Ellenberg <lars.ellenberg@linbit.com>
> Cc: linux-block@vger.kernel.org
> Cc: Philip Kelleher <pjk1939@linux.ibm.com>
> Cc: Philipp Reisner <philipp.reisner@linbit.com>
> Cc: "Roger Pau Monné" <roger.pau@citrix.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: xen-devel@lists.xenproject.org
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 00/11] Rid W=1 warnings from Block
2021-03-30 13:21 ` [PATCH 00/11] Rid W=1 warnings from Block Lee Jones
@ 2021-04-06 8:52 ` Lee Jones
0 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2021-04-06 8:52 UTC (permalink / raw)
To: linux-kernel, Boris Ostrovsky, drbd-dev, Jens Axboe,
Joshua Morris, Juergen Gross, Konrad Rzeszutek Wilk,
Lars Ellenberg, linux-block, Philip Kelleher, Philipp Reisner,
Roger Pau Monné,
Stefano Stabellini, xen-devel
On Tue, 30 Mar 2021, Lee Jones wrote:
> On Fri, 12 Mar 2021, Lee Jones wrote:
>
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Lee Jones (11):
> > block: rsxx: core: Remove superfluous const qualifier
> > block: drbd: drbd_interval: Demote some kernel-doc abuses and fix
> > another header
> > block: mtip32xx: mtip32xx: Mark debugging variable 'start' as
> > __maybe_unused
> > block: drbd: drbd_state: Fix some function documentation issues
> > block: drbd: drbd_receiver: Demote non-conformant kernel-doc headers
> > block: drbd: drbd_main: Remove duplicate field initialisation
> > block: drbd: drbd_nl: Make conversion to 'enum drbd_ret_code' explicit
> > block: drbd: drbd_main: Fix a bunch of function documentation
> > discrepancies
> > block: drbd: drbd_receiver: Demote less than half complete kernel-doc
> > header
> > block: xen-blkfront: Demote kernel-doc abuses
> > block: drbd: drbd_nl: Demote half-complete kernel-doc headers
>
> Would you like me to resubmit these?
It's been 3.5 weeks since these were submitted.
We are now at -rc6, so these should be merged soon.
Is there anything you'd like me to do to help?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 10/11] block: xen-blkfront: Demote kernel-doc abuses
2021-03-12 10:55 ` [PATCH 10/11] block: xen-blkfront: Demote kernel-doc abuses Lee Jones
@ 2021-04-06 9:09 ` Roger Pau Monné
0 siblings, 0 replies; 7+ messages in thread
From: Roger Pau Monné @ 2021-04-06 9:09 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Konrad Rzeszutek Wilk, Boris Ostrovsky,
Juergen Gross, Stefano Stabellini, Jens Axboe, xen-devel,
linux-block
On Fri, Mar 12, 2021 at 10:55:29AM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/block/xen-blkfront.c:1960: warning: Function parameter or member 'dev' not described in 'blkfront_probe'
> drivers/block/xen-blkfront.c:1960: warning: Function parameter or member 'id' not described in 'blkfront_probe'
> drivers/block/xen-blkfront.c:1960: warning: expecting prototype for Allocate the basic(). Prototype was for blkfront_probe() instead
> drivers/block/xen-blkfront.c:2085: warning: Function parameter or member 'dev' not described in 'blkfront_resume'
> drivers/block/xen-blkfront.c:2085: warning: expecting prototype for or a backend(). Prototype was for blkfront_resume() instead
> drivers/block/xen-blkfront.c:2444: warning: wrong kernel-doc identifier on line:
>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: "Roger Pau Monné" <roger.pau@citrix.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: xen-devel@lists.xenproject.org
> Cc: linux-block@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 00/11] Rid W=1 warnings from Block
2021-03-12 10:55 [PATCH 00/11] Rid W=1 warnings from Block Lee Jones
2021-03-12 10:55 ` [PATCH 10/11] block: xen-blkfront: Demote kernel-doc abuses Lee Jones
2021-03-30 13:21 ` [PATCH 00/11] Rid W=1 warnings from Block Lee Jones
@ 2021-04-06 15:22 ` Jens Axboe
2021-04-06 15:32 ` Lee Jones
2 siblings, 1 reply; 7+ messages in thread
From: Jens Axboe @ 2021-04-06 15:22 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Boris Ostrovsky, drbd-dev, Joshua Morris,
Juergen Gross, Konrad Rzeszutek Wilk, Lars Ellenberg,
linux-block, Philip Kelleher, Philipp Reisner,
Roger Pau Monné,
Stefano Stabellini, xen-devel
On 3/12/21 3:55 AM, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
Applied 2-11, 1 is already in the my tree.
--
Jens Axboe
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 00/11] Rid W=1 warnings from Block
2021-04-06 15:22 ` Jens Axboe
@ 2021-04-06 15:32 ` Lee Jones
0 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2021-04-06 15:32 UTC (permalink / raw)
To: Jens Axboe
Cc: linux-kernel, Boris Ostrovsky, drbd-dev, Joshua Morris,
Juergen Gross, Konrad Rzeszutek Wilk, Lars Ellenberg,
linux-block, Philip Kelleher, Philipp Reisner,
Roger Pau Monné,
Stefano Stabellini, xen-devel
On Tue, 06 Apr 2021, Jens Axboe wrote:
> On 3/12/21 3:55 AM, Lee Jones wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
>
> Applied 2-11, 1 is already in the my tree.
Superstar, thanks Jens.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-04-06 15:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 10:55 [PATCH 00/11] Rid W=1 warnings from Block Lee Jones
2021-03-12 10:55 ` [PATCH 10/11] block: xen-blkfront: Demote kernel-doc abuses Lee Jones
2021-04-06 9:09 ` Roger Pau Monné
2021-03-30 13:21 ` [PATCH 00/11] Rid W=1 warnings from Block Lee Jones
2021-04-06 8:52 ` Lee Jones
2021-04-06 15:22 ` Jens Axboe
2021-04-06 15:32 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).