From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D3B8C433ED for ; Tue, 6 Apr 2021 14:00:36 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA51D611C1 for ; Tue, 6 Apr 2021 14:00:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA51D611C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.105981.202648 (Exim 4.92) (envelope-from ) id 1lTmFm-0005AL-3L; Tue, 06 Apr 2021 14:00:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105981.202648; Tue, 06 Apr 2021 14:00:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTmFm-0005AE-0L; Tue, 06 Apr 2021 14:00:26 +0000 Received: by outflank-mailman (input) for mailman id 105981; Tue, 06 Apr 2021 14:00:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lTmFk-0005A9-SI for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 14:00:24 +0000 Received: from deinos.phlegethon.org (unknown [2001:41d0:8:b1d7::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 36bba9c2-3397-4473-9b6a-6e280e49d1fe; Tue, 06 Apr 2021 14:00:24 +0000 (UTC) Received: from tjd by deinos.phlegethon.org with local (Exim 4.92.3 (FreeBSD)) (envelope-from ) id 1lTmFa-000Cwc-Pf; Tue, 06 Apr 2021 14:00:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36bba9c2-3397-4473-9b6a-6e280e49d1fe Date: Tue, 6 Apr 2021 15:00:14 +0100 From: Tim Deegan To: Julien Grall Cc: xen-devel@lists.xenproject.org, Julien Grall , Jan Beulich , Andrew Cooper , George Dunlap , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu Subject: Re: [PATCH 03/14] xen/x86: shadow: The return type of sh_audit_flags() should be const Message-ID: References: <20210405155713.29754-1-julien@xen.org> <20210405155713.29754-4-julien@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20210405155713.29754-4-julien@xen.org> X-SA-Known-Good: Yes X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tim@xen.org X-SA-Exim-Scanned: No (on deinos.phlegethon.org); SAEximRunCond expanded to false At 16:57 +0100 on 05 Apr (1617641822), Julien Grall wrote: > From: Julien Grall > > The function sh_audit_flags() is returning pointer to literal strings. > They should not be modified, so the return is now const and this is > propagated to the callers. > > Take the opportunity to fix the coding style in the declaration of > sh_audit_flags. > > Signed-off-by: Julien Grall Acked-by: Tim Deegan Thanks, Tim.