xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] x86/cpuid: do not expand max leaves on restore
Date: Fri, 23 Apr 2021 14:47:53 +0200	[thread overview]
Message-ID: <YILB+fvGT6QPnAhC@Air-de-Roger> (raw)
In-Reply-To: <91a32d56-c0cd-f883-eee5-de2691417703@suse.com>

On Fri, Apr 23, 2021 at 02:41:32PM +0200, Jan Beulich wrote:
> On 23.04.2021 12:54, Roger Pau Monne wrote:
> > When restoring limit the maximum leaves to the ones supported by Xen
> > 4.13 in order to not expand the maximum leaf a guests sees. Note this
> > is unlikely to cause real issues.
> 
> Why 4.13 (and not 4.12) here when ...
> 
> > Guests restored from Xen versions 4.13 or greater will contain CPUID
> > data on the stream that will override the values set by
> > xc_cpuid_apply_policy.
> 
> ... 4.13 already communicates the values?

Urg, yes, my bad. This should have been limited to the max leaves
supported by 4.12, not 4.13.

Let me send a new version also incorporating the feedback from below.

Thanks, Roger.


      reply	other threads:[~2021-04-23 12:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 10:54 [PATCH] x86/cpuid: do not expand max leaves on restore Roger Pau Monne
2021-04-23 12:41 ` Jan Beulich
2021-04-23 12:47   ` Roger Pau Monné [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YILB+fvGT6QPnAhC@Air-de-Roger \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=iwj@xenproject.org \
    --cc=jbeulich@suse.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).