From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7673C433B4 for ; Mon, 26 Apr 2021 17:55:32 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5302C60240 for ; Mon, 26 Apr 2021 17:55:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5302C60240 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.117877.223829 (Exim 4.92) (envelope-from ) id 1lb5S7-00065D-1d; Mon, 26 Apr 2021 17:55:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 117877.223829; Mon, 26 Apr 2021 17:55:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lb5S6-000656-Ux; Mon, 26 Apr 2021 17:55:22 +0000 Received: by outflank-mailman (input) for mailman id 117877; Mon, 26 Apr 2021 17:55:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lb5S6-00063z-4b for xen-devel@lists.xenproject.org; Mon, 26 Apr 2021 17:55:22 +0000 Received: from deinos.phlegethon.org (unknown [2001:41d0:8:b1d7::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 29f2d5a3-d2a7-4d32-942e-728e8f647f4a; Mon, 26 Apr 2021 17:55:21 +0000 (UTC) Received: from tjd by deinos.phlegethon.org with local (Exim 4.92.3 (FreeBSD)) (envelope-from ) id 1lb5S3-000668-KQ; Mon, 26 Apr 2021 17:55:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29f2d5a3-d2a7-4d32-942e-728e8f647f4a Date: Mon, 26 Apr 2021 18:55:19 +0100 From: Tim Deegan To: Jan Beulich Cc: Roger Pau =?iso-8859-1?Q?Monn=E9?= , "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , George Dunlap , Kevin Tian , Jun Nakajima Subject: Re: [PATCH v4 1/3] VMX: use a single, global APIC access page Message-ID: References: <4731a3a3-906a-98ac-11ba-6a0723903391@suse.com> <3e7ad009-f062-d58a-9380-103ce1573a73@suse.com> <837a427a-a74e-00e9-70c7-1d3cfa28b30c@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SA-Known-Good: Yes X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tim@xen.org X-SA-Exim-Scanned: No (on deinos.phlegethon.org); SAEximRunCond expanded to false At 16:42 +0200 on 23 Apr (1619196141), Jan Beulich wrote: > On 23.04.2021 16:17, Roger Pau Monné wrote: > > On Fri, Apr 23, 2021 at 12:52:57PM +0200, Jan Beulich wrote: > >> + if ( mfn_valid(mfn = shadow_l1e_get_mfn(sl1e)) && > > > > Nit: I would prefer if assigned mfn outside of the condition, like > > it's done in the chunk added to shadow_get_page_from_l1e. > > Well, I did it differently here because the variable really is > only needed inside the if(), whereas in "get" the subsequent > patches use it elsewhere as well. I'll wait what Tim says. No strong feelings on this, but since you asked me, I would also prefer it to be outside the condition. Cheers, Tim.