From: "Roger Pau Monné" <email@example.com> To: Jan Beulich <firstname.lastname@example.org> Cc: "email@example.com" <firstname.lastname@example.org>, Andrew Cooper <email@example.com>, George Dunlap <firstname.lastname@example.org>, Ian Jackson <email@example.com>, Julien Grall <firstname.lastname@example.org>, Stefano Stabellini <email@example.com>, Wei Liu <firstname.lastname@example.org> Subject: Re: [PATCH] build: centralize / unify asm-offsets generation Date: Tue, 27 Apr 2021 15:31:33 +0200 [thread overview] Message-ID: <YIgSNRq2w7KSSaiD@Air-de-Roger> (raw) In-Reply-To: <email@example.com> On Tue, Apr 27, 2021 at 02:30:35PM +0200, Jan Beulich wrote: > On 27.04.2021 11:05, Roger Pau Monné wrote: > > On Wed, Apr 21, 2021 at 04:09:03PM +0200, Jan Beulich wrote: > >> On 20.04.2021 18:20, Roger Pau Monné wrote: > >>> On Tue, Apr 20, 2021 at 05:47:49PM +0200, Jan Beulich wrote: > >>>> On 20.04.2021 17:29, Roger Pau Monné wrote: > >>>>> On Thu, Apr 01, 2021 at 10:33:47AM +0200, Jan Beulich wrote: > >>>>>> @@ -399,7 +399,11 @@ include/xen/compile.h: include/xen/compi > >>>>>> @sed -rf tools/process-banner.sed < .banner >> $@.new > >>>>>> @mv -f $@.new $@ > >>>>>> > >>>>>> -include/asm-$(TARGET_ARCH)/asm-offsets.h: arch/$(TARGET_ARCH)/asm-offsets.s > >>>>>> +asm-offsets.s: arch/$(TARGET_ARCH)/$(TARGET_SUBARCH)/asm-offsets.c > >>>>>> + $(CC) $(filter-out -Wa$(comma)% -flto,$(c_flags)) -S -g0 -o $@.new -MQ $@ $< > >>>>>> + $(call move-if-changed,$@.new,$@) > >>>>> > >>>>> Won't it be more natural to keep the .s file in arch/$(TARGET_ARCH)? > >>>> > >>>> Yes and no: Yes as far as the actual file location is concerned. > >>>> No when considering where it gets generated: I generally consider > >>>> it risky to generate files outside of the directory where make > >>>> currently runs. There may be good reasons for certain exceptions, > >>>> but personally I don't see this case as good enough a reason. > >>>> > >>>> Somewhat related - if doing as you suggest, which Makefile's > >>>> clean: rule should clean up that file in your opinion? > >>> > >>> The clean rule should be in the makefile where it's generated IMO, > >>> same as asm-offsets.h clean rule currently in xen/Makefile. > >>> > >>>> Nevertheless, if there's general agreement that keeping the file > >>>> there is better, I'd make the change and simply ignore my unhappy > >>>> feelings about it. > >>> > >>> I don't have a strong opinion, it just feels weird to have this IMO > >>> stray asm-offsets.s outside of it's arch directory, taking into > >>> account that we have asm-offsets.h generated from xen/Makefile into an > >>> arch specific directory already as a precedent in that makefile. > >> > >> Well, asm-offsets.h generation doesn't involve the compiler, hence > >> no .*.d files get generated and want including later. For > >> asm-offsets.s to have dependencies properly honored, if we > >> generated it in xen/arch/<arch>, .asm-offsets.d would also end up > >> there, and hence including of it would need separately taking care > >> of. > > > > I'm not sure I understand what do you mean with inclusion need taking > > care of separately. Isn't it expected for .d file to reside in the > > same directory as the output, > > Yes, ... > > > and hence picked up automatically? > > ... and hence they _wouldn't_ be picked up automatically while > building in xen/ if the .s file got created in xen/arch/<arch>/. Hm, so that would prevent re-building the target when the dependencies changed as the .d file being in the arch directory would attempt the rebuild from there instead of the top level xen/? I guess the alternative would be to force a rebuild of the target every time, in order to not depend on the .d logic? Thanks, Roger.
next prev parent reply other threads:[~2021-04-27 13:32 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-01 8:33 Jan Beulich 2021-04-01 15:05 ` Julien Grall 2021-04-01 15:29 ` Jan Beulich 2021-04-15 9:50 ` Ping: " Jan Beulich 2021-04-20 15:29 ` Roger Pau Monné 2021-04-20 15:47 ` Jan Beulich 2021-04-20 16:20 ` Roger Pau Monné 2021-04-21 14:09 ` Jan Beulich 2021-04-27 9:05 ` Roger Pau Monné 2021-04-27 12:30 ` Jan Beulich 2021-04-27 13:31 ` Roger Pau Monné [this message] 2021-04-27 13:40 ` Jan Beulich 2021-04-27 14:13 ` Roger Pau Monné 2021-04-29 9:18 ` Ping: " Jan Beulich 2021-05-10 17:43 ` Julien Grall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YIgSNRq2w7KSSaiD@Air-de-Roger \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] build: centralize / unify asm-offsets generation' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).