From: Anthony PERARD <anthony.perard@citrix.com>
To: Nick Rosbrook <rosbrookn@gmail.com>
Cc: <xen-devel@lists.xenproject.org>, <george.dunlap@citrix.com>,
"Nick Rosbrook" <rosbrookn@ainfosec.com>,
Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [RFC v2 6/7] libxl: implement device add/remove/destroy functions generation
Date: Tue, 4 May 2021 16:02:55 +0100 [thread overview]
Message-ID: <YJFiH9dFdlq2l87k@perard> (raw)
In-Reply-To: <5986715fe1d677533b67c06e9561cd716716d46a.1614734296.git.rosbrookn@ainfosec.com>
On Tue, Mar 02, 2021 at 08:46:18PM -0500, Nick Rosbrook wrote:
> +def libxl_func_define_device_add(func):
> + s = ''
> +
> + return_type = func.return_type.typename
> + if isinstance(func.return_type, idl.Enumeration):
> + return_type = idl.integer.typename
> +
> + params = ', '.join([ ty.make_arg(name) for (name,ty) in func.params ])
> +
> + s += '{0} {1}({2})\n'.format(return_type, func.name, params)
> + s += '{\n'
> + s += '\tAO_CREATE(ctx, domid, ao_how);\n'
> + s += '\tlibxl__ao_device *aodev;\n\n'
> + s += '\tGCNEW(aodev);\n'
> + s += '\tlibxl__prepare_ao_device(ao, aodev);\n'
> + s += '\taodev->action = LIBXL__DEVICE_ACTION_ADD;\n'
> + s += '\taodev->callback = device_addrm_aocomplete;\n'
> + s += '\taodev->update_json = true;\n'
> + s += '\tlibxl__{0}(egc, domid, type, aodev);\n\n'.format(func.rawname)
> + s += '\treturn AO_INPROGRESS;\n'
> + s += '}\n'
That's kind of hard to read, I think we could use python's triple-quote
(or triple double-quote) ''' or """ to have a multi-line string and
remove all those \t \n
Something like:
s = '''
{ret} {func}({params})
{{
return ERROR_FAIL;
libxl__{rawname}(gc);
}}
'''.format(ret=return_type, func=func.name, params=params,
rawname=func.rawname)
That would produce some extra indentation in the generated C file, but
that doesn't matter to me. They could be removed with textwrap.dedent()
if needed.
Thanks,
--
Anthony PERARD
next prev parent reply other threads:[~2021-05-04 15:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 1:46 [RFC v2 0/7] add function support to IDL Nick Rosbrook
2021-03-03 1:46 ` [RFC v2 1/7] libxl: remove extra whitespace from gentypes.py Nick Rosbrook
2021-05-04 14:39 ` Anthony PERARD
2021-03-03 1:46 ` [RFC v2 2/7] libxl: add Function class to IDL Nick Rosbrook
2021-03-03 1:46 ` [RFC v2 3/7] libxl: add PASS_BY_CONST_REFERENCE to idl Nick Rosbrook
2021-03-03 1:46 ` [RFC v2 4/7] libxl: add DeviceFunction classes to IDL Nick Rosbrook
2021-03-03 1:46 ` [RFC v2 5/7] libxl: add device function definitions to libxl_types.idl Nick Rosbrook
2021-05-04 15:43 ` Anthony PERARD
2021-05-04 17:26 ` Nick Rosbrook
2021-03-03 1:46 ` [RFC v2 6/7] libxl: implement device add/remove/destroy functions generation Nick Rosbrook
2021-05-04 15:02 ` Anthony PERARD [this message]
2021-05-04 17:29 ` Nick Rosbrook
2021-03-03 1:46 ` [RFC v2 7/7] libxl: replace LIBXL_DEFINE_DEVICE* macro usage with generated code Nick Rosbrook
2021-03-03 9:48 ` [RFC v2 0/7] add function support to IDL Ian Jackson
2021-03-03 13:41 ` Nick Rosbrook
2021-04-21 21:28 ` Nick Rosbrook
2021-05-04 15:46 ` Anthony PERARD
2021-05-04 17:31 ` Nick Rosbrook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJFiH9dFdlq2l87k@perard \
--to=anthony.perard@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=rosbrookn@ainfosec.com \
--cc=rosbrookn@gmail.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).