From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH] x86/p2m: please Clang after making certain parts HVM-only
Date: Wed, 5 May 2021 10:01:16 +0200 [thread overview]
Message-ID: <YJJQzJxro7ZnpFuR@Air-de-Roger> (raw)
In-Reply-To: <cfac6284-d4ec-af2f-6be4-c114c7c10009@suse.com>
On Wed, May 05, 2021 at 09:07:30AM +0200, Jan Beulich wrote:
> Move a few #ifdef-s, to account for diagnostics like
>
> p2m.c:549:1: error: non-void function does not return a value in all control paths [-Werror,-Wreturn-type]
There's also __builtin_unreachable, but that would get even messier,
and I'm not sure it's supported by all gcc versions we care about.
> which appear despite paging_mode_translate() resolving to constant
> "false" when !HVM. All of the affected functions are intended to become
> fully HVM-only anyway, with their non-translated stub handling split off
> elsewhere.
>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Fixes: 8d012d3ddffc ("x86/p2m: {get,set}_entry hooks and p2m-pt.c are HVM-only")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
prev parent reply other threads:[~2021-05-05 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 7:07 [PATCH] x86/p2m: please Clang after making certain parts HVM-only Jan Beulich
2021-05-05 8:01 ` Roger Pau Monné [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJJQzJxro7ZnpFuR@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).