From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B30C49EB7 for ; Mon, 21 Jun 2021 16:19:48 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2570061380 for ; Mon, 21 Jun 2021 16:19:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2570061380 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.145618.267790 (Exim 4.92) (envelope-from ) id 1lvMeA-0005Hv-39; Mon, 21 Jun 2021 16:19:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 145618.267790; Mon, 21 Jun 2021 16:19:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lvMeA-0005Ho-0C; Mon, 21 Jun 2021 16:19:38 +0000 Received: by outflank-mailman (input) for mailman id 145618; Mon, 21 Jun 2021 16:19:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lvMe8-0005Hi-Bm for xen-devel@lists.xenproject.org; Mon, 21 Jun 2021 16:19:36 +0000 Received: from mail-qk1-x72d.google.com (unknown [2607:f8b0:4864:20::72d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 81a0a5fb-9272-4fbe-9261-c797ce43203a; Mon, 21 Jun 2021 16:19:35 +0000 (UTC) Received: by mail-qk1-x72d.google.com with SMTP id w21so18109011qkb.9 for ; Mon, 21 Jun 2021 09:19:35 -0700 (PDT) Received: from FED-nrosbr-BE.crux.rad.ainfosec.com (209-217-208-226.northland.net. [209.217.208.226]) by smtp.gmail.com with ESMTPSA id 9sm3813425qkj.123.2021.06.21.09.19.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jun 2021 09:19:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81a0a5fb-9272-4fbe-9261-c797ce43203a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=V7QToCOyN8s1F99hOvuuZdcA0iA3LZFYKSsCWLq+9vg=; b=MxG9drfY/W60SkzgHIcpFgyX91L4nLM/SJsK9B5lwHCthIYMFSXm9vgCCW04m8XQW7 fVHR43tgexLKh45Lrx/WRtdWGvJ5GdgS1kOmN41iPHldjuaAGzeC2v4IdqHorQ3t0fMb c4dOTZQewtVS6qV9gZOigK4g5jxopAkS9Q7hoxcj8FoSkBbomuJJHGzOBTwYu7xJcc1W HF87Y53vZVjxEOICDKVz90M9PGMuv6DgKnhpHBla8KKo9nXhRopxtOrP406BCoY7uI1l o/Z43RF0UXcb1YzRDDm6HvL/3BMVGWQFyh8bQiHgB5c41iW+JvTf1O4yW7wwlegJVzSg zY6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=V7QToCOyN8s1F99hOvuuZdcA0iA3LZFYKSsCWLq+9vg=; b=uWR7SNuXbStjo5oCDhrf03N5WQqMALGUuE12v9i4AcqVKZ66gEEwJwZp325/yAECzn zSai1//1SZAyT0MkM+fucHKcr9iS+utwV+mm3GWVKRtRgTTtEs0PAZarp/A2bWrLBtIM Mrqr8ZehF41SppqZRsRiAFrLW5KxAXDVsoGZPrIMXWAliYBb+V66jLj8/dC8cdD7KMWE sIf31enCa6Yz16TZNzeCKe1aSZfpG6cd8gVr7VPqAtemmz/UWbIa4JpofVYL2L9fKd1v cRPmCNhkepApPTh4aKHDLaQN8AlOJe6+pinqWGTQ/0YBCPokBw57lin/CCD92EP70s9e LVIw== X-Gm-Message-State: AOAM533trZmTsqjIEBdG1Zfca2Fbo1CIy/TLmVH+kllKQ77ko3ftncMf rF34NM8TXyGcEUCzLF0MF00= X-Google-Smtp-Source: ABdhPJzxDU7XfQCxb84tsK3YQm6WF/kI6dXosXRxwhKPTYeTeHjB7kuxbpezXRCsv1X5T1pzuvEKOw== X-Received: by 2002:ae9:c115:: with SMTP id z21mr23962335qki.458.1624292374992; Mon, 21 Jun 2021 09:19:34 -0700 (PDT) Date: Mon, 21 Jun 2021 12:19:31 -0400 From: Nick Rosbrook To: George Dunlap Cc: xen-devel , Nick Rosbrook , Ian Jackson , Wei Liu Subject: Re: [RESEND PATCH 00/12] golang/xenlight: domain life cycle support Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jun 21, 2021 at 03:53:39PM +0000, George Dunlap wrote: > > > > On May 24, 2021, at 9:36 PM, Nick Rosbrook wrote: > > > > The primary goal of this patch series is to allow users of the xenlight > > package to manage a full domain life cycle. In particular, it provides > > support for receiving domain death events so that domain shutdown, > > reboot, destroy, etc. can be handled. And, it addresses issues found > > when using the package to boot domains with various configurations. > > > > These patches address several things (e.g. bug fixes, code style, > > conveniences, new wrapper functions), but are all work towards the final > > goal of allowing a package user to manage a full domain life cycle. > > > > Nick Rosbrook (12): > > OK, I’ve checked in the following patches: (1, 2, 4, 5, 6, 9, 10, 11): > > > golang/xenlight: update generated code > > golang/xenlight: fix StringList toC conversion > > golang/xenlight: export keyed union interface types > > golang/xenlight: use struct pointers in keyed union fields > > golang/xenlight: rename Ctx receivers to ctx > > > golang/xenlight: add DomainDestroy wrapper > > golang/xenlight: add SendTrigger wrapper > > golang/xenlight: do not negate ret when converting to Error > > The following have not been checked in due outsanding review comments (patches 3, 7, 12), or because they depend on a patch not being checked in (patch 8): > > > golang/xenlight: fix string conversion in generated toC functions > > golang/xenlight: add logging conveniences for within xenlight > > golang/xenlight: add functional options to configure Context > > golang/xenlight: add NotifyDomainDeath method to Context > Thanks! I am planning on addressing patch 12 comments later today. -NR