From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 2/6] x86/APIC: drop clustered_apic_check() hook
Date: Mon, 8 Nov 2021 12:02:40 +0100 [thread overview]
Message-ID: <YYkD0J9xSno3aO0i@Air-de-Roger> (raw)
In-Reply-To: <7e2c8dd5-e20d-5678-1fad-1b79fd8e06e4@suse.com>
On Fri, Nov 05, 2021 at 01:34:12PM +0100, Jan Beulich wrote:
> The hook functions have been empty forever (x2APIC) or issuing merely a
> printk() for a long time (xAPIC). Since that printk() is (a) generally
> useful (i.e. also in the x2APIC case) and (b) would better only be
> issued once the final APIC driver to use was determined, move (and
> generalize) it into connect_bsp_APIC().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> v2: New.
>
> --- a/xen/arch/x86/acpi/boot.c
> +++ b/xen/arch/x86/acpi/boot.c
> @@ -674,9 +674,7 @@ static void __init acpi_process_madt(voi
> error = acpi_parse_madt_ioapic_entries();
> if (!error) {
> acpi_ioapic = true;
> -
> smp_found_config = true;
> - clustered_apic_check();
> }
> }
> if (error == -EINVAL) {
> --- a/xen/arch/x86/apic.c
> +++ b/xen/arch/x86/apic.c
> @@ -243,6 +243,12 @@ void __init connect_bsp_APIC(void)
> outb(0x70, 0x22);
> outb(0x01, 0x23);
> }
> +
> + printk("Enabling APIC mode: %s. Using %d I/O APICs\n",
I don't think it makes sense to prefix APIC with 'x' or 'x2' here, as
we already print the APIC mode elsewhere?
> + !INT_DEST_MODE ? "Physical"
> + : init_apic_ldr == init_apic_ldr_flat ? "Flat"
> + : "Clustered",
> + nr_ioapics);
> enable_apic_mode();
This also seem to be completely unneeded? I guess it would be cleaned
in a further patch.
Thanks, Roger.
next prev parent reply other threads:[~2021-11-08 11:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 12:30 [PATCH v2 0/6] x86: ACPI / APIC / IOMMU interaction Jan Beulich
2021-11-05 12:32 ` [PATCH v2 1/6][4.16?] x86/x2APIC: defer probe until after IOMMU ACPI table parsing Jan Beulich
2021-11-05 15:38 ` Roger Pau Monné
2021-11-05 15:47 ` Ian Jackson
2021-11-08 7:44 ` Jan Beulich
2021-11-08 15:04 ` Ian Jackson
2021-11-08 15:13 ` Jan Beulich
2021-11-16 15:19 ` [PATCH v2 1/6][4.16?] x86/x2APIC: defer probe until after IOMMU ACPI table parsing [and 2 more messages] Ian Jackson
2021-11-08 7:40 ` [PATCH v2 1/6][4.16?] x86/x2APIC: defer probe until after IOMMU ACPI table parsing Jan Beulich
2021-11-08 9:36 ` Roger Pau Monné
2021-11-08 9:54 ` Jan Beulich
2021-11-05 12:34 ` [PATCH v2 2/6] x86/APIC: drop clustered_apic_check() hook Jan Beulich
2021-11-08 11:02 ` Roger Pau Monné [this message]
2021-11-08 11:17 ` Jan Beulich
2021-11-05 12:34 ` [PATCH v2 3/6] x86/APIC: drop {acpi_madt,mps}_oem_check() hooks Jan Beulich
2021-11-05 12:34 ` [PATCH v2 4/6] x86/APIC: drop probe_default() Jan Beulich
2021-11-05 12:35 ` [PATCH v2 5/6] x86/APIC: rename cmdline_apic Jan Beulich
2021-11-05 12:35 ` [PATCH v2 6/6] x86/ACPI: drop dead interpreter-related code Jan Beulich
2021-11-08 11:40 ` [PATCH v2.1 1/6][4.16?] x86/x2APIC: defer probe until after IOMMU ACPI table parsing Jan Beulich
2021-11-08 11:54 ` Roger Pau Monné
2021-11-15 12:06 ` Jan Beulich
2021-11-15 14:31 ` [PATCH v2.2 " Jan Beulich
2021-11-15 15:07 ` Roger Pau Monné
2021-11-15 16:10 ` Jan Beulich
2021-11-16 11:44 ` Roger Pau Monné
2021-11-16 12:09 ` [PATCH v2 0/6] x86: ACPI / APIC / IOMMU interaction Andrew Cooper
2021-11-16 14:20 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYkD0J9xSno3aO0i@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).