From: Anthony PERARD <anthony.perard@citrix.com>
To: Michal Orzel <michal.orzel@amd.com>
Cc: <xen-devel@lists.xenproject.org>,
Doug Goldstein <cardoe@cardoe.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 4/9] automation: Add Arm containers to containerize script
Date: Fri, 23 Sep 2022 14:56:31 +0100 [thread overview]
Message-ID: <Yy27D62mvY3nQENI@perard.uk.xensource.com> (raw)
In-Reply-To: <20220922134058.1410-5-michal.orzel@amd.com>
On Thu, Sep 22, 2022 at 03:40:53PM +0200, Michal Orzel wrote:
> Script automation/scripts/containerize makes it easy to build Xen within
> predefined containers from gitlab container registry. However, it is
> currently not possible to use it with Arm containers because they are not
> listed in the script. Populate the necessary entries.
FYI, those entry are just helper/shortcut/aliases, you can use any
arbitrary container with the script, it just more annoying.
Your patch here allows to write:
CONTAINER=unstable-arm64v8 automation/scripts/containerize
but you could write the following instead, for the same result:
CONTAINER=registry.gitlab.com/xen-project/xen/debian:unstable-arm64v8 automation/scripts/containerize
I wonder if the script could select the right container base on the
architecture of the host, because "alpine" and "alpine-arm64v8" will not
both work on the same machine. It might be nice to just choose "alpine"
and the script would select the x86 or arm container automagically. Just
an idea, no need to do anything about it.
(patch is fine otherwise, just the patch description is a bit
misleading)
Cheers,
--
Anthony PERARD
next prev parent reply other threads:[~2022-09-23 13:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 13:40 [PATCH 0/9] GitLab CI cleanup & improvements for Arm Michal Orzel
2022-09-22 13:40 ` [PATCH 1/9] automation: Use custom build jobs when extra config options are needed Michal Orzel
2022-09-22 21:40 ` Stefano Stabellini
2022-09-23 1:27 ` Henry Wang
2022-09-23 7:28 ` Michal Orzel
2022-09-23 22:10 ` Stefano Stabellini
2022-09-22 13:40 ` [PATCH 2/9] automation: Add randconfig build jobs for arm64 alpine container Michal Orzel
2022-09-22 21:42 ` Stefano Stabellini
2022-09-23 7:33 ` Michal Orzel
2022-09-22 13:40 ` [PATCH 3/9] automation: Add debug versions of Arm tests Michal Orzel
2022-09-22 21:53 ` Stefano Stabellini
2022-09-23 7:44 ` Michal Orzel
2022-09-23 22:11 ` Stefano Stabellini
2022-09-22 13:40 ` [PATCH 4/9] automation: Add Arm containers to containerize script Michal Orzel
2022-09-22 22:03 ` Stefano Stabellini
2022-09-23 13:56 ` Anthony PERARD [this message]
2022-09-23 16:54 ` Michal Orzel
2022-09-23 22:23 ` Stefano Stabellini
2022-09-26 13:33 ` Anthony PERARD
2022-09-22 13:40 ` [PATCH 5/9] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder Michal Orzel
2022-09-22 22:13 ` Stefano Stabellini
2022-09-23 8:04 ` Michal Orzel
2022-09-23 22:12 ` Stefano Stabellini
2022-09-22 13:40 ` [PATCH 6/9] automation: qemu-alpine-arm64: Cleanup and fixes Michal Orzel
2022-09-22 22:17 ` Stefano Stabellini
2022-09-22 13:40 ` [PATCH 7/9] automation: Rename qemu-smoke-arm64.sh to qemu-smoke-dom0less-arm64.sh Michal Orzel
2022-09-22 22:18 ` Stefano Stabellini
2022-09-22 13:40 ` [PATCH 8/9] automation: Rename qemu-alpine-arm64.sh to qemu-smoke-dom0-arm64.sh Michal Orzel
2022-09-22 22:18 ` Stefano Stabellini
2022-09-22 13:40 ` [PATCH 9/9] automation: Rename qemu-smoke-arm32.sh to qemu-smoke-dom0-arm32.sh Michal Orzel
2022-09-22 22:18 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy27D62mvY3nQENI@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=cardoe@cardoe.com \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).