From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-4.12 v2 05/17] xen/arm: p2m: Handle translation fault in get_page_from_gva Date: Wed, 5 Dec 2018 10:03:05 +0000 Message-ID: References: <20181204202651.8836-1-julien.grall@arm.com> <20181204202651.8836-6-julien.grall@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gUU1N-0005GD-2m for xen-devel@lists.xenproject.org; Wed, 05 Dec 2018 10:03:09 +0000 In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org CgpPbiAwNC8xMi8yMDE4IDIzOjU5LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6Cj4gT24gVHVl LCA0IERlYyAyMDE4LCBKdWxpZW4gR3JhbGwgd3JvdGU6Cj4+IEEgZm9sbG93LXVwIHBhdGNoIHdp bGwgcmUtcHVycG9zZSB0aGUgdmFsaWQgYml0IG9mIExQQUUgZW50cmllcyB0bwo+PiBnZW5lcmF0 ZSBmYXVsdCBldmVuIG9uIGVudHJ5IGNvbnRhaW5pbmcgdmFsaWQgaW5mb3JtYXRpb24uCj4+Cj4+ IFRoaXMgbWVhbnMgdGhhdCB3aGVuIHRyYW5zbGF0aW5nIGEgZ3Vlc3QgVkEgdG8gZ3Vlc3QgUEEg KGUuZyBJUEEpIHdpbGwKPj4gZmFpbCBpZiB0aGUgU3RhZ2UtMiBlbnRyaWVzIHVzZWQgaGF2ZSB0 aGUgdmFsaWQgYml0IHVuc2V0LiBCZWNhdXNlIG9mCj4+IHRoYXQsIHdlIG5lZWQgdG8gZmFsbGJh Y2sgdG8gd2FsayB0aGUgcGFnZS10YWJsZSBpbiBzb2Z0d2FyZSB0byBjaGVjawo+PiB3aGV0aGVy IHRoZSBmYXVsdCB3YXMgZXhwZWN0ZWQuCj4+Cj4+IFRoaXMgcGF0Y2ggYWRkcyB0aGUgc29mdHdh cmUgcGFnZS10YWJsZSB3YWxrIG9uIGFsbCB0aGUgdHJhbnNsYXRpb24KPj4gZmF1bHQuIEl0IHdv dWxkIGJlIHBvc3NpYmxlIGluIHRoZSBmdXR1cmUgdG8gYXZvaWQgcG9pbnRsZXNzIHdhbGsgd2hl bgo+PiB0aGUgZmF1bHQgaW4gUEFSX0VMMSBpcyBub3QgYSB0cmFuc2xhdGlvbiBmYXVsdC4KPj4K Pj4gU2lnbmVkLW9mZi1ieTogSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4KPj4K Pj4gLS0tCj4+Cj4+IFRoZXJlIGFyZSBhIGNvdXBsZSBvZiBUT0RPIGluIHRoZSBjb2RlLiBUaGV5 IGFyZSBjbGVhbi11cCBhbmQgcGVyZm9ybWFuY2UKPj4gaW1wcm92ZW1lbnQgKGUuZyB3aGVuIHRo ZSBmYXVsdCBjYW5ub3QgYmUgaGFuZGxlZCkgdGhhdCBjb3VsZCBiZSBkZWxheWVkIGFmdGVyCj4+ IHRoZSBzZXJpZXMgaGFzIGJlZW4gbWVyZ2VkLgo+Pgo+PiAgICAgIENoYW5nZXMgaW4gdjI6Cj4+ ICAgICAgICAgIC0gQ2hlY2sgc3RhZ2UtMiBwZXJtaXNzaW9uIGR1cmluZyBzb2Z0d2FyZSBsb29r dXAKPj4gICAgICAgICAgLSBGaXggdHlwb2VzCj4+IC0tLQo+PiAgIHhlbi9hcmNoL2FybS9wMm0u YyB8IDY2ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0t LS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCA1OSBpbnNlcnRpb25zKCspLHNob3VsZCAgNyBkZWxl dGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9wMm0uYyBiL3hlbi9hcmNo L2FybS9wMm0uYwo+PiBpbmRleCA0N2I1NGM3OTJlLi4zOTY4MGVlYjZlIDEwMDY0NAo+PiAtLS0g YS94ZW4vYXJjaC9hcm0vcDJtLmMKPj4gKysrIGIveGVuL2FyY2gvYXJtL3AybS5jCj4+IEBAIC02 LDYgKzYsNyBAQAo+PiAgIAo+PiAgICNpbmNsdWRlIDxhc20vZXZlbnQuaD4KPj4gICAjaW5jbHVk ZSA8YXNtL2ZsdXNodGxiLmg+Cj4+ICsjaW5jbHVkZSA8YXNtL2d1ZXN0X3dhbGsuaD4KPj4gICAj aW5jbHVkZSA8YXNtL3BhZ2UuaD4KPj4gICAKPj4gICAjZGVmaW5lIE1BWF9WTUlEXzhfQklUICAo MVVMIDw8IDgpCj4+IEBAIC0xNDMwLDYgKzE0MzEsOCBAQCBzdHJ1Y3QgcGFnZV9pbmZvICpnZXRf cGFnZV9mcm9tX2d2YShzdHJ1Y3QgdmNwdSAqdiwgdmFkZHJfdCB2YSwKPj4gICAgICAgc3RydWN0 IHBhZ2VfaW5mbyAqcGFnZSA9IE5VTEw7Cj4+ICAgICAgIHBhZGRyX3QgbWFkZHIgPSAwOwo+PiAg ICAgICB1aW50NjRfdCBwYXI7Cj4+ICsgICAgbWZuX3QgbWZuOwo+PiArICAgIHAybV90eXBlX3Qg dDsKPj4gICAKPj4gICAgICAgLyoKPj4gICAgICAgICogWFhYOiBUbyBzdXBwb3J0IGEgZGlmZmVy ZW50IHZDUFUsIHdlIHdvdWxkIG5lZWQgdG8gbG9hZCB0aGUKPj4gQEAgLTE0NDYsOCArMTQ0OSwy OSBAQCBzdHJ1Y3QgcGFnZV9pbmZvICpnZXRfcGFnZV9mcm9tX2d2YShzdHJ1Y3QgdmNwdSAqdiwg dmFkZHJfdCB2YSwKPj4gICAgICAgcGFyID0gZ3ZpcnRfdG9fbWFkZHIodmEsICZtYWRkciwgZmxh Z3MpOwo+PiAgICAgICBwMm1fcmVhZF91bmxvY2socDJtKTsKPj4gICAKPj4gKyAgICAvKgo+PiAr ICAgICAqIGd2aXJ0X3RvX21hZGRyIG1heSBmYWlsIGlmIHRoZSBlbnRyeSBkb2VzIG5vdCBoYXZl IHRoZSB2YWxpZCBiaXQKPj4gKyAgICAgKiBzZXQuIEZhbGxiYWNrIHRvIHRoZSBzZWNvbmQgbWV0 aG9kOgo+PiArICAgICAqICAxKSBUcmFuc2xhdGUgdGhlIFZBIHRvIElQQSB1c2luZyBzb2Z0d2Fy ZSBsb29rdXAgLT4gU3RhZ2UtMSBwYWdlLXRhYmxlCj4+ICsgICAgICogIG1heSBub3QgYmUgYWNj ZXNzaWJsZSBiZWNhdXNlIHRoZSBzdGFnZS0yIGVudHJpZXMgbWF5IGhhdmUgdmFsaWQKPj4gKyAg ICAgKiAgYml0IHVuc2V0Lgo+PiArICAgICAqICAyKSBTb2Z0d2FyZSBsb29rdXAgb2YgdGhlIE1G Tgo+PiArICAgICAqCj4+ICsgICAgICogTm90ZSB0aGF0IHdoZW4gbWVtYWNjZXNzIGlzIGVuYWJs ZWQsIHdlIGluc3RlYWQgY2FsbCBkaXJlY3RseQo+PiArICAgICAqIHAybV9tZW1fYWNjZXNzX2No ZWNrX2FuZF9nZXRfcGFnZSguLi4pLiBCZWNhdXNlIHRoZSBmdW5jdGlvbiBpcyBhCj4+ICsgICAg ICogYSB2YXJpYW50IG9mIHRoZSBtZXRob2RzIGRlc2NyaWJlZCBhYm92ZSwgaXQgd2lsbCBiZSBh YmxlIHRvCj4+ICsgICAgICogaGFuZGxlIGVudHJpZXMgd2l0aCB2YWxpZCBiaXQgdW5zZXQuCj4+ ICsgICAgICoKPj4gKyAgICAgKiBUT0RPOiBJbnRlZ3JhdGUgbW9yZSBuaWNlbHkgbWVtYWNjZXNz IHdpdGggdGhlIHJlc3Qgb2YgdGhlCj4+ICsgICAgICogZnVuY3Rpb24uCj4+ICsgICAgICogVE9E TzogVXNlIHRoZSBmYXVsdCBlcnJvciBpbiBQQVJfRUwxIHRvIGF2b2lkIHBvaW50bGVzcwo+PiAr ICAgICAqICB0cmFuc2xhdGlvbi4KPj4gKyAgICAgKi8KPj4gICAgICAgaWYgKCBwYXIgKQo+PiAg ICAgICB7Cj4+ICsgICAgICAgIHBhZGRyX3QgaXBhOwo+PiArICAgICAgICB1bnNpZ25lZCBpbnQg czFfcGVybXM7Cj4+ICsKPj4gICAgICAgICAgIC8qCj4+ICAgICAgICAgICAgKiBXaGVuIG1lbWFj Y2VzcyBpcyBlbmFibGVkLCB0aGUgdHJhbnNsYXRpb24gR1ZBIHRvIE1BRERSIG1heQo+PiAgICAg ICAgICAgICogaGF2ZSBmYWlsZWQgYmVjYXVzZSBvZiBhIHBlcm1pc3Npb24gZmF1bHQuCj4+IEBA IC0xNDU1LDIwICsxNDc5LDQ4IEBAIHN0cnVjdCBwYWdlX2luZm8gKmdldF9wYWdlX2Zyb21fZ3Zh KHN0cnVjdCB2Y3B1ICp2LCB2YWRkcl90IHZhLAo+PiAgICAgICAgICAgaWYgKCBwMm0tPm1lbV9h Y2Nlc3NfZW5hYmxlZCApCj4+ICAgICAgICAgICAgICAgcmV0dXJuIHAybV9tZW1fYWNjZXNzX2No ZWNrX2FuZF9nZXRfcGFnZSh2YSwgZmxhZ3MsIHYpOwo+PiAgIAo+PiAtICAgICAgICBkcHJpbnRr KFhFTkxPR19HX0RFQlVHLAo+PiAtICAgICAgICAgICAgICAgICIlcHY6IGd2aXJ0X3RvX21hZGRy IGZhaWxlZCB2YT0lIyJQUkl2YWRkciIgZmxhZ3M9MHglbHggcGFyPSUjIlBSSXg2NCJcbiIsCj4+ IC0gICAgICAgICAgICAgICAgdiwgdmEsIGZsYWdzLCBwYXIpOwo+PiAtICAgICAgICByZXR1cm4g TlVMTDsKPj4gKyAgICAgICAgLyoKPj4gKyAgICAgICAgICogVGhlIHNvZnR3YXJlIHN0YWdlLTEg dGFibGUgd2FsayBjYW4gc3RpbGwgZmFpbCwgZS5nLCBpZiB0aGUKPj4gKyAgICAgICAgICogR1ZB IGlzIG5vdCBtYXBwZWQuCj4+ICsgICAgICAgICAqLwo+PiArICAgICAgICBpZiAoICFndWVzdF93 YWxrX3RhYmxlcyh2LCB2YSwgJmlwYSwgJnMxX3Blcm1zKSApCj4+ICsgICAgICAgIHsKPj4gKyAg ICAgICAgICAgIGRwcmludGsoWEVOTE9HX0dfREVCVUcsCj4+ICsgICAgICAgICAgICAgICAgICAg ICIlcHY6IEZhaWxlZCB0byB3YWxrIHBhZ2UtdGFibGUgdmEgJSMiUFJJdmFkZHIiXG4iLCB2LCB2 YSk7Cj4+ICsgICAgICAgICAgICByZXR1cm4gTlVMTDsKPj4gKyAgICAgICAgfQo+PiArCj4+ICsg ICAgICAgIG1mbiA9IHAybV9sb29rdXAoZCwgZ2FkZHJfdG9fZ2ZuKGlwYSksICZ0KTsKPj4gKyAg ICAgICAgaWYgKCBtZm5fZXEoSU5WQUxJRF9NRk4sIG1mbikgfHwgIXAybV9pc19yYW0odCkgKQo+ PiArICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4+ICsKPj4gKyAgICAgICAgLyoKPj4gKyAgICAg ICAgICogQ2hlY2sgcGVybWlzc2lvbiB0aGF0IGFyZSBhc3N1bWVkIGJ5IHRoZSBjYWxsZXIuIEZv ciBpbnN0YW5jZQo+PiArICAgICAgICAgKiBpbiBjYXNlIG9mIGd1ZXN0Y29weSwgdGhlIGNhbGxl ciBhc3N1bWVzIHRoYXQgdGhlIHRyYW5zbGF0ZWQKPj4gKyAgICAgICAgICogcGFnZSBjYW4gYmUg YWNjZXNzZWQgd2l0aCB0aGUgcmVxdWVzdGVkIHBlcm1pc3Npb25zLiBJZiB0aGlzCj4+ICsgICAg ICAgICAqIGlzIG5vdCB0aGUgY2FzZSwgd2Ugc2hvdWxkIGZhaWwuCj4+ICsgICAgICAgICAqCj4+ ICsgICAgICAgICAqIFBsZWFzZSBub3RlIHRoYXQgd2UgZG8gbm90IGNoZWNrIGZvciB0aGUgR1Yy TV9FWEVDCj4+ICsgICAgICAgICAqIHBlcm1pc3Npb24uIFRoaXMgaXMgZmluZSBiZWNhdXNlIHRo ZSBoYXJkd2FyZS1iYXNlZCB0cmFuc2xhdGlvbgo+PiArICAgICAgICAgKiBpbnN0cnVjdGlvbiBk b2VzIG5vdCB0ZXN0IGZvciBleGVjdXRlIHBlcm1pc3Npb25zLgo+PiArICAgICAgICAgKi8KPj4g KyAgICAgICAgaWYgKCAoZmxhZ3MgJiBHVjJNX1dSSVRFKSAmJiAhKHMxX3Blcm1zICYgR1YyTV9X UklURSkgKQo+PiArICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4+ICsKPj4gKyAgICAgICAgaWYg KCAoZmxhZ3MgJiBHVjJNX1dSSVRFKSAmJiB0ICE9IHAybV9yYW1fcncgKQo+PiArICAgICAgICAg ICAgcmV0dXJuIE5VTEw7Cj4gCj4gVGhlIHBhdGNoIGxvb2tzIGdvb2QgZW5vdWdoIG5vdy4gT25l IHF1ZXN0aW9uOiBpcyBpdCBhIHJlcXVpcmVtZW50IHRoYXQKPiB0aGUgcGFnZSB3ZSBhcmUgdHJ5 aW5nIHRvIHRyYW5zbGF0ZSBpcyBvZiB0eXBlIHAybV9yYW1fKj8gQ291bGQKPiBnZXRfcGFnZV9m cm9tX2d2YSBiZSBnZW51aW5lbHkgY2FsbGVkIHBhc3NpbmcgYSBwYWdlIG9mIGEgZGlmZmVyZW50 Cj4ga2luZCwgc3VjaCBhcyBwMm1fbW1pb19kaXJlY3RfKiBvciBwMm1fbWFwX2ZvcmVpZ24/IFRv ZGF5LCBpdCBpcyBub3QgdGhlCj4gY2FzZSwgYnV0IEkgd29uZGVyIGlmIGl0IGlzIHNvbWV0aGlu ZyB3ZSB3YW50IHRvIGNvbnNpZGVyPwoKVGhpcyBmdW5jdGlvbiBjYW4gb25seSBwb3NzaWJseSB3 b3JrIHdpdGggcDJtX3JhbV8qIGJlY2F1c2Ugb2YgdGhlIGdldF9wYWdlKC4uLikgCmJlbG93LCBp bmRlZWQgdGhlIHBhZ2Ugc2hvdWxkIGJlbG9uZyB0byB0aGUgZG9tYWluLgoKRWZmZWN0aXZlbHkg dGhpcyBmdW5jdGlvbiB3aWxsIG9ubHkgYmUgdXNlZCBmb3IgaHlwZXJjYWxsIGFzIHlvdSB1c2Ug YSB2aXJ0dWFsIAphZGRyZXNzLiBJIHF1ZXN0aW9uIHRoZSB2YWx1ZSBvZiBhbGxvd2luZyBhIGd1 ZXN0IHRvIGRvIGEgaHlwZXJjYWxsIHdpdGggdGhlIApkYXRhIGJhY2tlZCBpbiBhbnkgb3RoZXIg bWVtb3JpZXMgdGhhbiBndWVzdCBSQU0uIEZvciB0aGUgZm9yZWlnbiBtYXBwaW5nLCB0aGlzIApj b3VsZCBwb3RlbnRpYWxseSBlbmQgdXAgd2l0aCBhIGxlYWthZ2UuCgpDaGVlcnMsCgotLSAKSnVs aWVuIEdyYWxsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpo dHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs