From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH] x86/ucode: log blob date also for AMD
Date: Thu, 1 Apr 2021 10:28:04 +0200 [thread overview]
Message-ID: <a236ef77-e6ef-5cbe-60a0-49c8dcd9a208@suse.com> (raw)
Like Intel, AMD also records the date in their blobs. The field was
merely misnamed as "data_code" so far; this was perhaps meant to be
"date_code". Split it into individual fields, just like we did for Intel
some time ago, and extend the message logged after a successful update.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/cpu/microcode/amd.c
+++ b/xen/arch/x86/cpu/microcode/amd.c
@@ -33,7 +33,9 @@ struct equiv_cpu_entry {
};
struct microcode_patch {
- uint32_t data_code;
+ uint16_t year;
+ uint8_t day;
+ uint8_t month;
uint32_t patch_id;
uint8_t mc_patch_data_id[2];
uint8_t mc_patch_data_len;
@@ -251,8 +253,9 @@ static int apply_microcode(const struct
return -EIO;
}
- printk(XENLOG_WARNING "microcode: CPU%u updated from revision %#x to %#x\n",
- cpu, old_rev, rev);
+ printk(XENLOG_WARNING
+ "microcode: CPU%u updated from revision %#x to %#x, date = %04x-%02x-%02x\n",
+ cpu, old_rev, rev, patch->year, patch->month, patch->day);
return 0;
}
next reply other threads:[~2021-04-01 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 8:28 Jan Beulich [this message]
2021-04-01 11:22 ` [PATCH] x86/ucode: log blob date also for AMD Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a236ef77-e6ef-5cbe-60a0-49c8dcd9a208@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).