From: Jan Beulich <jbeulich@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: julien@xen.org, andrew.cooper3@citrix.com, roger.pau@citrix.com,
bertrand.marquis@arm.com, roberto.bagnara@bugseng.com,
Stefano Stabellini <stefano.stabellini@amd.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] docs/misra: new rules addition
Date: Mon, 12 Jun 2023 09:33:22 +0200 [thread overview]
Message-ID: <a3229436-c714-ab2d-27f9-eac1455d3943@suse.com> (raw)
In-Reply-To: <20230609174543.4067574-1-sstabellini@kernel.org>
On 09.06.2023 19:45, Stefano Stabellini wrote:
> @@ -133,6 +146,13 @@ existing codebase are work-in-progress.
> headers (xen/include/public/) are allowed to retain longer
> identifiers for backward compatibility.
>
> + * - `Rule 6.1 <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_06_01.c>`_
> + - Required
> + - Bit-fields shall only be declared with an appropriate type
> + - In addition to the C99 types, we also consider appropriate types:
> + unsigned char, unsigned short, unsigned long, unsigned long long,
> + enum.
What about their signed equivalents? I'm surprised that I found only very
few uses (in Arm insn decoding afaict), but they generally have a purpose.
Are the uses we have (and new ones which may appear) intended to become
deviations?
> @@ -143,6 +163,12 @@ existing codebase are work-in-progress.
> - Octal constants shall not be used
> -
>
> + * - `Rule 7.2 <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_07_02.c>`_
> + - Required
> + - A "u" or "U" suffix shall be applied to all integer constants
> + that are represented in an unsigned type
> + -
I continue to consider "represented in" problematic here without
further qualification.
> @@ -314,6 +340,11 @@ existing codebase are work-in-progress.
> used following a subsequent call to the same function
> -
>
> + * - Rule 21.21
> + - Required
> + - The Standard Library function system of <stdlib.h> shall not be used
> + -
Still no "inapplicable" note (whichever way it would be worded to also
please Roberto)?
Jan
next prev parent reply other threads:[~2023-06-12 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 17:45 [PATCH v2] docs/misra: new rules addition Stefano Stabellini
2023-06-12 7:33 ` Jan Beulich [this message]
2023-06-12 9:34 ` Roberto Bagnara
2023-06-12 9:50 ` Jan Beulich
2023-06-12 15:15 ` Roberto Bagnara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3229436-c714-ab2d-27f9-eac1455d3943@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=julien@xen.org \
--cc=roberto.bagnara@bugseng.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).