From: Liam Merwick <liam.merwick@oracle.com>
To: qemu-devel@nongnu.org
Cc: liam.merwick@oracle.com, ehabkost@redhat.com, mst@redhat.com,
Maran Wilson <maran.wilson@oracle.com>,
George Kennedy <george.kennedy@oracle.com>,
xen-devel@lists.xenproject.org,
Paolo Bonzini <pbonzini@redhat.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
rth@twiddle.net, sgarzare@redhat.com
Subject: Re: [Qemu-devel] [RFC 1/3] pvh: Add x86/HVM direct boot ABI header file
Date: Fri, 21 Dec 2018 20:03:33 +0000 [thread overview]
Message-ID: <a577be2e-8753-93ab-3034-a6288733e32f@oracle.com> (raw)
In-Reply-To: <83b577e6-691e-08b3-e9e4-90651e988ff2@oracle.com>
On 11/12/2018 14:57, Liam Merwick wrote:
> On 11/12/2018 14:01, Stefan Hajnoczi wrote:
>> On Wed, Dec 05, 2018 at 10:37:24PM +0000, Liam Merwick wrote:
>>> From: Liam Merwick <Liam.Merwick@oracle.com>
>>>
>>> The x86/HVM direct boot ABI permits Qemu to be able to boot directly
>>> into the uncompressed Linux kernel binary without the need to run
>>> firmware.
>>>
>>> https://xenbits.xen.org/docs/unstable/misc/pvh.html
>>>
>>> This commit adds the header file that defines the start_info struct
>>> that needs to be populated in order to use this ABI.
>>>
>>> Signed-off-by: Maran Wilson <Maran.Wilson@oracle.com>
>>> Signed-off-by: Liam Merwick <Liam.Merwick@oracle.com>
>>> Reviewed-by: Konrad Rzeszutek Wilk <Konrad.Wilk@oracle.com>
>>> ---
>>> include/hw/xen/start_info.h | 146
>>> ++++++++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 146 insertions(+)
>>> create mode 100644 include/hw/xen/start_info.h
>>
>> Does it make sense to bring in Linux
>> include/xen/interface/hvm/start_info.h via QEMU's
>> include/standard-headers/?
>>
>> QEMU has a script in scripts/update-linux-header.sh for syncing Linux
>> headers into include/standard-headers/. This makes it easy to keep
>> Linux header files up-to-date. We basically treat files in
>> include/standard-headers/ as auto-generated.
>>
>> If you define start_info.h yourself without using
>> include/standard-headers/, then it won't be synced with Linux.
>>
>
> That does seem better. I will make that change.
When attempting to implement this, I found the canonical copy of this
header file is actually in Xen and the Linux copy is kept in sync with
that. Also, 'make headers_install' doesn't install those Xen headers.
Instead I updated the commit comment to mention the canonical copy
location. This file isn't expected to change much so I think keeping it
in sync in future shouldn't be onerous.
Regards,
Liam
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-12-21 20:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 22:37 [RFC 0/3] QEMU changes to do PVH boot Liam Merwick
2018-12-05 22:37 ` [RFC 1/3] pvh: Add x86/HVM direct boot ABI header file Liam Merwick
2018-12-11 14:01 ` Stefan Hajnoczi
2018-12-11 14:57 ` Liam Merwick
2018-12-11 15:03 ` [Qemu-devel] " Daniel P. Berrangé
2018-12-21 20:03 ` Liam Merwick [this message]
2018-12-05 22:37 ` [RFC 2/3] pc: Read PVH entry point from ELF note in kernel binary Liam Merwick
2018-12-11 14:17 ` Stefan Hajnoczi
[not found] ` <20181211141732.GB23460@stefanha-x1.localdomain>
2018-12-21 20:03 ` Liam Merwick
2018-12-05 22:37 ` [RFC 3/3] pvh: Boot uncompressed kernel using direct boot ABI Liam Merwick
2018-12-11 17:11 ` Stefano Garzarella
[not found] ` <CAGxU2F4j11wVoDktowJwXDy42_PWbjwF0qAueFg+He4Tb86wgQ@mail.gmail.com>
2018-12-11 18:35 ` Maran Wilson
2018-12-12 15:28 ` Stefano Garzarella
[not found] ` <CAGxU2F793nfiFADnJW-j-vLSS0Mp-XP54JFEq++0_JunHQj50w@mail.gmail.com>
2018-12-12 17:36 ` Maran Wilson
2018-12-06 0:01 ` [Qemu-devel] [RFC 0/3] QEMU changes to do PVH boot no-reply
2018-12-06 6:18 ` Maran Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a577be2e-8753-93ab-3034-a6288733e32f@oracle.com \
--to=liam.merwick@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ehabkost@redhat.com \
--cc=george.kennedy@oracle.com \
--cc=maran.wilson@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sgarzare@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).