xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien@xen.org>
To: Connor Davis <connojdavis@gmail.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Tamas K Lengyel <tamas@tklengyel.com>,
	Alexandru Isaila <aisaila@bitdefender.com>,
	Petre Pircalabu <ppircalabu@bitdefender.com>
Subject: Re: [PATCH v2 4/5] xen: Add files needed for minimal riscv build
Date: Fri, 14 May 2021 10:46:49 +0100	[thread overview]
Message-ID: <a5fd6d72-3a02-4c12-4021-bf06d0eeb174@xen.org> (raw)
In-Reply-To: <c5d130b06de3d724921488387f1743d7996aac11.1620965208.git.connojdavis@gmail.com>

Hi Connor,

On 14/05/2021 05:17, Connor Davis wrote:
> Add the minimum code required to get xen to build with
> XEN_TARGET_ARCH=riscv64. It is minimal in the sense that every file and
> function added is required for a successful build, given the .config
> generated from riscv64_defconfig. The function implementations are just
> stubs; actual implmentations will need to be added later.

Thank you for the contribution. This is quite a large patch to review. 
Could you consider to split in smaller one (I think Stefano suggested 
one per header file or group of headers)? This would help to review and 
find whether some bits can be moved in common.

I would be happy to help moving some of the pieces.

> 
> Signed-off-by: Connor Davis <connojdavis@gmail.com>
> ---
>   config/riscv64.mk                        |   7 +
>   xen/Makefile                             |   8 +-
>   xen/arch/riscv/Kconfig                   |  54 ++++
>   xen/arch/riscv/Kconfig.debug             |   0
>   xen/arch/riscv/Makefile                  |  57 ++++
>   xen/arch/riscv/README.source             |  19 ++
>   xen/arch/riscv/Rules.mk                  |  13 +
>   xen/arch/riscv/arch.mk                   |   7 +
>   xen/arch/riscv/configs/riscv64_defconfig |  12 +
>   xen/arch/riscv/delay.c                   |  16 +
>   xen/arch/riscv/domain.c                  | 144 +++++++++
>   xen/arch/riscv/domctl.c                  |  36 +++
>   xen/arch/riscv/guestcopy.c               |  57 ++++
>   xen/arch/riscv/head.S                    |   6 +
>   xen/arch/riscv/irq.c                     |  78 +++++
>   xen/arch/riscv/lib/Makefile              |   1 +
>   xen/arch/riscv/lib/find_next_bit.c       | 284 +++++++++++++++++

I quickly skimmed through the code and I think some of the file can be 
made common such as this one.

[...]

> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
> index 1708c36964..fd0b75677c 100644
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -60,6 +60,7 @@ void arch_vcpu_destroy(struct vcpu *v);
>   int map_vcpu_info(struct vcpu *v, unsigned long gfn, unsigned offset);
>   void unmap_vcpu_info(struct vcpu *v);
>   
> +struct xen_domctl_createdomain;

This is needed because?

>   int arch_domain_create(struct domain *d,
>                          struct xen_domctl_createdomain *config);
>   
> 

Cheers,

-- 
Julien Grall


  reply	other threads:[~2021-05-14  9:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14  4:17 [PATCH v2 0/5] Minimal build for RISCV Connor Davis
2021-05-14  4:17 ` [PATCH v2 1/5] xen/char: Default HAS_NS16550 to y only for X86 and ARM Connor Davis
2021-05-14  5:34   ` Elliott Mitchell
2021-05-14 14:13     ` Connor Davis
2021-05-14  4:17 ` [PATCH v2 2/5] xen/common: Guard iommu symbols with CONFIG_HAS_PASSTHROUGH Connor Davis
2021-05-14  4:17 ` [PATCH v2 3/5] xen: Fix build when !CONFIG_GRANT_TABLE Connor Davis
2021-05-14  4:17 ` [PATCH v2 4/5] xen: Add files needed for minimal riscv build Connor Davis
2021-05-14  9:46   ` Julien Grall [this message]
2021-05-14 13:57     ` Connor Davis
2021-05-14  4:17 ` [PATCH v2 5/5] automation: add container for riscv64 builds Connor Davis
2021-05-14  4:43 ` [PATCH v2 0/5] Minimal build for RISCV Alistair Francis
2021-05-14 14:02   ` Connor Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5fd6d72-3a02-4c12-4021-bf06d0eeb174@xen.org \
    --to=julien@xen.org \
    --cc=aisaila@bitdefender.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=connojdavis@gmail.com \
    --cc=george.dunlap@citrix.com \
    --cc=iwj@xenproject.org \
    --cc=jbeulich@suse.com \
    --cc=ppircalabu@bitdefender.com \
    --cc=sstabellini@kernel.org \
    --cc=tamas@tklengyel.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH v2 4/5] xen: Add files needed for minimal riscv build' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).