xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Dario Faggioli <dario.faggioli@citrix.com>,
	xen-devel@lists.xenproject.org
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v2 1/2] xen: fix a (latent) cpupool-related race during domain destroy
Date: Mon, 18 Jul 2016 16:09:22 +0200	[thread overview]
Message-ID: <a6c02c9e-377a-28fe-d056-c5ecf4e064b5@suse.com> (raw)
In-Reply-To: <1468850584.13039.143.camel@citrix.com>

On 18/07/16 16:03, Dario Faggioli wrote:
> On Fri, 2016-07-15 at 16:23 +0200, Dario Faggioli wrote:
>> On Fri, 2016-07-15 at 14:52 +0200, Juergen Gross wrote:
>>> On 15/07/16 13:52, Dario Faggioli wrote:
>>>> Therefore, I still think this patch is correct, but I'm up for
>>>> investigating further and finding a way to solve the "zombie in
>>>> cpupool" issue as well.
>>> I'm not saying your patch is wrong. I just wanted to give you a
>>> hint
>>> about the history of the stuff you are changing. :-)
>>>
>> Sure, and that's much appreciated! :-)
>>
>>> If it is working I'd really prefer it over the current situation.
>>>
>> Right. I've got to leave now. But I'll produce some zombies on
>> Monday,
>> and will see if they move. :-D
>>
> Here you go:
> 
> http://pastebin.com/r93TGCZU
> 
> Is that "vm1 -b-" --> "(null) ---" domain zombie enough?

Yes, seems to be okay for a zombie.

> If yes, as you can see, it moves to cpupool0 while being destroyed, and
> I can destroy the pool without problems.

Great.

> I also shutdown the system with the domain still there (in cpupool0),
> and it works.

Fine. You can add

Acked-by: Juergen Gross <jgross@suse.com>

for this patch then.


Thanks, Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-07-18 14:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14 16:17 [PATCH v2 0/2] xen: cpupool (small) improvement and (latent) bug fix Dario Faggioli
2016-07-14 16:18 ` [PATCH v2 1/2] xen: fix a (latent) cpupool-related race during domain destroy Dario Faggioli
2016-07-14 17:08   ` Andrew Cooper
2016-07-15  9:38   ` Juergen Gross
2016-07-15 10:14     ` Dario Faggioli
2016-07-15 10:36       ` Juergen Gross
2016-07-15 11:52         ` Dario Faggioli
2016-07-15 12:52           ` Juergen Gross
2016-07-15 14:23             ` Dario Faggioli
2016-07-18 14:03               ` Dario Faggioli
2016-07-18 14:09                 ` Juergen Gross [this message]
2016-07-28 17:29                   ` Dario Faggioli
2016-08-03 11:54                     ` George Dunlap
2016-08-03 12:27                   ` George Dunlap
2016-07-14 16:18 ` [PATCH v2 2/2] xen: cpupool: small optimization when moving between pools Dario Faggioli
2016-07-15  9:39   ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6c02c9e-377a-28fe-d056-c5ecf4e064b5@suse.com \
    --to=jgross@suse.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=dario.faggioli@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).