From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, WeiLiu <wl@xen.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH 1/4] x86/mcheck: allow varying bank counts per CPU
Date: Fri, 21 Jun 2019 18:45:57 +0100 [thread overview]
Message-ID: <a7ddc417-2fb3-c1ab-0918-335c1bf0f5c3@citrix.com> (raw)
In-Reply-To: <5D03BEDE0200007800238613@prv1-mh.provo.novell.com>
On 14/06/2019 16:35, Jan Beulich wrote:
> Up to now we've been assuming that all CPUs would have the same number
> of reporting banks. However, on upcoming AMD CPUs this isn't the case,
> and one can observe
>
> (XEN) mce.c:666: Different bank number on cpu <N>
>
> indicating that Machine Check support would not be enabled on the
> affected CPUs. Convert the count variable to a per-CPU one, and adjust
> code where needed to cope with the values not being the same. In
> particular the mcabanks_alloc() invocations during AP bringup need to
> now allocate maximum-size bitmaps, because the truly needed size can't
> be known until we actually execute on that CPU, yet mcheck_init() gets
> called too early to do any allocations itself.
>
> Take the liberty and also
> - make mca_cap_init() static,
> - replace several __get_cpu_var() uses when a local variable suitable
> for use with per_cpu() appears,
> - correct which CPU's cpu_data[] entry x86_mc_msrinject_verify() uses,
> - replace a BUG() by panic().
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-06-21 17:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 15:33 [Xen-devel] [PATCH 0/4] x86 MCE adjustments for AMD / general per-CPU accessor cleanup Jan Beulich
2019-06-14 15:35 ` [Xen-devel] [PATCH 1/4] x86/mcheck: allow varying bank counts per CPU Jan Beulich
2019-06-21 17:45 ` Andrew Cooper [this message]
2019-06-14 15:37 ` [Xen-devel] [PATCH 2/4] x86/mcheck: replace remaining uses of __get_cpu_var() Jan Beulich
2019-06-21 17:46 ` Andrew Cooper
2019-06-14 15:37 ` [Xen-devel] [PATCH 3/4] x86: " Jan Beulich
2019-06-21 17:47 ` Andrew Cooper
2019-06-14 15:38 ` [Xen-devel] [PATCH 4/4] drop __get_cpu_var() and __get_cpu_ptr() Jan Beulich
2019-06-17 15:27 ` Julien Grall
2019-06-18 18:00 ` Daniel De Graaf
2019-06-21 17:49 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7ddc417-2fb3-c1ab-0918-335c1bf0f5c3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).