Xen-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [Xen-devel] [PATCH] xen/docs: arm: Update dom0less binding and example
@ 2019-08-13 21:32 Julien Grall
  2019-10-02 17:46 ` Julien Grall
  2019-10-02 22:27 ` Stefano Stabellini
  0 siblings, 2 replies; 5+ messages in thread
From: Julien Grall @ 2019-08-13 21:32 UTC (permalink / raw)
  To: xen-devel
  Cc: viktor_mitin, Julien Grall, Stefano Stabellini, Volodymyr Babchuk

The binding for the dom0less module does not match Xen implementation.
Any module should contain the compatible "multiboot,module" to be
recognized.

This was clearly an oversight as other examples with Xen code base
provide the compatible "multiboot,module".

So fix the binding and the example associated to it.

Signed-off-by: Julien Grall <julien.grall@arm.com>

---

Cc: viktor_mitin@epam.com

    We probably want to consolidate all the dom0less documentation in
    one place rather than having to fix documation issues in a multiple
    places one by one.
---
 docs/misc/arm/device-tree/booting.txt | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
index 317a9e962a..0fafa01b5d 100644
--- a/docs/misc/arm/device-tree/booting.txt
+++ b/docs/misc/arm/device-tree/booting.txt
@@ -160,7 +160,7 @@ The kernel sub-node has the following properties:
 
 - compatible
 
-    "multiboot,kernel"
+    "multiboot,kernel", "multiboot,module"
 
 - reg
 
@@ -175,7 +175,7 @@ The ramdisk sub-node has the following properties:
 
 - compatible
 
-    "multiboot,ramdisk"
+    "multiboot,ramdisk", "multiboot,module"
 
 - reg
 
@@ -196,13 +196,13 @@ chosen {
         vpl011;
 
         module@0x4a000000 {
-            compatible = "multiboot,kernel";
+            compatible = "multiboot,kernel", "multiboot,module";
             reg = <0x0 0x4a000000 0xffffff>;
             bootargs = "console=ttyAMA0 init=/bin/sh";
         };
 
         module@0x4b000000 {
-            compatible = "multiboot,ramdisk";
+            compatible = "multiboot,ramdisk", "multiboot,module";
             reg = <0x0 0x4b000000 0xffffff>;
         };
     };
@@ -215,13 +215,13 @@ chosen {
         cpus = <1>;
 
         module@0x4c000000 {
-            compatible = "multiboot,kernel";
+            compatible = "multiboot,kernel", "multiboot,module";
             reg = <0x0 0x4c000000 0xffffff>;
             bootargs = "console=ttyAMA0 init=/bin/sh";
         };
 
         module@0x4d000000 {
-            compatible = "multiboot,ramdisk";
+            compatible = "multiboot,ramdisk", "multiboot,module";
             reg = <0x0 0x4d000000 0xffffff>;
         };
     };
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Xen-devel] [PATCH] xen/docs: arm: Update dom0less binding and example
  2019-08-13 21:32 [Xen-devel] [PATCH] xen/docs: arm: Update dom0less binding and example Julien Grall
@ 2019-10-02 17:46 ` Julien Grall
  2019-10-02 22:27 ` Stefano Stabellini
  1 sibling, 0 replies; 5+ messages in thread
From: Julien Grall @ 2019-10-02 17:46 UTC (permalink / raw)
  To: xen-devel; +Cc: viktor_mitin, Stefano Stabellini, Volodymyr Babchuk

Gentle ping.

On 8/13/19 10:32 PM, Julien Grall wrote:
> The binding for the dom0less module does not match Xen implementation.
> Any module should contain the compatible "multiboot,module" to be
> recognized.
> 
> This was clearly an oversight as other examples with Xen code base
> provide the compatible "multiboot,module".
> 
> So fix the binding and the example associated to it.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> 
> ---
> 
> Cc: viktor_mitin@epam.com
> 
>      We probably want to consolidate all the dom0less documentation in
>      one place rather than having to fix documation issues in a multiple
>      places one by one.
> ---
>   docs/misc/arm/device-tree/booting.txt | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
> index 317a9e962a..0fafa01b5d 100644
> --- a/docs/misc/arm/device-tree/booting.txt
> +++ b/docs/misc/arm/device-tree/booting.txt
> @@ -160,7 +160,7 @@ The kernel sub-node has the following properties:
>   
>   - compatible
>   
> -    "multiboot,kernel"
> +    "multiboot,kernel", "multiboot,module"
>   
>   - reg
>   
> @@ -175,7 +175,7 @@ The ramdisk sub-node has the following properties:
>   
>   - compatible
>   
> -    "multiboot,ramdisk"
> +    "multiboot,ramdisk", "multiboot,module"
>   
>   - reg
>   
> @@ -196,13 +196,13 @@ chosen {
>           vpl011;
>   
>           module@0x4a000000 {
> -            compatible = "multiboot,kernel";
> +            compatible = "multiboot,kernel", "multiboot,module";
>               reg = <0x0 0x4a000000 0xffffff>;
>               bootargs = "console=ttyAMA0 init=/bin/sh";
>           };
>   
>           module@0x4b000000 {
> -            compatible = "multiboot,ramdisk";
> +            compatible = "multiboot,ramdisk", "multiboot,module";
>               reg = <0x0 0x4b000000 0xffffff>;
>           };
>       };
> @@ -215,13 +215,13 @@ chosen {
>           cpus = <1>;
>   
>           module@0x4c000000 {
> -            compatible = "multiboot,kernel";
> +            compatible = "multiboot,kernel", "multiboot,module";
>               reg = <0x0 0x4c000000 0xffffff>;
>               bootargs = "console=ttyAMA0 init=/bin/sh";
>           };
>   
>           module@0x4d000000 {
> -            compatible = "multiboot,ramdisk";
> +            compatible = "multiboot,ramdisk", "multiboot,module";
>               reg = <0x0 0x4d000000 0xffffff>;
>           };
>       };
> 

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Xen-devel] [PATCH] xen/docs: arm: Update dom0less binding and example
  2019-08-13 21:32 [Xen-devel] [PATCH] xen/docs: arm: Update dom0less binding and example Julien Grall
  2019-10-02 17:46 ` Julien Grall
@ 2019-10-02 22:27 ` Stefano Stabellini
  2019-10-10 14:45   ` Julien Grall
  1 sibling, 1 reply; 5+ messages in thread
From: Stefano Stabellini @ 2019-10-02 22:27 UTC (permalink / raw)
  To: Julien Grall
  Cc: xen-devel, Stefano Stabellini, Volodymyr Babchuk, viktor_mitin

On Tue, 13 Aug 2019, Julien Grall wrote:
> The binding for the dom0less module does not match Xen implementation.
> Any module should contain the compatible "multiboot,module" to be
> recognized.
> 
> This was clearly an oversight as other examples with Xen code base
> provide the compatible "multiboot,module".
> 
> So fix the binding and the example associated to it.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>

Yes!

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

> ---
> 
> Cc: viktor_mitin@epam.com
> 
>     We probably want to consolidate all the dom0less documentation in
>     one place rather than having to fix documation issues in a multiple
>     places one by one.
> ---
>  docs/misc/arm/device-tree/booting.txt | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
> index 317a9e962a..0fafa01b5d 100644
> --- a/docs/misc/arm/device-tree/booting.txt
> +++ b/docs/misc/arm/device-tree/booting.txt
> @@ -160,7 +160,7 @@ The kernel sub-node has the following properties:
>  
>  - compatible
>  
> -    "multiboot,kernel"
> +    "multiboot,kernel", "multiboot,module"
>  
>  - reg
>  
> @@ -175,7 +175,7 @@ The ramdisk sub-node has the following properties:
>  
>  - compatible
>  
> -    "multiboot,ramdisk"
> +    "multiboot,ramdisk", "multiboot,module"
>  
>  - reg
>  
> @@ -196,13 +196,13 @@ chosen {
>          vpl011;
>  
>          module@0x4a000000 {
> -            compatible = "multiboot,kernel";
> +            compatible = "multiboot,kernel", "multiboot,module";
>              reg = <0x0 0x4a000000 0xffffff>;
>              bootargs = "console=ttyAMA0 init=/bin/sh";
>          };
>  
>          module@0x4b000000 {
> -            compatible = "multiboot,ramdisk";
> +            compatible = "multiboot,ramdisk", "multiboot,module";
>              reg = <0x0 0x4b000000 0xffffff>;
>          };
>      };
> @@ -215,13 +215,13 @@ chosen {
>          cpus = <1>;
>  
>          module@0x4c000000 {
> -            compatible = "multiboot,kernel";
> +            compatible = "multiboot,kernel", "multiboot,module";
>              reg = <0x0 0x4c000000 0xffffff>;
>              bootargs = "console=ttyAMA0 init=/bin/sh";
>          };
>  
>          module@0x4d000000 {
> -            compatible = "multiboot,ramdisk";
> +            compatible = "multiboot,ramdisk", "multiboot,module";
>              reg = <0x0 0x4d000000 0xffffff>;
>          };
>      };
> -- 
> 2.11.0
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Xen-devel] [PATCH] xen/docs: arm: Update dom0less binding and example
  2019-10-02 22:27 ` Stefano Stabellini
@ 2019-10-10 14:45   ` Julien Grall
  2019-10-10 14:47     ` Jürgen Groß
  0 siblings, 1 reply; 5+ messages in thread
From: Julien Grall @ 2019-10-10 14:45 UTC (permalink / raw)
  To: Stefano Stabellini
  Cc: Juergen Gross, xen-devel, Volodymyr Babchuk, viktor_mitin

Hi,

Juergen, would you be happy if this patch is committed for Xen 4.13?

Cheers,

On 02/10/2019 23:27, Stefano Stabellini wrote:
> On Tue, 13 Aug 2019, Julien Grall wrote:
>> The binding for the dom0less module does not match Xen implementation.
>> Any module should contain the compatible "multiboot,module" to be
>> recognized.
>>
>> This was clearly an oversight as other examples with Xen code base
>> provide the compatible "multiboot,module".
>>
>> So fix the binding and the example associated to it.
>>
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
> 
> Yes!
> 
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> 
>> ---
>>
>> Cc: viktor_mitin@epam.com
>>
>>      We probably want to consolidate all the dom0less documentation in
>>      one place rather than having to fix documation issues in a multiple
>>      places one by one.
>> ---
>>   docs/misc/arm/device-tree/booting.txt | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt
>> index 317a9e962a..0fafa01b5d 100644
>> --- a/docs/misc/arm/device-tree/booting.txt
>> +++ b/docs/misc/arm/device-tree/booting.txt
>> @@ -160,7 +160,7 @@ The kernel sub-node has the following properties:
>>   
>>   - compatible
>>   
>> -    "multiboot,kernel"
>> +    "multiboot,kernel", "multiboot,module"
>>   
>>   - reg
>>   
>> @@ -175,7 +175,7 @@ The ramdisk sub-node has the following properties:
>>   
>>   - compatible
>>   
>> -    "multiboot,ramdisk"
>> +    "multiboot,ramdisk", "multiboot,module"
>>   
>>   - reg
>>   
>> @@ -196,13 +196,13 @@ chosen {
>>           vpl011;
>>   
>>           module@0x4a000000 {
>> -            compatible = "multiboot,kernel";
>> +            compatible = "multiboot,kernel", "multiboot,module";
>>               reg = <0x0 0x4a000000 0xffffff>;
>>               bootargs = "console=ttyAMA0 init=/bin/sh";
>>           };
>>   
>>           module@0x4b000000 {
>> -            compatible = "multiboot,ramdisk";
>> +            compatible = "multiboot,ramdisk", "multiboot,module";
>>               reg = <0x0 0x4b000000 0xffffff>;
>>           };
>>       };
>> @@ -215,13 +215,13 @@ chosen {
>>           cpus = <1>;
>>   
>>           module@0x4c000000 {
>> -            compatible = "multiboot,kernel";
>> +            compatible = "multiboot,kernel", "multiboot,module";
>>               reg = <0x0 0x4c000000 0xffffff>;
>>               bootargs = "console=ttyAMA0 init=/bin/sh";
>>           };
>>   
>>           module@0x4d000000 {
>> -            compatible = "multiboot,ramdisk";
>> +            compatible = "multiboot,ramdisk", "multiboot,module";
>>               reg = <0x0 0x4d000000 0xffffff>;
>>           };
>>       };
>> -- 
>> 2.11.0
>>

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Xen-devel] [PATCH] xen/docs: arm: Update dom0less binding and example
  2019-10-10 14:45   ` Julien Grall
@ 2019-10-10 14:47     ` Jürgen Groß
  0 siblings, 0 replies; 5+ messages in thread
From: Jürgen Groß @ 2019-10-10 14:47 UTC (permalink / raw)
  To: Julien Grall, Stefano Stabellini
  Cc: Volodymyr Babchuk, viktor_mitin, xen-devel

On 10.10.19 16:45, Julien Grall wrote:
> Hi,
> 
> Juergen, would you be happy if this patch is committed for Xen 4.13?

Yes, you can add my:

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen

> 
> Cheers,
> 
> On 02/10/2019 23:27, Stefano Stabellini wrote:
>> On Tue, 13 Aug 2019, Julien Grall wrote:
>>> The binding for the dom0less module does not match Xen implementation.
>>> Any module should contain the compatible "multiboot,module" to be
>>> recognized.
>>>
>>> This was clearly an oversight as other examples with Xen code base
>>> provide the compatible "multiboot,module".
>>>
>>> So fix the binding and the example associated to it.
>>>
>>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>>
>> Yes!
>>
>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>
>>> ---
>>>
>>> Cc: viktor_mitin@epam.com
>>>
>>>      We probably want to consolidate all the dom0less documentation in
>>>      one place rather than having to fix documation issues in a multiple
>>>      places one by one.
>>> ---
>>>   docs/misc/arm/device-tree/booting.txt | 12 ++++++------
>>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/docs/misc/arm/device-tree/booting.txt 
>>> b/docs/misc/arm/device-tree/booting.txt
>>> index 317a9e962a..0fafa01b5d 100644
>>> --- a/docs/misc/arm/device-tree/booting.txt
>>> +++ b/docs/misc/arm/device-tree/booting.txt
>>> @@ -160,7 +160,7 @@ The kernel sub-node has the following properties:
>>>   - compatible
>>> -    "multiboot,kernel"
>>> +    "multiboot,kernel", "multiboot,module"
>>>   - reg
>>> @@ -175,7 +175,7 @@ The ramdisk sub-node has the following properties:
>>>   - compatible
>>> -    "multiboot,ramdisk"
>>> +    "multiboot,ramdisk", "multiboot,module"
>>>   - reg
>>> @@ -196,13 +196,13 @@ chosen {
>>>           vpl011;
>>>           module@0x4a000000 {
>>> -            compatible = "multiboot,kernel";
>>> +            compatible = "multiboot,kernel", "multiboot,module";
>>>               reg = <0x0 0x4a000000 0xffffff>;
>>>               bootargs = "console=ttyAMA0 init=/bin/sh";
>>>           };
>>>           module@0x4b000000 {
>>> -            compatible = "multiboot,ramdisk";
>>> +            compatible = "multiboot,ramdisk", "multiboot,module";
>>>               reg = <0x0 0x4b000000 0xffffff>;
>>>           };
>>>       };
>>> @@ -215,13 +215,13 @@ chosen {
>>>           cpus = <1>;
>>>           module@0x4c000000 {
>>> -            compatible = "multiboot,kernel";
>>> +            compatible = "multiboot,kernel", "multiboot,module";
>>>               reg = <0x0 0x4c000000 0xffffff>;
>>>               bootargs = "console=ttyAMA0 init=/bin/sh";
>>>           };
>>>           module@0x4d000000 {
>>> -            compatible = "multiboot,ramdisk";
>>> +            compatible = "multiboot,ramdisk", "multiboot,module";
>>>               reg = <0x0 0x4d000000 0xffffff>;
>>>           };
>>>       };
>>> -- 
>>> 2.11.0
>>>
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 21:32 [Xen-devel] [PATCH] xen/docs: arm: Update dom0less binding and example Julien Grall
2019-10-02 17:46 ` Julien Grall
2019-10-02 22:27 ` Stefano Stabellini
2019-10-10 14:45   ` Julien Grall
2019-10-10 14:47     ` Jürgen Groß

Xen-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/xen-devel/0 xen-devel/git/0.git
	git clone --mirror https://lore.kernel.org/xen-devel/1 xen-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 xen-devel xen-devel/ https://lore.kernel.org/xen-devel \
		xen-devel@lists.xenproject.org xen-devel@lists.xen.org xen-devel@archiver.kernel.org
	public-inbox-index xen-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.xenproject.lists.xen-devel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox