From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Claudio Fontana <cfontana@suse.de>, Jason Andryuk <jandryuk@gmail.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Paul Durrant <paul@xen.org>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Anthony Perard <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 0/2] Add Xen CpusAccel
Date: Tue, 13 Oct 2020 10:42:46 +0200 [thread overview]
Message-ID: <a88a1570-ccbd-987c-17db-53e8643c1ea8@redhat.com> (raw)
In-Reply-To: <c2b2ed9a-879c-f676-86f0-22b3a77b770f@suse.de>
On 10/12/20 10:16 PM, Claudio Fontana wrote:
> On 10/12/20 10:07 PM, Jason Andryuk wrote:
>> Xen was left behind when CpusAccel became mandatory and fails the assert
>> in qemu_init_vcpu(). It relied on the same dummy cpu threads as qtest.
>> Move the qtest cpu functions to a common location and reuse them for
>> Xen.
>>
>> Jason Andryuk (2):
>> accel: move qtest CpusAccel functions to a common location
>> accel: Add xen CpusAccel using dummy-cpu
>>
>> .../qtest-cpus.c => dummy/dummy-cpus.c} | 22 +++++--------------
>> .../qtest-cpus.h => dummy/dummy-cpus.h} | 10 ++++-----
>> accel/dummy/meson.build | 7 ++++++
>> accel/meson.build | 1 +
>> accel/qtest/meson.build | 1 -
>> accel/qtest/qtest.c | 7 +++++-
>> accel/xen/xen-all.c | 10 +++++++++
>> 7 files changed, 34 insertions(+), 24 deletions(-)
>> rename accel/{qtest/qtest-cpus.c => dummy/dummy-cpus.c} (76%)
>> rename accel/{qtest/qtest-cpus.h => dummy/dummy-cpus.h} (59%)
>> create mode 100644 accel/dummy/meson.build
>>
>
> Yep, forgot completely, sorry.
Good opportunity to ask the Xen folks to add testing
to our Gitlab CI, so this doesn't happen again :)
>
> Acked-by: Claudio Fontana <cfontana@suse.de>
>
>
>
prev parent reply other threads:[~2020-10-13 8:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 20:07 [PATCH 0/2] Add Xen CpusAccel Jason Andryuk
2020-10-12 20:07 ` [PATCH 2/2] accel: Add xen CpusAccel using dummy-cpu Jason Andryuk
2020-10-12 20:25 ` Claudio Fontana
2020-10-12 20:16 ` [PATCH 0/2] Add Xen CpusAccel Claudio Fontana
2020-10-13 8:42 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a88a1570-ccbd-987c-17db-53e8643c1ea8@redhat.com \
--to=philmd@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=cfontana@suse.de \
--cc=jandryuk@gmail.com \
--cc=lvivier@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=thuth@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).