From: Jan Beulich <jbeulich@suse.com> To: Chao Gao <chao.gao@intel.com> Cc: xen-devel@lists.xenproject.org, "Roger Pau Monné" <roger.pau@citrix.com>, "Ashok Raj" <ashok.raj@intel.com>, "Wei Liu" <wl@xen.org>, "Andrew Cooper" <andrew.cooper3@citrix.com> Subject: Re: [Xen-devel] [PATCH v9 12/15] microcode: reduce memory allocation and copy when creating a patch Date: Thu, 29 Aug 2019 12:47:15 +0200 Message-ID: <a970ab03-c8a6-0a09-574d-1e46ecde996e@suse.com> (raw) In-Reply-To: <1566177928-19114-13-git-send-email-chao.gao@intel.com> On 19.08.2019 03:25, Chao Gao wrote: > @@ -542,29 +505,21 @@ static struct microcode_patch *cpu_request_microcode(const void *buf, > while ( (error = get_ucode_from_buffer_amd(mc_amd, buf, bufsize, > &offset)) == 0 ) > { > - struct microcode_patch *new_patch = alloc_microcode_patch(mc_amd); > - > - if ( IS_ERR(new_patch) ) > - { > - error = PTR_ERR(new_patch); > - break; > - } > - > /* > - * If the new patch covers current CPU, compare patches and store the > + * If the new ucode covers current CPU, compare ucodes and store the > * one with higher revision. > */ > - if ( (microcode_fits(new_patch->mc_amd) != MIS_UCODE) && > - (!patch || (compare_patch(new_patch, patch) == NEW_UCODE)) ) > +#define REV_ID(mpb) (((struct microcode_header_amd *)(mpb))->processor_rev_id) > + if ( (microcode_fits(mc_amd) != MIS_UCODE) && > + (!saved || (REV_ID(mc_amd->mpb) > REV_ID(saved))) ) > +#undef REV_ID I'm not happy with this helper #define, the more that "saved" already is of the correct type. compare_patch() in reality only acts on the header, so I'd suggest having that function forward to a new compare_header() (or some other suitable name) and use that new function here as well. > @@ -379,47 +360,47 @@ static struct microcode_patch *cpu_request_microcode(const void *buf, > { > long offset = 0; > int error = 0; > - void *mc; > + struct microcode_intel *mc, *saved = NULL; > struct microcode_patch *patch = NULL; > > - while ( (offset = get_next_ucode_from_buffer(&mc, buf, size, offset)) > 0 ) > + while ( (offset = get_next_ucode_from_buffer((void **)&mc, buf, Casts like this make me rather nervous. Please see about getting rid of it (by using a union or a 2nd local variable). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply index Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-19 1:25 [Xen-devel] [PATCH v9 00/15] improve late microcode loading Chao Gao 2019-08-19 1:25 ` [Xen-devel] [PATCH v9 01/15] microcode/intel: extend microcode_update_match() Chao Gao 2019-08-28 15:12 ` Jan Beulich 2019-08-29 7:15 ` Chao Gao 2019-08-29 7:14 ` Jan Beulich 2019-08-19 1:25 ` [Xen-devel] [PATCH v9 02/15] microcode/amd: fix memory leak Chao Gao 2019-08-19 1:25 ` [Xen-devel] [PATCH v9 03/15] microcode/amd: distinguish old and mismatched ucode in microcode_fits() Chao Gao 2019-08-19 1:25 ` [Xen-devel] [PATCH v9 04/15] microcode: introduce a global cache of ucode patch Chao Gao 2019-08-22 11:11 ` Roger Pau Monné 2019-08-28 15:21 ` Jan Beulich 2019-08-29 10:18 ` Jan Beulich 2019-08-19 1:25 ` [Xen-devel] [PATCH v9 05/15] microcode: clean up microcode_resume_cpu Chao Gao 2019-08-19 1:25 ` [Xen-devel] [PATCH v9 06/15] microcode: remove struct ucode_cpu_info Chao Gao 2019-08-19 1:25 ` [Xen-devel] [PATCH v9 07/15] microcode: remove pointless 'cpu' parameter Chao Gao 2019-08-19 1:25 ` [Xen-devel] [PATCH v9 08/15] microcode/amd: call svm_host_osvw_init() in common code Chao Gao 2019-08-22 13:08 ` Roger Pau Monné 2019-08-28 15:26 ` Jan Beulich 2019-08-19 1:25 ` [Xen-devel] [PATCH v9 09/15] microcode: pass a patch pointer to apply_microcode() Chao Gao 2019-08-19 1:25 ` [Xen-devel] [PATCH v9 10/15] microcode: split out apply_microcode() from cpu_request_microcode() Chao Gao 2019-08-22 13:59 ` Roger Pau Monné 2019-08-29 10:06 ` Jan Beulich 2019-08-30 3:22 ` Chao Gao 2019-08-30 7:25 ` Jan Beulich 2019-08-29 10:19 ` Jan Beulich 2019-08-19 1:25 ` [Xen-devel] [PATCH v9 11/15] microcode: unify loading update during CPU resuming and AP wakeup Chao Gao 2019-08-22 14:10 ` Roger Pau Monné 2019-08-22 16:44 ` Chao Gao 2019-08-23 9:09 ` Roger Pau Monné 2019-08-29 7:37 ` Chao Gao 2019-08-29 8:16 ` Roger Pau Monné 2019-08-29 10:26 ` Jan Beulich 2019-08-29 10:29 ` Jan Beulich 2019-08-19 1:25 ` [Xen-devel] [PATCH v9 12/15] microcode: reduce memory allocation and copy when creating a patch Chao Gao 2019-08-23 8:11 ` Roger Pau Monné 2019-08-26 7:03 ` Chao Gao 2019-08-26 8:11 ` Roger Pau Monné 2019-08-29 10:47 ` Jan Beulich [this message] 2019-08-19 1:25 ` [Xen-devel] [PATCH v9 13/15] x86/microcode: Synchronize late microcode loading Chao Gao 2019-08-19 10:27 ` Sergey Dyasli 2019-08-19 14:49 ` Chao Gao 2019-08-29 12:06 ` Jan Beulich 2019-08-30 3:30 ` Chao Gao 2019-08-19 1:25 ` [Xen-devel] [PATCH v9 14/15] microcode: remove microcode_update_lock Chao Gao 2019-08-19 1:25 ` [Xen-devel] [PATCH v9 15/15] microcode: block #NMI handling when loading an ucode Chao Gao 2019-08-23 8:46 ` Sergey Dyasli 2019-08-26 8:07 ` Chao Gao 2019-08-27 4:52 ` Chao Gao 2019-08-28 8:52 ` Sergey Dyasli 2019-08-29 12:11 ` Jan Beulich 2019-08-30 6:35 ` Chao Gao 2019-09-09 5:52 ` Chao Gao 2019-09-09 6:16 ` Jan Beulich 2019-08-29 12:22 ` Jan Beulich 2019-08-30 6:33 ` Chao Gao 2019-08-30 7:30 ` Jan Beulich 2019-08-22 7:51 ` [Xen-devel] [PATCH v9 00/15] improve late microcode loading Sergey Dyasli 2019-08-22 15:39 ` Chao Gao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a970ab03-c8a6-0a09-574d-1e46ecde996e@suse.com \ --to=jbeulich@suse.com \ --cc=andrew.cooper3@citrix.com \ --cc=ashok.raj@intel.com \ --cc=chao.gao@intel.com \ --cc=roger.pau@citrix.com \ --cc=wl@xen.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Xen-Devel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/xen-devel/0 xen-devel/git/0.git git clone --mirror https://lore.kernel.org/xen-devel/1 xen-devel/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 xen-devel xen-devel/ https://lore.kernel.org/xen-devel \ xen-devel@lists.xenproject.org xen-devel@lists.xen.org public-inbox-index xen-devel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.xenproject.lists.xen-devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git