From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: "julien@xen.org" <julien@xen.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "jeff.kubascik@dornerworks.com" <jeff.kubascik@dornerworks.com>,
"jgrall@amazon.com" <jgrall@amazon.com>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"roman@zededa.com" <roman@zededa.com>,
"minyard@acm.org" <minyard@acm.org>
Subject: Re: [PATCH for-4.14 2/3] xen/arm: Take into account the DMA width when allocating Dom0 memory banks
Date: Mon, 18 May 2020 20:34:22 +0000 [thread overview]
Message-ID: <aa95369bf22df89404243dd4e7374f8015ccc9ad.camel@epam.com> (raw)
In-Reply-To: <20200518113008.15422-3-julien@xen.org>
Hi Julien,
On Mon, 2020-05-18 at 12:30 +0100, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> At the moment, Xen is assuming that all the devices are at least 32-bit
> DMA capable. However, some SoCs have devices that may be able to access
> a much restricted range. For instance, the Raspberry PI 4 has devices
> that can only access the first GB of RAM.
>
> The function arch_get_dma_bit_size() will return the lowest DMA width on
> the platform. Use it to decide what is the limit for the low memory.
>
> Signed-off-by: Julien GralL <jgrall@amazon.com>
> ---
> xen/arch/arm/domain_build.c | 32 +++++++++++++++++++-------------
> 1 file changed, 19 insertions(+), 13 deletions(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 430708753642..abc4e463d27c 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -211,10 +211,13 @@ fail:
> * the ramdisk and DTB must be placed within a certain proximity of
> * the kernel within RAM.
> * 3. For dom0 we want to place as much of the RAM as we reasonably can
> - * below 4GB, so that it can be used by non-LPAE enabled kernels (32-bit)
> + * below 4GB, so that it can be used by non-LPAE enabled kernels (32-bit).
Is full stop really needed there?
> * or when a device assigned to dom0 can only do 32-bit DMA access.
> - * 4. For 32-bit dom0 the kernel must be located below 4GB.
> - * 5. We want to have a few largers banks rather than many smaller ones.
> + * 4. Some devices assigned to dom0 can only do 32-bit DMA access or
> + * even be more restricted. We want to allocate as much of the RAM
> + * as we reasonably can that can be accessed from all the devices..
> + * 5. For 32-bit dom0 the kernel must be located below 4GB.
> + * 6. We want to have a few largers banks rather than many smaller ones.
> *
> * For the first two requirements we need to make sure that the lowest
> * bank is sufficiently large.
> @@ -245,9 +248,9 @@ fail:
> * we give up.
> *
> * For 32-bit domain we require that the initial allocation for the
> - * first bank is under 4G. For 64-bit domain, the first bank is preferred
> - * to be allocated under 4G. Then for the subsequent allocations we
> - * initially allocate memory only from below 4GB. Once that runs out
> + * first bank is part of the low mem. For 64-bit, the first bank is preferred
> + * to be allocated in the low mem. Then for subsequent allocation, we
> + * initially allocate memory only from low mem. Once that runs out out
> * (as described above) we allow higher allocations and continue until
> * that runs out (or we have allocated sufficient dom0 memory).
> */
> @@ -262,6 +265,7 @@ static void __init allocate_memory_11(struct domain *d,
> int i;
>
> bool lowmem = true;
> + unsigned int lowmem_bitsize = min(32U, arch_get_dma_bitsize());
> unsigned int bits;
>
> /*
> @@ -282,7 +286,7 @@ static void __init allocate_memory_11(struct domain *d,
> */
> while ( order >= min_low_order )
> {
> - for ( bits = order ; bits <= (lowmem ? 32 : PADDR_BITS); bits++ )
> + for ( bits = order ; bits <= lowmem_bitsize; bits++ )
> {
> pg = alloc_domheap_pages(d, order, MEMF_bits(bits));
> if ( pg != NULL )
> @@ -296,24 +300,26 @@ static void __init allocate_memory_11(struct domain *d,
> order--;
> }
>
> - /* Failed to allocate bank0 under 4GB */
> + /* Failed to allocate bank0 in the lowmem region. */
> if ( is_32bit_domain(d) )
> panic("Unable to allocate first memory bank\n");
>
> - /* Try to allocate memory from above 4GB */
> - printk(XENLOG_INFO "No bank has been allocated below 4GB.\n");
> + /* Try to allocate memory from above the lowmem region */
> + printk(XENLOG_INFO "No bank has been allocated below %u-bit.\n",
> + lowmem_bitsize);
> lowmem = false;
>
> got_bank0:
>
> /*
> - * If we failed to allocate bank0 under 4GB, continue allocating
> - * memory from above 4GB and fill in banks.
> + * If we failed to allocate bank0 in the lowmem region,
> + * continue allocating from above the lowmem and fill in banks.
> */
> order = get_allocation_size(kinfo->unassigned_mem);
> while ( kinfo->unassigned_mem && kinfo->mem.nr_banks < NR_MEM_BANKS )
> {
> - pg = alloc_domheap_pages(d, order, lowmem ? MEMF_bits(32) : 0);
> + pg = alloc_domheap_pages(d, order,
> + lowmem ? MEMF_bits(lowmem_bitsize) : 0);
> if ( !pg )
> {
> order --;
next prev parent reply other threads:[~2020-05-18 20:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 11:30 [PATCH for-4.14 0/3] Remove the 1GB limitation on Rasberry Pi 4 Julien Grall
2020-05-18 11:30 ` [PATCH for-4.14 1/3] xen/arm: Allow a platform to override the DMA width Julien Grall
2020-05-18 18:24 ` Volodymyr Babchuk
2020-05-20 22:01 ` Stefano Stabellini
2020-05-18 11:30 ` [PATCH for-4.14 2/3] xen/arm: Take into account the DMA width when allocating Dom0 memory banks Julien Grall
2020-05-18 20:34 ` Volodymyr Babchuk [this message]
2020-05-19 16:55 ` Julien Grall
2020-05-18 11:30 ` [PATCH for-4.14 3/3] xen/arm: plat: Allocate as much as possible memory below 1GB for dom0 for RPI Julien Grall
2020-05-18 20:36 ` Volodymyr Babchuk
2020-05-19 0:02 ` Corey Minyard
2020-05-19 17:07 ` Julien Grall
2020-05-19 17:06 ` Julien Grall
2020-05-19 3:08 ` [PATCH for-4.14 0/3] Remove the 1GB limitation on Rasberry Pi 4 Tamas K Lengyel
2020-05-19 17:22 ` Julien Grall
2020-05-19 23:43 ` Tamas K Lengyel
2020-05-19 23:48 ` Stefano Stabellini
2020-05-19 23:50 ` Roman Shaposhnik
2020-05-20 2:15 ` Tamas K Lengyel
2020-05-20 2:28 ` Roman Shaposhnik
2020-05-20 3:06 ` Tamas K Lengyel
2020-05-20 22:13 ` Stefano Stabellini
2020-05-21 17:50 ` Julien Grall
2020-05-21 18:12 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa95369bf22df89404243dd4e7374f8015ccc9ad.camel@epam.com \
--to=volodymyr_babchuk@epam.com \
--cc=jeff.kubascik@dornerworks.com \
--cc=jgrall@amazon.com \
--cc=julien@xen.org \
--cc=minyard@acm.org \
--cc=roman@zededa.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).