From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A190CC433E1 for ; Fri, 7 Aug 2020 12:54:25 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D50F20866 for ; Fri, 7 Aug 2020 12:54:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D50F20866 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k41ss-0006Rw-Rt; Fri, 07 Aug 2020 12:54:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k41ss-0006Rr-Gd for xen-devel@lists.xenproject.org; Fri, 07 Aug 2020 12:54:06 +0000 X-Inumbo-ID: aba66811-5e6b-4b43-84ed-3f6926986aee Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id aba66811-5e6b-4b43-84ed-3f6926986aee; Fri, 07 Aug 2020 12:54:05 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C633AAB8B; Fri, 7 Aug 2020 12:54:22 +0000 (UTC) Subject: Re: [PATCH 05/14] kernel-doc: public/features.h To: Stefano Stabellini References: <20200806234933.16448-5-sstabellini@kernel.org> From: Jan Beulich Message-ID: Date: Fri, 7 Aug 2020 14:54:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200806234933.16448-5-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: julien@xen.org, wl@xen.org, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org, Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 07.08.2020 01:49, Stefano Stabellini wrote: > @@ -41,19 +41,25 @@ > * XENFEAT_dom0 MUST be set if the guest is to be booted as dom0, > */ > > -/* > - * If set, the guest does not need to write-protect its pagetables, and can > - * update them via direct writes. > +/** > + * DOC: XENFEAT_writable_page_tables > + * > + * If set, the guest does not need to write-protect its pagetables, and > + * can update them via direct writes. > */ > #define XENFEAT_writable_page_tables 0 I dislike such redundancy (and it's more noticable here than with the struct-s). Is there really no way for the tool to find the right item, the more that in the cover letter you say that you even need to get the placement right, i.e. there can't be e.g. intervening #define-s? Jan