From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69A5CEB64DA for ; Thu, 15 Jun 2023 21:04:13 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.549891.858685 (Exim 4.92) (envelope-from ) id 1q9u8H-0002wF-6J; Thu, 15 Jun 2023 21:03:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 549891.858685; Thu, 15 Jun 2023 21:03:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q9u8H-0002w8-2r; Thu, 15 Jun 2023 21:03:53 +0000 Received: by outflank-mailman (input) for mailman id 549891; Thu, 15 Jun 2023 21:03:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q9u8F-0002u4-36 for xen-devel@lists.xenproject.org; Thu, 15 Jun 2023 21:03:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1q9u8E-0007Lh-V6; Thu, 15 Jun 2023 21:03:50 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[192.168.16.225]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1q9u8E-0003HR-PM; Thu, 15 Jun 2023 21:03:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=4lIIcwgkI0NoCd2u6GpHXGsiddOZrXBXEq5OOp2uMMM=; b=hlXTc7UnQgnANb5uxIADiyElfn piwIwe9KK7+G32fU6R5IqbBzDGDg32CDAHE7kRPJAIJhctDLCHPE7DSdvufHGAP3hBtCf75T8XIT/ +KwR916739hRZSg+jl7IRnIp5Op2nSzQh+/XSVlmLGYGZbg1wYMIepgLV/HPvSLwepFQ=; Message-ID: Date: Thu, 15 Jun 2023 22:03:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 13/16] tools/xenstore: replace xs_lib.c with a header Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Anthony PERARD References: <20230530085418.5417-1-jgross@suse.com> <20230530085418.5417-14-jgross@suse.com> From: Julien Grall In-Reply-To: <20230530085418.5417-14-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 30/05/2023 09:54, Juergen Gross wrote: > Instead of including the same small C source in multiple binaries from > 2 source directories, use a header file with inline functions as a > replacement. > > As some of the functions are exported by libxenstore, rename the inline > functions from xs_*() do xenstore_*() and add xs_*() wrappers to > libxenstore. > > With that no sources required to build libxenstore are left in > tools/xenstore, so the file COPYING can be removed now. > > Signed-off-by: Juergen Gross Acked-by: Julien Grall Cheers, -- Julien Grall