From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH v2 14/20] xen/grant-table: Make it running on 64KB granularity Date: Fri, 17 Jul 2015 14:37:38 +0100 Message-ID: References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com> <1436474552-31789-15-git-send-email-julien.grall@citrix.com> <55A7DA8F.2040805@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZG5r7-0006UI-2U for xen-devel@lists.xenproject.org; Fri, 17 Jul 2015 13:39:13 +0000 In-Reply-To: <55A7DA8F.2040805@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Russell King , ian.campbell@citrix.com, Stefano Stabellini , linux-kernel@vger.kernel.org, David Vrabel , xen-devel@lists.xenproject.org, Boris Ostrovsky , linux-arm-kernel@lists.infradead.org List-Id: xen-devel@lists.xenproject.org On Thu, 16 Jul 2015, Julien Grall wrote: > Hi Stefano, > > On 16/07/2015 16:47, Stefano Stabellini wrote: > >> diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c > > > index 3679293..0a1f903 100644 > > > --- a/drivers/xen/grant-table.c > > > +++ b/drivers/xen/grant-table.c > > > > The arm part is fine, but aren't you missing the change to RPP and SPP? > > SPP has been removed by commit 548f7c94759ac58d4744ef2663e2a66a106e21c5 as it > was unused. > > For RPP, it's used internally so there is no need to switch to XEN_PAGE_SIZE. > Otherwise we will waste 60KB for each internal page allocated (see > gnttab_init). I see now that RPP is specifically for internal data structures in grant-table.c and it is used consistently. Reviewed-by: Stefano Stabellini