From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH] xen/pt: Don't slurp wholesale the PCI configuration registers Date: Fri, 17 Jul 2015 17:34:55 +0100 Message-ID: References: <1435866681-18468-1-git-send-email-konrad.wilk@oracle.com> <1436383152-18033-1-git-send-email-konrad.wilk@oracle.com> <1436383152-18033-2-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZG8cl-0005nN-Cr for xen-devel@lists.xenproject.org; Fri, 17 Jul 2015 16:36:35 +0000 In-Reply-To: <1436383152-18033-2-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, JBeulich@suse.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Wed, 8 Jul 2015, Konrad Rzeszutek Wilk wrote: > Instead we have the emulation registers ->init functions which > consult the host values to see what the initial value should be > and they are responsible for populating the dev.config. > > Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Stefano Stabellini > hw/xen/xen_pt.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c > index 05828e0..cd69cb4 100644 > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -780,12 +780,7 @@ static int xen_pt_initfn(PCIDevice *d) > } > > /* Initialize virtualized PCI configuration (Extended 256 Bytes) */ > - rc = xen_host_pci_get_block(&s->real_device, 0, d->config, > - PCI_CONFIG_SPACE_SIZE); > - if (rc < 0) { > - XEN_PT_ERR(d,"Could not read PCI_CONFIG space! (rc:%d)\n", rc); > - goto err_out; > - } > + memset(d->config, 0, PCI_CONFIG_SPACE_SIZE); > > s->memory_listener = xen_pt_memory_listener; > s->io_listener = xen_pt_io_listener;