From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: Oldest supported Xen version in upstream QEMU (Was: Re: [Minios-devel] [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl and provide some stable libraries) Date: Wed, 23 Sep 2015 18:36:19 +0100 Message-ID: References: <1436975173.32371.121.camel@citrix.com> <1442934190.10338.175.camel@citrix.com> <1442996950.10338.196.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1442996950.10338.196.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , xen-devel , Wei Liu , Roger Pau Monne , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Wed, 23 Sep 2015, Ian Campbell wrote: > On Tue, 2015-09-22 at 22:31 +0100, Stefano Stabellini wrote: > > The oldest Xen version I build-test for every pull request is Xen 4.0.0, > > I think it is very reasonable to remove anything older than that. > > I am OK with removing Xen 4.0.0 too, but I would like a warning to be > > sent ahead of time to qemu-devel to see if anybody complains. > > There is not much point in removing <=3.4 support and keeping 4.0, since > 4.0.0 was the last one which used a plain int as a handle, anything older > than 4.0.0 is trivial if 4.0.0 is supported. > > One approach I am considering in order to keep 4.0.0 support and earlier > was to turn the "int fd" for <=4.0 into a pointer by having the open > wrapper do malloc(sizeof int) and the using wrappers do xc_foo(*handle). > > This way all the different variants take pointers and we have less hoops to > jump through to typedef everything in the correct way for each variant. > > If you would rather avoid doing that then I think dropping 4.0.0 support > would be the way to go and I'll send a mail to qemu-devel. I would rather drop 4.0 support.