From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
hangaohuai@huawei.com, linux-efi@vger.kernel.org,
ard.biesheuvel@linaro.org, catalin.marinas@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
xen-devel@lists.xen.org,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
stefano.stabellini@citrix.com, david.vrabel@citrix.com,
Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-arm-kernel@lists.infradead.org, shannon.zhao@linaro.org
Subject: Re: [PATCH v5 01/17] Xen: ACPI: Hide UART used by Xen
Date: Fri, 4 Mar 2016 12:24:21 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1603041213400.17938__6235.02069288424$1457094390$gmane$org@kaball.uk.xensource.com> (raw)
In-Reply-To: <1457073455-11516-2-git-send-email-zhaoshenglong@huawei.com>
On Fri, 4 Mar 2016, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> ACPI 6.0 introduces a new table STAO to list the devices which are used
> by Xen and can't be used by Dom0. On Xen virtual platforms, the physical
> UART is used by Xen. So here it hides UART from Dom0.
>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> CC: "Rafael J. Wysocki" <rjw@rjwysocki.net> (supporter:ACPI)
> CC: Len Brown <lenb@kernel.org> (supporter:ACPI)
> CC: linux-acpi@vger.kernel.org (open list:ACPI)
> ---
> drivers/acpi/scan.c | 68 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 68 insertions(+)
>
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index 407a376..31d794c 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -45,6 +45,7 @@ static LIST_HEAD(acpi_scan_handlers_list);
> DEFINE_MUTEX(acpi_device_lock);
> LIST_HEAD(acpi_wakeup_device_list);
> static DEFINE_MUTEX(acpi_hp_context_lock);
> +static u64 spcr_uart_addr;
>
> struct acpi_dep_data {
> struct list_head node;
> @@ -1453,6 +1454,47 @@ static int acpi_add_single_object(struct acpi_device **child,
> return 0;
> }
>
> +static acpi_status acpi_get_resource_fixed_memory32(struct acpi_resource *res,
> + void *context)
> +{
> + struct acpi_resource_fixed_memory32 *fixed_memory32;
> +
> + if (res->type != ACPI_RESOURCE_TYPE_FIXED_MEMORY32)
> + return AE_OK;
> +
> + fixed_memory32 = &res->data.fixed_memory32;
Should we call acpi_resource_to_address64 instead?
Aside from this the rest looks good.
> + if (!fixed_memory32)
> + return AE_OK;
> +
> + *((u32 *)context) = fixed_memory32->address;
> + return AE_CTRL_TERMINATE;
> +}
> +
> +static bool acpi_device_should_be_hidden(acpi_handle handle)
> +{
> + acpi_status status;
> + u32 addr = 0;
> +
> + /* Check if it should ignore the UART device */
> + if (spcr_uart_addr != 0) {
> + if (!acpi_has_method(handle, METHOD_NAME__CRS))
> + return false;
> +
> + status = acpi_walk_resources(handle, METHOD_NAME__CRS,
> + acpi_get_resource_fixed_memory32,
> + &addr);
> + if (ACPI_FAILURE(status))
> + return false;
> +
> + if (addr == spcr_uart_addr) {
> + printk(KERN_INFO PREFIX "The UART device in SPCR table will be hidden\n");
> + return true;
> + }
> + }
> +
> + return false;
> +}
> +
> static int acpi_bus_type_and_status(acpi_handle handle, int *type,
> unsigned long long *sta)
> {
> @@ -1466,6 +1508,9 @@ static int acpi_bus_type_and_status(acpi_handle handle, int *type,
> switch (acpi_type) {
> case ACPI_TYPE_ANY: /* for ACPI_ROOT_OBJECT */
> case ACPI_TYPE_DEVICE:
> + if (acpi_device_should_be_hidden(handle))
> + return -ENODEV;
> +
> *type = ACPI_BUS_TYPE_DEVICE;
> status = acpi_bus_get_status_handle(handle, sta);
> if (ACPI_FAILURE(status))
> @@ -1919,6 +1964,8 @@ static int acpi_bus_scan_fixed(void)
> int __init acpi_scan_init(void)
> {
> int result;
> + acpi_status status;
> + struct acpi_table_stao *stao_ptr;
>
> acpi_pci_root_init();
> acpi_pci_link_init();
> @@ -1933,6 +1980,27 @@ int __init acpi_scan_init(void)
>
> acpi_scan_add_handler(&generic_device_handler);
>
> + /* If there is STAO table, check whether it needs to ignore the UART
> + * device in SPCR table.
> + */
> + status = acpi_get_table(ACPI_SIG_STAO, 0,
> + (struct acpi_table_header **)&stao_ptr);
> + if (ACPI_SUCCESS(status)) {
> + if (stao_ptr->header.length > sizeof(struct acpi_table_stao))
> + printk(KERN_INFO PREFIX "STAO Name List not yet supported.");
> +
> + if (stao_ptr->ignore_uart) {
> + struct acpi_table_spcr *spcr_ptr;
> +
> + status = acpi_get_table(ACPI_SIG_SPCR, 0,
> + (struct acpi_table_header **)&spcr_ptr);
> + if (ACPI_SUCCESS(status))
> + spcr_uart_addr = spcr_ptr->serial_port.address;
> + else
> + printk(KERN_WARNING PREFIX "STAO table present, but SPCR is missing\n");
> + }
> + }
> +
> mutex_lock(&acpi_scan_lock);
> /*
> * Enumerate devices in the ACPI namespace.
> --
> 2.0.4
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-04 12:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 6:37 [PATCH v5 00/17] Add ACPI support for Xen Dom0 on ARM64 Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 01/17] Xen: ACPI: Hide UART used by Xen Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 02/17] xen/grant-table: Move xlated_setup_gnttab_pages to common place Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 03/17] Xen: xlate: Use page_to_xen_pfn instead of page_to_pfn Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 04/17] arm/xen: Use xen_xlate_map_ballooned_pages to setup grant table Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 05/17] xen: memory : Add new XENMAPSPACE type XENMAPSPACE_dev_mmio Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 06/17] Xen: ARM: Add support for mapping platform device mmio Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 07/17] Xen: ARM: Add support for mapping AMBA " Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 08/17] Xen: public/hvm: sync changes of HVM_PARAM_CALLBACK_VIA ABI from Xen Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 09/17] xen/hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 10/17] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 11/17] ARM: XEN: Move xen_early_init() before efi_init() Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 12/17] ARM64: ACPI: Check if it runs on Xen to enable or disable ACPI Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 13/17] ARM: Xen: Document UEFI support on Xen ARM virtual platforms Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 14/17] XEN: EFI: Move x86 specific codes to architecture directory Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 15/17] ARM64: XEN: Add a function to initialize Xen specific UEFI runtime services Shannon Zhao
2016-03-04 6:37 ` Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 16/17] FDT: Add a helper to get the subnode by given name Shannon Zhao
2016-03-04 6:37 ` [PATCH v5 17/17] Xen: EFI: Parse DT parameters for Xen specific UEFI Shannon Zhao
[not found] ` <1457073455-11516-2-git-send-email-zhaoshenglong@huawei.com>
2016-03-04 12:24 ` Stefano Stabellini [this message]
[not found] ` <alpine.DEB.2.02.1603041213400.17938@kaball.uk.xensource.com>
2016-03-04 15:56 ` [PATCH v5 01/17] Xen: ACPI: Hide UART used by Xen Shannon Zhao
[not found] ` <56D9B043.1090301@linaro.org>
2016-03-04 16:28 ` Stefano Stabellini
[not found] ` <1457073455-11516-17-git-send-email-zhaoshenglong@huawei.com>
2016-03-04 12:27 ` [PATCH v5 16/17] FDT: Add a helper to get the subnode by given name Stefano Stabellini
2016-03-18 13:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='alpine.DEB.2.02.1603041213400.17938__6235.02069288424$1457094390$gmane$org@kaball.uk.xensource.com' \
--to=stefano.stabellini@eu.citrix.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=david.vrabel@citrix.com \
--cc=devicetree@vger.kernel.org \
--cc=hangaohuai@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rjw@rjwysocki.net \
--cc=shannon.zhao@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=will.deacon@arm.com \
--cc=xen-devel@lists.xen.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).