From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH v5 01/22] arm/acpi: Estimate memory required for acpi/efi tables Date: Fri, 4 Mar 2016 15:23:16 +0000 Message-ID: References: <1457072152-16128-1-git-send-email-zhaoshenglong@huawei.com> <1457072152-16128-2-git-send-email-zhaoshenglong@huawei.com> <56D96CD502000078000D944A@prv-mh.provo.novell.com> <56D9A3D6.4020804@linaro.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="1342847746-203288647-1457104992=:17938" Return-path: In-Reply-To: <56D9A3D6.4020804@linaro.org> Content-ID: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Shannon Zhao Cc: hangaohuai@huawei.com, Stefano Stabellini , xen-devel@lists.xen.org, stefano.stabellini@citrix.com, Jan Beulich , Shannon Zhao List-Id: xen-devel@lists.xenproject.org --1342847746-203288647-1457104992=:17938 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Content-ID: On Fri, 4 Mar 2016, Shannon Zhao wrote: > On 2016年03月04日 18:55, Stefano Stabellini wrote: > > On Fri, 4 Mar 2016, Jan Beulich wrote: > >>>>> > >>> On 04.03.16 at 07:15, wrote: > >>> > > From: Shannon Zhao > >>> > > > >>> > > Estimate the memory required for loading acpi/efi tables in Dom0. Make > >>> > > the length of each table aligned with 64bit. Alloc the pages to store > >>> > > the new created EFI and ACPI tables and free these pages when > >>> > > destroying domain. > >>> > > > >>> > > Cc: Jan Beulich > >>> > > Signed-off-by: Parth Dixit > >>> > > Signed-off-by: Shannon Zhao > >> > > >> > Since the pattern repeats I finally have to ask: Who is the author > >> > of a patch with such a set of tag? You (From:) or Parth (first S-o-b)? > >> > > >>> > > --- a/xen/common/efi/boot.c > >>> > > +++ b/xen/common/efi/boot.c > >>> > > @@ -1151,6 +1151,13 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) > >>> > > for( ; ; ); /* not reached */ > >>> > > } > >>> > > > >>> > > +#if defined (CONFIG_ACPI) && defined (CONFIG_ARM) > >>> > > +struct meminfo __init *get_acpi_meminfo(void) > >>> > > +{ > >>> > > + return &acpi_mem; > >>> > > +} > >>> > > +#endif > >> > > >> > No such hackery in common code please, if at all avoidable. If ARM > >> > maintainers are fine with this in their code, it could be put into > >> > ARM's efi-boot.h. > > I am OK with that. If you move it under arch/arm, then drop the ifdef > > CONFIG_ARM. > > > While I want to include efi-boot.h in efi-dom.c firstly, but there are > many defined-but-not-used errors because there are some of functions in > efi-boot.h which are not used in efi-dom0.c. > So how could we solve such a problem? It is probably not a good idea to include efi-boot.h in efi-dom.c. Why are you trying to do that? --1342847746-203288647-1457104992=:17938 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --1342847746-203288647-1457104992=:17938--