xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <sstabellini@kernel.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: sstabellini@kernel.org, Keir Fraser <keir@xen.org>,
	Benjamin Sanda <ben.sanda@dornerworks.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Dario Faggioli <dario.faggioli@citrix.com>,
	Tim Deegan <tim@xen.org>,
	George Dunlap <george.dunlap@citrix.com>,
	julien.grall@arm.com, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Paul Sujkov <psujkov@gmail.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH 6/6] xentrace: ARM platform timestamp support
Date: Thu, 31 Mar 2016 17:38:36 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1603311735580.31571@sstabellini-ThinkPad-X230> (raw)
In-Reply-To: <20160325193100.GB14689@char.us.oracle.com>

On Fri, 25 Mar 2016, Konrad Rzeszutek Wilk wrote:
> On Wed, Mar 16, 2016 at 01:51:39PM -0700, Benjamin Sanda wrote:
> > From: bensanda <ben.sanda@dornerworks.com>
> > 
> > Modified to provide support for xentrace on the ARM platform. Changed get_cycles() to return the core timestamp tick count for use by the trace buffer timestamping routines in xentrace.
> > 
> > Signed-off-by: Benjamin Sanda <ben.sanda@dornerworks.com>
> 
> That is missing the CC to Stefano or Julien. CC-ing them.

Thanks


> >  xen/include/asm-arm/time.h | 13 ++++++++-----
> >  1 file changed, 8 insertions(+), 5 deletions(-)
> > 
> > diff --git a/xen/include/asm-arm/time.h b/xen/include/asm-arm/time.h
> > index 5b9a31d..f3a22d5 100644
> > --- a/xen/include/asm-arm/time.h
> > +++ b/xen/include/asm-arm/time.h
> > @@ -1,15 +1,21 @@
> >  #ifndef __ARM_TIME_H__
> >  #define __ARM_TIME_H__
> >  
> > +#include <asm/regs.h>
> > +
> >  #define DT_MATCH_TIMER                      \
> >      DT_MATCH_COMPATIBLE("arm,armv7-timer"), \
> >      DT_MATCH_COMPATIBLE("arm,armv8-timer")
> >  
> > -typedef unsigned long cycles_t;
> > +/* Counter value at boot time */
> > +extern uint64_t boot_count;

Changing cycles_t to uint64_t sounds good, but why did you move
boot_count here from below?


> > +typedef uint64_t cycles_t;
> >  
> >  static inline cycles_t get_cycles (void)
> >  {
> > -        return 0;
> > +        /* return raw tick count of main timer */
> > +        return READ_SYSREG64(CNTPCT_EL0) - boot_count;
> >  }
> >  
> >  /* List of timer's IRQ */
> > @@ -34,9 +40,6 @@ unsigned int timer_get_irq(enum timer_ppi ppi);
> >  /* Set up the timer interrupt on this CPU */
> >  extern void init_timer_interrupt(void);
> >  
> > -/* Counter value at boot time */
> > -extern uint64_t boot_count;
> > -
> >  extern s_time_t ticks_to_ns(uint64_t ticks);
> >  extern uint64_t ns_to_ticks(s_time_t ns);
> >  
> > -- 
> > 2.7.2
> > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-03-31 16:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 20:51 [PATCH 0/6] xentrace/xenalyze support on ARM Benjamin Sanda
2016-03-16 20:51 ` [PATCH 1/6] Flask: Support for ARM xentrace Benjamin Sanda
2016-03-17 14:56   ` Julien Grall
2016-03-17 15:03   ` Julien Grall
2016-03-25 19:27   ` Konrad Rzeszutek Wilk
2016-03-28 15:52     ` Ben Sanda
2016-03-16 20:51 ` [PATCH 2/6] xenalyze: Support for ARM platform Benjamin Sanda
2016-03-16 20:59   ` Andrew Cooper
2016-03-17 10:39     ` George Dunlap
2016-03-16 20:51 ` [PATCH 3/6] xentrace: P2M lookup suport " Benjamin Sanda
2016-03-17 16:21   ` Julien Grall
2016-03-28 18:55     ` Ben Sanda
2016-03-30 18:38       ` Julien Grall
2016-03-16 20:51 ` [PATCH 4/6] xentrace: ARM platform DOMID_XEN mapping support Benjamin Sanda
2016-03-17 15:53   ` Julien Grall
2016-03-16 20:51 ` [PATCH 5/6] xentrace: Trace buffer support for ARM platform Benjamin Sanda
2016-03-16 20:51 ` [PATCH 6/6] xentrace: ARM platform timestamp support Benjamin Sanda
2016-03-25 19:31   ` Konrad Rzeszutek Wilk
2016-03-31 16:38     ` Stefano Stabellini [this message]
2016-03-31 16:44       ` Ben Sanda
2016-04-01 13:05         ` Stefano Stabellini
2016-03-17 15:00 ` [PATCH 0/6] xentrace/xenalyze support on ARM Julien Grall
2016-03-17 16:50   ` Ben Sanda
2016-03-17 17:01     ` Julien Grall
2016-03-17 17:04       ` Ben Sanda
2016-03-18 17:12         ` Wei Liu
2016-03-17 17:23 ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1603311735580.31571@sstabellini-ThinkPad-X230 \
    --to=sstabellini@kernel.org \
    --cc=andrew.cooper3@citrix.com \
    --cc=ben.sanda@dornerworks.com \
    --cc=dario.faggioli@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien.grall@arm.com \
    --cc=keir@xen.org \
    --cc=konrad.wilk@oracle.com \
    --cc=psujkov@gmail.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    --subject='Re: [PATCH 6/6] xentrace: ARM platform timestamp support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).