From: Stefano Stabellini <sstabellini@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
sstabellini@kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
xen-devel@lists.xen.org,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
julien.grall@arm.com, linux-efi@vger.kernel.org,
david.vrabel@citrix.com, Shannon Zhao <zhaoshenglong@huawei.com>,
peter.huangpeng@huawei.com, Len Brown <lenb@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Shannon Zhao <shannon.zhao@linaro.org>
Subject: Re: [PATCH v11 01/17] Xen: ACPI: Hide UART used by Xen
Date: Wed, 20 Apr 2016 10:39:47 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.10.1604201038490.25611__33236.4862006672$1461145271$gmane$org@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <CAJZ5v0gN9S0AKX8SZbbVFOn6ydwCa_7GyxzzJHod8s0xyCXgvA@mail.gmail.com>
On Mon, 18 Apr 2016, Rafael J. Wysocki wrote:
> On Thu, Apr 7, 2016 at 2:03 PM, Shannon Zhao <zhaoshenglong@huawei.com> wrote:
> > From: Shannon Zhao <shannon.zhao@linaro.org>
> >
> > ACPI 6.0 introduces a new table STAO to list the devices which are used
> > by Xen and can't be used by Dom0. On Xen virtual platforms, the physical
> > UART is used by Xen. So here it hides UART from Dom0.
> >
> > CC: "Rafael J. Wysocki" <rjw@rjwysocki.net> (supporter:ACPI)
> > CC: Len Brown <lenb@kernel.org> (supporter:ACPI)
> > CC: linux-acpi@vger.kernel.org (open list:ACPI)
> > Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
I am going to commit it to the xentip tree, if you prefer to take it in
your tree please let me know.
> > ---
> > drivers/acpi/scan.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 74 insertions(+)
> >
> > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> > index 5f28cf7..cfc73fe 100644
> > --- a/drivers/acpi/scan.c
> > +++ b/drivers/acpi/scan.c
> > @@ -46,6 +46,13 @@ DEFINE_MUTEX(acpi_device_lock);
> > LIST_HEAD(acpi_wakeup_device_list);
> > static DEFINE_MUTEX(acpi_hp_context_lock);
> >
> > +/*
> > + * The UART device described by the SPCR table is the only object which needs
> > + * special-casing. Everything else is covered by ACPI namespace paths in STAO
> > + * table.
> > + */
> > +static u64 spcr_uart_addr;
> > +
> > struct acpi_dep_data {
> > struct list_head node;
> > acpi_handle master;
> > @@ -1453,6 +1460,41 @@ static int acpi_add_single_object(struct acpi_device **child,
> > return 0;
> > }
> >
> > +static acpi_status acpi_get_resource_memory(struct acpi_resource *ares,
> > + void *context)
> > +{
> > + struct resource *res = context;
> > +
> > + if (acpi_dev_resource_memory(ares, res))
> > + return AE_CTRL_TERMINATE;
> > +
> > + return AE_OK;
> > +}
> > +
> > +static bool acpi_device_should_be_hidden(acpi_handle handle)
> > +{
> > + acpi_status status;
> > + struct resource res;
> > +
> > + /* Check if it should ignore the UART device */
> > + if (!(spcr_uart_addr && acpi_has_method(handle, METHOD_NAME__CRS)))
> > + return false;
> > +
> > + /*
> > + * The UART device described in SPCR table is assumed to have only one
> > + * memory resource present. So we only look for the first one here.
> > + */
> > + status = acpi_walk_resources(handle, METHOD_NAME__CRS,
> > + acpi_get_resource_memory, &res);
> > + if (ACPI_FAILURE(status) || res.start != spcr_uart_addr)
> > + return false;
> > +
> > + acpi_handle_info(handle, "The UART device @%pa in SPCR table will be hidden\n",
> > + &res.start);
> > +
> > + return true;
> > +}
> > +
> > static int acpi_bus_type_and_status(acpi_handle handle, int *type,
> > unsigned long long *sta)
> > {
> > @@ -1466,6 +1508,9 @@ static int acpi_bus_type_and_status(acpi_handle handle, int *type,
> > switch (acpi_type) {
> > case ACPI_TYPE_ANY: /* for ACPI_ROOT_OBJECT */
> > case ACPI_TYPE_DEVICE:
> > + if (acpi_device_should_be_hidden(handle))
> > + return -ENODEV;
> > +
> > *type = ACPI_BUS_TYPE_DEVICE;
> > status = acpi_bus_get_status_handle(handle, sta);
> > if (ACPI_FAILURE(status))
> > @@ -1916,9 +1961,24 @@ static int acpi_bus_scan_fixed(void)
> > return result < 0 ? result : 0;
> > }
> >
> > +static void __init acpi_get_spcr_uart_addr(void)
> > +{
> > + acpi_status status;
> > + struct acpi_table_spcr *spcr_ptr;
> > +
> > + status = acpi_get_table(ACPI_SIG_SPCR, 0,
> > + (struct acpi_table_header **)&spcr_ptr);
> > + if (ACPI_SUCCESS(status))
> > + spcr_uart_addr = spcr_ptr->serial_port.address;
> > + else
> > + printk(KERN_WARNING PREFIX "STAO table present, but SPCR is missing\n");
> > +}
> > +
> > int __init acpi_scan_init(void)
> > {
> > int result;
> > + acpi_status status;
> > + struct acpi_table_stao *stao_ptr;
> >
> > acpi_pci_root_init();
> > acpi_pci_link_init();
> > @@ -1934,6 +1994,20 @@ int __init acpi_scan_init(void)
> >
> > acpi_scan_add_handler(&generic_device_handler);
> >
> > + /*
> > + * If there is STAO table, check whether it needs to ignore the UART
> > + * device in SPCR table.
> > + */
> > + status = acpi_get_table(ACPI_SIG_STAO, 0,
> > + (struct acpi_table_header **)&stao_ptr);
> > + if (ACPI_SUCCESS(status)) {
> > + if (stao_ptr->header.length > sizeof(struct acpi_table_stao))
> > + printk(KERN_INFO PREFIX "STAO Name List not yet supported.");
> > +
> > + if (stao_ptr->ignore_uart)
> > + acpi_get_spcr_uart_addr();
> > + }
> > +
> > mutex_lock(&acpi_scan_lock);
> > /*
> > * Enumerate devices in the ACPI namespace.
> > --
> > 2.0.4
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-20 9:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1460030614-16112-1-git-send-email-zhaoshenglong@huawei.com>
2016-04-07 12:03 ` [PATCH v11 01/17] Xen: ACPI: Hide UART used by Xen Shannon Zhao
2016-04-07 12:03 ` [PATCH v11 02/17] xen/grant-table: Move xlated_setup_gnttab_pages to common place Shannon Zhao
2016-04-07 12:03 ` [PATCH v11 03/17] Xen: xlate: Use page_to_xen_pfn instead of page_to_pfn Shannon Zhao
2016-04-07 12:03 ` [PATCH v11 04/17] arm/xen: Use xen_xlate_map_ballooned_pages to setup grant table Shannon Zhao
2016-04-07 12:03 ` [PATCH v11 05/17] xen: memory : Add new XENMAPSPACE type XENMAPSPACE_dev_mmio Shannon Zhao
2016-04-07 12:03 ` [PATCH v11 06/17] Xen: ARM: Add support for mapping platform device mmio Shannon Zhao
2016-04-07 12:03 ` [PATCH v11 07/17] Xen: ARM: Add support for mapping AMBA " Shannon Zhao
2016-04-07 12:03 ` [PATCH v11 08/17] Xen: public/hvm: sync changes of HVM_PARAM_CALLBACK_VIA ABI from Xen Shannon Zhao
2016-04-07 12:03 ` [PATCH v11 09/17] xen/hvm/params: Add a new delivery type for event-channel in HVM_PARAM_CALLBACK_IRQ Shannon Zhao
2016-04-07 12:03 ` [PATCH v11 10/17] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI Shannon Zhao
2016-04-07 12:03 ` [PATCH v11 11/17] ARM: XEN: Move xen_early_init() before efi_init() Shannon Zhao
2016-04-07 12:03 ` [PATCH v11 12/17] ARM64: ACPI: Check if it runs on Xen to enable or disable ACPI Shannon Zhao
2016-04-07 12:03 ` [PATCH v11 13/17] ARM: Xen: Document UEFI support on Xen ARM virtual platforms Shannon Zhao
2016-04-07 12:03 ` [PATCH v11 14/17] XEN: EFI: Move x86 specific codes to architecture directory Shannon Zhao
2016-04-07 12:03 ` [PATCH v11 15/17] ARM64: XEN: Add a function to initialize Xen specific UEFI runtime services Shannon Zhao
2016-04-07 12:03 ` [PATCH v11 16/17] FDT: Add a helper to get the subnode by given name Shannon Zhao
2016-04-07 12:03 ` [PATCH v11 17/17] Xen: EFI: Parse DT parameters for Xen specific UEFI Shannon Zhao
[not found] ` <1460030614-16112-2-git-send-email-zhaoshenglong@huawei.com>
2016-04-15 6:43 ` [PATCH v11 01/17] Xen: ACPI: Hide UART used by Xen Shannon Zhao
2016-04-17 23:58 ` Rafael J. Wysocki
[not found] ` <57108D99.5030800@huawei.com>
2016-04-17 23:59 ` Rafael J. Wysocki
[not found] ` <CAJZ5v0gN9S0AKX8SZbbVFOn6ydwCa_7GyxzzJHod8s0xyCXgvA@mail.gmail.com>
2016-04-20 9:39 ` Stefano Stabellini [this message]
[not found] ` <1460030614-16112-13-git-send-email-zhaoshenglong@huawei.com>
2016-04-20 9:34 ` [PATCH v11 12/17] ARM64: ACPI: Check if it runs on Xen to enable or disable ACPI Stefano Stabellini
[not found] ` <alpine.DEB.2.10.1604201033140.25611@sstabellini-ThinkPad-X260>
2016-04-22 10:32 ` Mark Rutland
[not found] ` <20160422103250.GC10606@leverpostej>
2016-04-25 10:15 ` Stefano Stabellini
2016-04-22 10:51 ` Catalin Marinas
[not found] ` <1460030614-16112-12-git-send-email-zhaoshenglong@huawei.com>
2016-04-22 10:51 ` [PATCH v11 11/17] ARM: XEN: Move xen_early_init() before efi_init() Catalin Marinas
[not found] ` <1460030614-16112-16-git-send-email-zhaoshenglong@huawei.com>
2016-04-22 10:54 ` [PATCH v11 15/17] ARM64: XEN: Add a function to initialize Xen specific UEFI runtime services Catalin Marinas
[not found] ` <20160422105427.GG2998@e104818-lin.cambridge.arm.com>
2016-04-22 11:57 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='alpine.DEB.2.10.1604201038490.25611__33236.4862006672$1461145271$gmane$org@sstabellini-ThinkPad-X260' \
--to=sstabellini@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=david.vrabel@citrix.com \
--cc=devicetree@vger.kernel.org \
--cc=julien.grall@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.huangpeng@huawei.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shannon.zhao@linaro.org \
--cc=will.deacon@arm.com \
--cc=xen-devel@lists.xen.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).